Uploaded image for project: 'Infrastructure'
  1. Infrastructure
  2. INFRA-1747

Incrementals quietly not deployed when /scm/url missing

    Details

    • Similar Issues:

      Description

      As noted in https://github.com/jenkins-infra/repository-permissions-updater/pull/804 I initially added a Jenkinsfile to a new plugin (which was already incrementalified) and was surprised to see no incremental deployment yet no error message or explanation in the console. Then I noticed that RPU had not been updated, which would be sufficient to block deployment (but with an error message in the build log!), so I fixed that. Then I ran another PR build https://github.com/jenkinsci/pipeline-log-fluentd-cloudwatch-plugin/pull/2 yet this did not deploy either, and still no information in the build log about why not.

        Attachments

          Issue Links

            Activity

            Hide
            jglick Jesse Glick added a comment -

            Possibly one of the array dereferencings from permissions.js, can think about it…

            Show
            jglick Jesse Glick added a comment - Possibly one of the array dereferencings from permissions.js , can think about it…
            Hide
            jglick Jesse Glick added a comment -

            Aha, I think the problem is the lack of /scm/url which is not being reported properly.

            Show
            jglick Jesse Glick added a comment - Aha, I think the problem is the lack of /scm/url which is not being reported properly.
            Hide
            batmat Baptiste Mathus added a comment -

            Jesse Glick I believe this is done right?

            Show
            batmat Baptiste Mathus added a comment - Jesse Glick I believe this is done right?
            Hide
            jglick Jesse Glick added a comment -

            Well, if my hypothesis of 2018-08-20 is correct, then the deployment function ought to be improved to detect this case and report it properly.

            Show
            jglick Jesse Glick added a comment - Well, if my hypothesis of 2018-08-20 is correct, then the deployment function ought to be improved to detect this case and report it properly.
            Show
            jglick Jesse Glick added a comment - https://ci.jenkins.io/job/Plugins/job/github-api-plugin/job/master/40/execution/node/101/log/ implies that this worked.

              People

              • Assignee:
                Unassigned
                Reporter:
                jglick Jesse Glick
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated: