Uploaded image for project: 'Infrastructure'
  1. Infrastructure
  2. INFRA-2183

Invalid archive, incrementals not published

    Details

    • Similar Issues:
    • Sprint:
      GSoC 2019. Coding Phase 2

      Description

      The incremental deployment of my recently hosted plugin `GitLab Branch Source Plugin` fails with the response:

      `Invalid archive retrieved from Jenkins, perhaps the plugin is not properly incrementalized?`

      The plugin has release permssion: https://github.com/jenkins-infra/repository-permissions-updater/pull/1218

      The plugin repository: https://github.com/jenkinsci/gitlab-branch-source-plugin/

      The deploy stage failure: https://ci.jenkins.io/blue/organizations/jenkins/Plugins%2Fgitlab-branch-source-plugin/detail/develop/9/pipeline/

      This issue was raised based on the discussion here - https://groups.google.com/forum/#!topic/jenkinsci-dev/Df_hT_qeINo

      Any idea what could be the possible reason?

        Attachments

          Issue Links

            Activity

            Hide
            jglick Jesse Glick added a comment -

            R. Tyler Croy made some diagnostic changes a few months ago, but they do not appear to be fully working: AFAICT "${err}" is just blank.

            Show
            jglick Jesse Glick added a comment - R. Tyler Croy made some diagnostic changes a few months ago, but they do not appear to be fully working: AFAICT "${err}" is just blank.
            Hide
            halkeye Gavin Mogan added a comment -

            Unless some weird transpiler, you can't interpolate variables inside double quotes in JavaScript (you could in coffee script). You need backticks or concatenation.
             
            I can submit a simple PR that fixes it, but trying to write tests to catch it better.
             
            (so many hours later)
             
            So i've been refactoring and making tests. I'm going to take this as mine
             
            Jesse Glick if you can point me to an example where it is working, I can create fixtures to make more tests.

            Show
            halkeye Gavin Mogan added a comment - Unless some weird transpiler, you can't interpolate variables inside double quotes in JavaScript (you could in coffee script). You need backticks or concatenation.   I can submit a simple PR that fixes it, but trying to write tests to catch it better.   (so many hours later)   So i've been refactoring and making tests. I'm going to take this as mine   Jesse Glick if you can point me to an example where it is working, I can create fixtures to make more tests.
            Hide
            halkeye Gavin Mogan added a comment -

            Figured a lot of it out, I was making fixtures based on being anon, which didn't have access to the data.

             

            Large PR incoming - https://github.com/jenkins-infra/community-functions/pull/20

            Show
            halkeye Gavin Mogan added a comment - Figured a lot of it out, I was making fixtures based on being anon, which didn't have access to the data.   Large PR incoming - https://github.com/jenkins-infra/community-functions/pull/20
            Hide
            halkeye Gavin Mogan added a comment -

            Parichay Barpanda - your specific error was fixed by https://github.com/jenkinsci/gitlab-branch-source-plugin/commit/ec22604a592fb95fcc21aae89a97366061ff85d8

            the "is allowed to publish" check was checking that field and they didn't match.

            I'm still looking into why its not outputting the error

            Show
            halkeye Gavin Mogan added a comment - Parichay Barpanda - your specific error was fixed by https://github.com/jenkinsci/gitlab-branch-source-plugin/commit/ec22604a592fb95fcc21aae89a97366061ff85d8 the "is allowed to publish" check was checking that field and they didn't match. I'm still looking into why its not outputting the error
            Hide
            baymac Parichay Barpanda added a comment -

            Thanks Gavin Mogan for pointing it out. I wouldn't know otherwise.

            Show
            baymac Parichay Barpanda added a comment - Thanks Gavin Mogan for pointing it out. I wouldn't know otherwise.

              People

              • Assignee:
                halkeye Gavin Mogan
                Reporter:
                baymac Parichay Barpanda
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: