Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-10045

Variable in the URL string is not correctly handled in Subversion Plugin 1.28

    Details

    • Similar Issues:

      Description

      There is a subversion checkout bug which I think was introduced in the Subversion plugin v1.28. I have have URLs of the form https://mysvnserver/project/trunk/builder${SVN_revision_requested}. The variable in the URL is a string parameter from the parameterized build, and is defaulting to blank (null).

      I got this error in Jenkins 1.417 + Subversion plugin 1.28:
      org.tmatesoft.svn.core.SVNException: svn: URL 'https://mysvnserver/project/trunk/builder$%7BSVN_revision_requested%7D' doesn't exist

      Reverting the plugin to v1.26 made the problem go away.

        Attachments

          Issue Links

            Activity

            Hide
            kutzi kutzi added a comment -

            Probably caused by the fix for JENKINS-9925

            Show
            kutzi kutzi added a comment - Probably caused by the fix for JENKINS-9925
            Hide
            rseguy Romain Seguy added a comment -

            I confirm the bug: It happens if and only if the build parameter is blank. It doesn't happen if the parameter is a blank environment variable, or when the build parameter has a value (even a space).

            This is because EnvVars.overrideAll() drops variables when they are null or when they have 0 characters (I'll fill an issue for that, this is weird).

            Show
            rseguy Romain Seguy added a comment - I confirm the bug: It happens if and only if the build parameter is blank. It doesn't happen if the parameter is a blank environment variable, or when the build parameter has a value (even a space). This is because EnvVars.overrideAll() drops variables when they are null or when they have 0 characters (I'll fill an issue for that, this is weird).
            Hide
            rseguy Romain Seguy added a comment -

            I'm currently fixing it.

            Show
            rseguy Romain Seguy added a comment - I'm currently fixing it.
            Hide
            rseguy Romain Seguy added a comment -

            Fixed (by altering the behavior of EnvVars).

            Show
            rseguy Romain Seguy added a comment - Fixed (by altering the behavior of EnvVars).
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: rseguy
            Path:
            src/main/java/hudson/scm/EnvVarsUtils.java
            src/main/java/hudson/scm/SubversionSCM.java
            src/test/java/hudson/scm/SubversionSCMTest.java
            http://jenkins-ci.org/commit/subversion-plugin/7670763631c3e165a34923bc3c10c353975dc99d
            Log:
            [FIXED JENKINS-10045]

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: rseguy Path: src/main/java/hudson/scm/EnvVarsUtils.java src/main/java/hudson/scm/SubversionSCM.java src/test/java/hudson/scm/SubversionSCMTest.java http://jenkins-ci.org/commit/subversion-plugin/7670763631c3e165a34923bc3c10c353975dc99d Log: [FIXED JENKINS-10045]
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: rseguy
            Path:
            src/main/java/hudson/scm/EnvVarsUtils.java
            src/main/java/hudson/scm/SubversionSCM.java
            src/test/java/hudson/scm/SubversionSCMTest.java
            http://jenkins-ci.org/commit/subversion-plugin/7670763631c3e165a34923bc3c10c353975dc99d
            Log:
            [FIXED JENKINS-10045]

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: rseguy Path: src/main/java/hudson/scm/EnvVarsUtils.java src/main/java/hudson/scm/SubversionSCM.java src/test/java/hudson/scm/SubversionSCMTest.java http://jenkins-ci.org/commit/subversion-plugin/7670763631c3e165a34923bc3c10c353975dc99d Log: [FIXED JENKINS-10045]
            Hide
            zhh Hua Zhang added a comment -

            Is this issue related to JENKINS-4547?

            Show
            zhh Hua Zhang added a comment - Is this issue related to JENKINS-4547 ?
            Hide
            rseguy Romain Seguy added a comment -

            No, it's not, JENKINS-4547 is for the "Local module directory (optional)" field.

            Show
            rseguy Romain Seguy added a comment - No, it's not, JENKINS-4547 is for the "Local module directory (optional)" field.

              People

              • Assignee:
                rseguy Romain Seguy
                Reporter:
                mwebber Matthew Webber
              • Votes:
                1 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: