When building the dependency graph, maven modules which are not buildable should be ignored

Details

  • Type: Improvement Improvement
  • Status: Resolved Resolved
  • Priority: Minor Minor
  • Resolution: Fixed
  • Component/s: maven-plugin
  • Labels:
    None

Description

Currently only modules which are disabled themselves - i.e. are no longer part of the moduleset - are excluded.
We should also exclude modules which are not buildable - i.e. whose MavenModuleSets are disabled.

See MavenModule#buildDependencyGraph()
for (MavenModule m : Hudson.getInstance().getAllItems(MavenModule.class)) {
if(m.isDisabled()) continue;

should be replaced with
for (MavenModule m : Hudson.getInstance().getAllItems(MavenModule.class)) {
if(!m.isBuildable()) continue;

Activity

Ascending order - Click to sort in descending order
kutzi made changes -
Field Original Value New Value
Assignee kutzi [ kutzi ]
Hide
Permalink
kutzi added a comment -

Added a pull request https://github.com/jenkinsci/jenkins/pull/200

Show
kutzi added a comment - Added a pull request https://github.com/jenkinsci/jenkins/pull/200
Hide
Permalink
SCM/JIRA link daemon added a comment -

Code changed in jenkins
User: Christoph Kutzinski
Path:
maven-plugin/src/main/java/hudson/maven/MavenModule.java
http://jenkins-ci.org/commit/jenkins/4d8d95b5172387a0f73c61e68eb9aced65da7d7c
Log:
[FIXED JENKINS-10367] Maven modules which are not buildable should be excluded from the dependency graph

Show
SCM/JIRA link daemon added a comment - Code changed in jenkins User: Christoph Kutzinski Path: maven-plugin/src/main/java/hudson/maven/MavenModule.java http://jenkins-ci.org/commit/jenkins/4d8d95b5172387a0f73c61e68eb9aced65da7d7c Log: [FIXED JENKINS-10367] Maven modules which are not buildable should be excluded from the dependency graph
SCM/JIRA link daemon made changes -
Status Open [ 1 ] Resolved [ 5 ]
Resolution Fixed [ 1 ]
Hide
Permalink
SCM/JIRA link daemon added a comment -

Code changed in jenkins
User: Christoph Kutzinski
Path:
changelog.html
http://jenkins-ci.org/commit/jenkins/315d2b611b1278014493c89fde99c9f1603e334a
Log:
Changelog for JENKINS-10366 JENKINS-10367

Show
SCM/JIRA link daemon added a comment - Code changed in jenkins User: Christoph Kutzinski Path: changelog.html http://jenkins-ci.org/commit/jenkins/315d2b611b1278014493c89fde99c9f1603e334a Log: Changelog for JENKINS-10366 JENKINS-10367
Hide
Permalink
dogfood added a comment -

Integrated in jenkins_main_trunk #982
[FIXED JENKINS-10367] Maven modules which are not buildable should be excluded from the dependency graph
Changelog for JENKINS-10366 JENKINS-10367

Christoph Kutzinski : 4d8d95b5172387a0f73c61e68eb9aced65da7d7c
Files :

  • maven-plugin/src/main/java/hudson/maven/MavenModule.java

Christoph Kutzinski : 315d2b611b1278014493c89fde99c9f1603e334a
Files :

  • changelog.html
Show
dogfood added a comment - Integrated in jenkins_main_trunk #982 [FIXED JENKINS-10367] Maven modules which are not buildable should be excluded from the dependency graph Changelog for JENKINS-10366 JENKINS-10367 Christoph Kutzinski : 4d8d95b5172387a0f73c61e68eb9aced65da7d7c Files :
  • maven-plugin/src/main/java/hudson/maven/MavenModule.java
Christoph Kutzinski : 315d2b611b1278014493c89fde99c9f1603e334a Files :
  • changelog.html
Hide
Permalink
SCM/JIRA link daemon added a comment -

Code changed in jenkins
User: Christoph Kutzinski
Path:
maven-plugin/src/main/java/hudson/maven/MavenModule.java
http://jenkins-ci.org/commit/jenkins/4d8d95b5172387a0f73c61e68eb9aced65da7d7c
Log:
[FIXED JENKINS-10367] Maven modules which are not buildable should be excluded from the dependency graph

Show
SCM/JIRA link daemon added a comment - Code changed in jenkins User: Christoph Kutzinski Path: maven-plugin/src/main/java/hudson/maven/MavenModule.java http://jenkins-ci.org/commit/jenkins/4d8d95b5172387a0f73c61e68eb9aced65da7d7c Log: [FIXED JENKINS-10367] Maven modules which are not buildable should be excluded from the dependency graph
Hide
Permalink
SCM/JIRA link daemon added a comment -

Code changed in jenkins
User: Christoph Kutzinski
Path:
changelog.html
http://jenkins-ci.org/commit/jenkins/315d2b611b1278014493c89fde99c9f1603e334a
Log:
Changelog for JENKINS-10366 JENKINS-10367

Show
SCM/JIRA link daemon added a comment - Code changed in jenkins User: Christoph Kutzinski Path: changelog.html http://jenkins-ci.org/commit/jenkins/315d2b611b1278014493c89fde99c9f1603e334a Log: Changelog for JENKINS-10366 JENKINS-10367
Hide
Permalink
SCM/JIRA link daemon added a comment -

Code changed in jenkins
User: Christoph Kutzinski
Path:
maven-plugin/src/main/java/hudson/maven/MavenModule.java
http://jenkins-ci.org/commit/jenkins/4d8d95b5172387a0f73c61e68eb9aced65da7d7c
Log:
[FIXED JENKINS-10367] Maven modules which are not buildable should be excluded from the dependency graph

Show
SCM/JIRA link daemon added a comment - Code changed in jenkins User: Christoph Kutzinski Path: maven-plugin/src/main/java/hudson/maven/MavenModule.java http://jenkins-ci.org/commit/jenkins/4d8d95b5172387a0f73c61e68eb9aced65da7d7c Log: [FIXED JENKINS-10367] Maven modules which are not buildable should be excluded from the dependency graph
Hide
Permalink
SCM/JIRA link daemon added a comment -

Code changed in jenkins
User: Christoph Kutzinski
Path:
changelog.html
http://jenkins-ci.org/commit/jenkins/315d2b611b1278014493c89fde99c9f1603e334a
Log:
Changelog for JENKINS-10366 JENKINS-10367

Show
SCM/JIRA link daemon added a comment - Code changed in jenkins User: Christoph Kutzinski Path: changelog.html http://jenkins-ci.org/commit/jenkins/315d2b611b1278014493c89fde99c9f1603e334a Log: Changelog for JENKINS-10366 JENKINS-10367
Hide
Permalink
SCM/JIRA link daemon added a comment -

Code changed in jenkins
User: Christoph Kutzinski
Path:
src/main/java/hudson/maven/MavenModule.java
http://jenkins-ci.org/commit/maven-plugin/592a67d8ee1d0e1d6456458837d8723669a1ffc3
Log:
[FIXED JENKINS-10367] Maven modules which are not buildable should be excluded from the dependency graph
Originally-Committed-As: 4d8d95b5172387a0f73c61e68eb9aced65da7d7c

Show
SCM/JIRA link daemon added a comment - Code changed in jenkins User: Christoph Kutzinski Path: src/main/java/hudson/maven/MavenModule.java http://jenkins-ci.org/commit/maven-plugin/592a67d8ee1d0e1d6456458837d8723669a1ffc3 Log: [FIXED JENKINS-10367] Maven modules which are not buildable should be excluded from the dependency graph Originally-Committed-As: 4d8d95b5172387a0f73c61e68eb9aced65da7d7c
IRCbot Run by Kohsuke made changes -
Component/s maven-plugin [ 16033 ]
Component/s maven2 [ 15487 ]

People

  • Assignee:
    kutzi
    Reporter:
    kutzi
Vote (0)
Watch (2)

Dates

  • Created:
    Updated:
    Resolved: