Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-10368

Wrong image dimension for Cppcheck Results link on Dashboard

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Trivial
    • Resolution: Fixed
    • Component/s: cppcheck-plugin
    • Labels:
      None
    • Environment:
      OS: Linux, openSUSE;
      OS version: 11.4;
      DE: LXDE;
      WebBrowser: Mozilla Firefox 4.+.

      Description

      Wrong image for Cppcheck Results link on Dashboard.
      Using file: http://jenkins:8080/plugin/cppcheck/icons/cppcheck-24.png
      instead of: http://jenkins:8080/plugin/cppcheck/icons/cppcheck-48.png

        Activity

        Hide
        piatakovsg Sergey Piatakov added a comment -

        Bug is actual for Jenkins v. 1.431 and Cppcheck plugin v. 1.0.1.

        Show
        piatakovsg Sergey Piatakov added a comment - Bug is actual for Jenkins v. 1.431 and Cppcheck plugin v. 1.0.1.
        Hide
        gbois Gregory Boissinot added a comment -

        I don't know how to fix it.
        For the version 1.0.1, do you have "-24.png" or "-48.png"?
        And do you have the right image size?

        Show
        gbois Gregory Boissinot added a comment - I don't know how to fix it. For the version 1.0.1, do you have "-24.png" or "-48.png"? And do you have the right image size?
        Hide
        piatakovsg Sergey Piatakov added a comment -

        1. Sorry for my bad English.
        2. Thank you for patience.
        3. For version 1.0.1 I have "cppcheck-24.png", but I need "cppcheck-48.png".
        4. Please, revert previous fix for this bug. It have broken image in other page and have not influence this bug (https://github.com/jenkinsci/cppcheck-plugin/commit/3c1140b81f0342ce67d0d2ef926a60c938110311).

        Show
        piatakovsg Sergey Piatakov added a comment - 1. Sorry for my bad English. 2. Thank you for patience. 3. For version 1.0.1 I have "cppcheck-24.png", but I need "cppcheck-48.png". 4. Please, revert previous fix for this bug. It have broken image in other page and have not influence this bug ( https://github.com/jenkinsci/cppcheck-plugin/commit/3c1140b81f0342ce67d0d2ef926a60c938110311 ).
        Hide
        scm_issue_link SCM/JIRA link daemon added a comment -

        Code changed in jenkins
        User: Gregory Boissinot
        Path:
        src/main/java/org/jenkinsci/plugins/cppcheck/util/AbstractCppcheckProjectAction.java
        http://jenkins-ci.org/commit/cppcheck-plugin/17d9731ff2990fafe1e4ca04638a34d30625192a
        Log:
        Fix JENKINS-10368

        Show
        scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Gregory Boissinot Path: src/main/java/org/jenkinsci/plugins/cppcheck/util/AbstractCppcheckProjectAction.java http://jenkins-ci.org/commit/cppcheck-plugin/17d9731ff2990fafe1e4ca04638a34d30625192a Log: Fix JENKINS-10368
        Hide
        mixalturek Michal Turek added a comment -

        Closing resolved issue.

        Show
        mixalturek Michal Turek added a comment - Closing resolved issue.

          People

          • Assignee:
            gbois Gregory Boissinot
            Reporter:
            piatakovsg Sergey Piatakov
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: