Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-10589

Jabber "Notification Strategy" settings can't be changed/saved

    Details

      Description

      The Jabber "Notification Strategy" (all, failure, fixed and failure, changed) can be changed when configuring a build, but these changes aren't saved. Therefore the strategy is always 'all', which causes a lot of notifications in our channel.

        Activity

        Hide
        kutzi kutzi added a comment -

        Cannot reproduce. Which plugin versions do you use, which jenkins version do you use, any error messages, ... and all the other stuff you are supposed to put into a good bug report?

        Show
        kutzi kutzi added a comment - Cannot reproduce. Which plugin versions do you use, which jenkins version do you use, any error messages, ... and all the other stuff you are supposed to put into a good bug report?
        Hide
        gruberro gruberro added a comment -

        We are using the currently latest Jenkins version 1.424 and the currently latest plugin versions for Jenkins Jabber notifier plugin 1.19 and Jenkins instant-messaging plugin 1.18. The problem exists since at least 3 Jenkins releases and since at least the former Jabber and IM plugin version. Unfortunately I can't remember the exactly plugin and Jenkins version from which the problem caused initially because for a long time I thought it was my misconfiguration.

        After saving the configuration there are no gui errors and also no errors in the logfile.

        Show
        gruberro gruberro added a comment - We are using the currently latest Jenkins version 1.424 and the currently latest plugin versions for Jenkins Jabber notifier plugin 1.19 and Jenkins instant-messaging plugin 1.18. The problem exists since at least 3 Jenkins releases and since at least the former Jabber and IM plugin version. Unfortunately I can't remember the exactly plugin and Jenkins version from which the problem caused initially because for a long time I thought it was my misconfiguration. After saving the configuration there are no gui errors and also no errors in the logfile.
        Hide
        gruberro gruberro added a comment -

        Oh, I could solve the problem!! I've disabled the IRC plugin and the configuration problem doesn't happens again.

        Sorry for all the inconvenience!

        Regards,
        Robert

        Show
        gruberro gruberro added a comment - Oh, I could solve the problem!! I've disabled the IRC plugin and the configuration problem doesn't happens again. Sorry for all the inconvenience! Regards, Robert
        Hide
        hcguersoy hcguersoy added a comment -

        Hi folks,

        I can confirm the observation of gruberro.
        I can't say if this is an issue of the Jabber plugin or the IRC plugin but it is an incompatibility and IMHO it should be fixed.

        I've tried to edit the configuration file (config.xml) manually using the enum constants from hudson.plugins.jabber.NotificationStrategy but these changes are ignored by the Jabber plugin, too.
        Even the UI ignores the setting the plugin itself should work as it is configured in the config.xml file.

        Thanks in advance.

        Show
        hcguersoy hcguersoy added a comment - Hi folks, I can confirm the observation of gruberro. I can't say if this is an issue of the Jabber plugin or the IRC plugin but it is an incompatibility and IMHO it should be fixed. I've tried to edit the configuration file (config.xml) manually using the enum constants from hudson.plugins.jabber.NotificationStrategy but these changes are ignored by the Jabber plugin, too. Even the UI ignores the setting the plugin itself should work as it is configured in the config.xml file. Thanks in advance.
        Hide
        scm_issue_link SCM/JIRA link daemon added a comment -

        Code changed in jenkins
        User: Christoph Kutzinski
        Path:
        src/main/java/hudson/plugins/im/IMPublisherDescriptor.java
        src/main/java/hudson/plugins/im/config/ParameterNames.java
        src/main/resources/hudson/plugins/im/IMPublisher/global-jenkinsLogin.jelly
        src/main/resources/hudson/plugins/im/IMPublisher/notification-strategy.jelly
        http://jenkins-ci.org/commit/instant-messaging-plugin/3213ccf0e50099412a9d923ff00f683672e22950
        Log:
        Fixed incompatibility between Jabber and IRC plugin regarding configuration parameters JENKINS-10589

        Show
        scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Christoph Kutzinski Path: src/main/java/hudson/plugins/im/IMPublisherDescriptor.java src/main/java/hudson/plugins/im/config/ParameterNames.java src/main/resources/hudson/plugins/im/IMPublisher/global-jenkinsLogin.jelly src/main/resources/hudson/plugins/im/IMPublisher/notification-strategy.jelly http://jenkins-ci.org/commit/instant-messaging-plugin/3213ccf0e50099412a9d923ff00f683672e22950 Log: Fixed incompatibility between Jabber and IRC plugin regarding configuration parameters JENKINS-10589
        Hide
        scm_issue_link SCM/JIRA link daemon added a comment -

        Code changed in jenkins
        User: Christoph Kutzinski
        Path:
        pom.xml
        src/main/java/hudson/plugins/ircbot/IrcPublisher.java
        http://jenkins-ci.org/commit/ircbot-plugin/e81774c77e67c989a73b9ad62b21ae61a95093fb
        Log:
        Fixed incompatibility between Jabber and IRC plugin regarding configuration parameters JENKINS-10589

        Show
        scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Christoph Kutzinski Path: pom.xml src/main/java/hudson/plugins/ircbot/IrcPublisher.java http://jenkins-ci.org/commit/ircbot-plugin/e81774c77e67c989a73b9ad62b21ae61a95093fb Log: Fixed incompatibility between Jabber and IRC plugin regarding configuration parameters JENKINS-10589
        Hide
        scm_issue_link SCM/JIRA link daemon added a comment -

        Code changed in jenkins
        User: Christoph Kutzinski
        Path:
        pom.xml
        src/main/java/hudson/plugins/jabber/im/transport/JabberPublisherDescriptor.java
        http://jenkins-ci.org/commit/jabber-plugin/ee1808dac7297dcc1e3d61842ca5b0e3ed2ca0eb
        Log:
        Fixed incompatibility between Jabber and IRC plugin regarding configuration parameters JENKINS-10589

        Show
        scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Christoph Kutzinski Path: pom.xml src/main/java/hudson/plugins/jabber/im/transport/JabberPublisherDescriptor.java http://jenkins-ci.org/commit/jabber-plugin/ee1808dac7297dcc1e3d61842ca5b0e3ed2ca0eb Log: Fixed incompatibility between Jabber and IRC plugin regarding configuration parameters JENKINS-10589
        Hide
        kutzi kutzi added a comment -

        Thanks for reporting this issue and sorry that it took me so long to fix it.

        Show
        kutzi kutzi added a comment - Thanks for reporting this issue and sorry that it took me so long to fix it.

          People

          • Assignee:
            kutzi kutzi
            Reporter:
            gruberro gruberro
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: