Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-10698

Link "Started by user XXX" broken on build status page if user name modified

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Component/s: core, subversion-plugin
    • Labels:
      None
    • Environment:
      Jenkins 1.425

      Description

      Our Jenkins installation has been set up to authenticate users against LDAP directory server. Source code has been stored to subversion. When people commit changes to subversion, they automatically end up to People list on Jenkins [1]. Each user has fields "Your name" and "E-mail address" populated [2]. Field "Your name" is populated with user ID / login name. The same user ID is used in svn commits. The "E-mail address" field contains a valid email address.

      When a build is triggered manually, the Status page of that build [3] contains a piece of information: "Started by user XXX". The XXX is a link to user data [4]. Similar links are used on the Changes page of a project [5].

      All is fine if the "Your name" field in the user data is left untouched. Sometimes those user IDs can contain all kind of additional coding, which makes them very cryptic. Therefore, it is very tempting to change them to something more human-readable. Changing "Your name" field from "js1234de" to "John Smith" breaks the link XXX on page [3]. The link points to "..user/John%20Smith". Similar links on page [5] are not affected. They still point to "..user/js1234de".

      There is a similar user name related problem with Email-Ext plugin (JENKINS-9160).

      [1] http://<host>/people/
      [2] http://<host>/user/<user-id>/configure
      [3] http://<host>/job/<project-name>/<build-number>/
      [4] http://<host>/user/<user-id>
      [5] http://<host>/job/<project-name>/changes

        Activity

        Hide
        sogabe sogabe added a comment -
        Show
        sogabe sogabe added a comment - I created pull request. See https://github.com/jenkinsci/jenkins/pull/216
        Hide
        salsa Sami Salonen added a comment -

        Thanks Sogabe for your quick fix!

        One small thing. Shouldn't it be "anonymous" in these files, instead of "anonymouse":
        jenkins/core/src/main/resources/hudson/model/Cause/UserIdCause/description.properties
        jenkins/core/src/main/java/hudson/model/Cause.java @ getUserName()

        Show
        salsa Sami Salonen added a comment - Thanks Sogabe for your quick fix! One small thing. Shouldn't it be "anonymous" in these files, instead of "anonymouse": jenkins/core/src/main/resources/hudson/model/Cause/UserIdCause/description.properties jenkins/core/src/main/java/hudson/model/Cause.java @ getUserName()
        Hide
        scm_issue_link SCM/JIRA link daemon added a comment -

        Code changed in jenkins
        User: Seiji Sogabe
        Path:
        changelog.html
        core/src/main/java/hudson/model/AbstractProject.java
        core/src/main/java/hudson/model/Cause.java
        core/src/main/java/hudson/model/ParametersDefinitionProperty.java
        core/src/main/resources/hudson/model/Cause/UserIdCause/description.jelly
        core/src/main/resources/hudson/model/Cause/UserIdCause/description.properties
        core/src/main/resources/hudson/model/Cause/UserIdCause/description_da.properties
        core/src/main/resources/hudson/model/Cause/UserIdCause/description_de.properties
        core/src/main/resources/hudson/model/Cause/UserIdCause/description_es.properties
        core/src/main/resources/hudson/model/Cause/UserIdCause/description_fr.properties
        core/src/main/resources/hudson/model/Cause/UserIdCause/description_it.properties
        core/src/main/resources/hudson/model/Cause/UserIdCause/description_ja.properties
        core/src/main/resources/hudson/model/Cause/UserIdCause/description_ko.properties
        core/src/main/resources/hudson/model/Cause/UserIdCause/description_nl.properties
        core/src/main/resources/hudson/model/Cause/UserIdCause/description_pt_BR.properties
        core/src/main/resources/hudson/model/Cause/UserIdCause/description_ru.properties
        core/src/main/resources/hudson/model/Cause/UserIdCause/description_sl.properties
        core/src/main/resources/hudson/model/Cause/UserIdCause/description_sv_SE.properties
        core/src/main/resources/hudson/model/Cause/UserIdCause/description_zh_CN.properties
        core/src/main/resources/hudson/model/Messages.properties
        core/src/main/resources/hudson/model/Messages_da.properties
        core/src/main/resources/hudson/model/Messages_de.properties
        core/src/main/resources/hudson/model/Messages_es.properties
        core/src/main/resources/hudson/model/Messages_fr.properties
        core/src/main/resources/hudson/model/Messages_ja.properties
        core/src/main/resources/hudson/model/Messages_pt_BR.properties
        core/src/main/resources/hudson/model/Messages_zh_CN.properties
        http://jenkins-ci.org/commit/jenkins/4f421c0e9f35c8ce1ef52e2da79396b6d9e9fce1
        Log:
        [FIXED JENKINS-10698] Link "Started by user XXX" broken on build status page if user name modified.

        record userId not username.

        Show
        scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Seiji Sogabe Path: changelog.html core/src/main/java/hudson/model/AbstractProject.java core/src/main/java/hudson/model/Cause.java core/src/main/java/hudson/model/ParametersDefinitionProperty.java core/src/main/resources/hudson/model/Cause/UserIdCause/description.jelly core/src/main/resources/hudson/model/Cause/UserIdCause/description.properties core/src/main/resources/hudson/model/Cause/UserIdCause/description_da.properties core/src/main/resources/hudson/model/Cause/UserIdCause/description_de.properties core/src/main/resources/hudson/model/Cause/UserIdCause/description_es.properties core/src/main/resources/hudson/model/Cause/UserIdCause/description_fr.properties core/src/main/resources/hudson/model/Cause/UserIdCause/description_it.properties core/src/main/resources/hudson/model/Cause/UserIdCause/description_ja.properties core/src/main/resources/hudson/model/Cause/UserIdCause/description_ko.properties core/src/main/resources/hudson/model/Cause/UserIdCause/description_nl.properties core/src/main/resources/hudson/model/Cause/UserIdCause/description_pt_BR.properties core/src/main/resources/hudson/model/Cause/UserIdCause/description_ru.properties core/src/main/resources/hudson/model/Cause/UserIdCause/description_sl.properties core/src/main/resources/hudson/model/Cause/UserIdCause/description_sv_SE.properties core/src/main/resources/hudson/model/Cause/UserIdCause/description_zh_CN.properties core/src/main/resources/hudson/model/Messages.properties core/src/main/resources/hudson/model/Messages_da.properties core/src/main/resources/hudson/model/Messages_de.properties core/src/main/resources/hudson/model/Messages_es.properties core/src/main/resources/hudson/model/Messages_fr.properties core/src/main/resources/hudson/model/Messages_ja.properties core/src/main/resources/hudson/model/Messages_pt_BR.properties core/src/main/resources/hudson/model/Messages_zh_CN.properties http://jenkins-ci.org/commit/jenkins/4f421c0e9f35c8ce1ef52e2da79396b6d9e9fce1 Log: [FIXED JENKINS-10698] Link "Started by user XXX" broken on build status page if user name modified. record userId not username.
        Hide
        dogfood dogfood added a comment -
        Show
        dogfood dogfood added a comment - Integrated in jenkins_main_trunk #1052
        Hide
        scm_issue_link SCM/JIRA link daemon added a comment -

        Code changed in jenkins
        User: Seiji Sogabe
        Path:
        changelog.html
        core/src/main/java/hudson/model/AbstractProject.java
        core/src/main/java/hudson/model/Cause.java
        core/src/main/java/hudson/model/ParametersDefinitionProperty.java
        core/src/main/resources/hudson/model/Cause/UserIdCause/description.jelly
        core/src/main/resources/hudson/model/Cause/UserIdCause/description.properties
        core/src/main/resources/hudson/model/Cause/UserIdCause/description_da.properties
        core/src/main/resources/hudson/model/Cause/UserIdCause/description_de.properties
        core/src/main/resources/hudson/model/Cause/UserIdCause/description_es.properties
        core/src/main/resources/hudson/model/Cause/UserIdCause/description_fr.properties
        core/src/main/resources/hudson/model/Cause/UserIdCause/description_it.properties
        core/src/main/resources/hudson/model/Cause/UserIdCause/description_ja.properties
        core/src/main/resources/hudson/model/Cause/UserIdCause/description_ko.properties
        core/src/main/resources/hudson/model/Cause/UserIdCause/description_nl.properties
        core/src/main/resources/hudson/model/Cause/UserIdCause/description_pt_BR.properties
        core/src/main/resources/hudson/model/Cause/UserIdCause/description_ru.properties
        core/src/main/resources/hudson/model/Cause/UserIdCause/description_sl.properties
        core/src/main/resources/hudson/model/Cause/UserIdCause/description_sv_SE.properties
        core/src/main/resources/hudson/model/Cause/UserIdCause/description_zh_CN.properties
        core/src/main/resources/hudson/model/Messages.properties
        core/src/main/resources/hudson/model/Messages_da.properties
        core/src/main/resources/hudson/model/Messages_de.properties
        core/src/main/resources/hudson/model/Messages_es.properties
        core/src/main/resources/hudson/model/Messages_fr.properties
        core/src/main/resources/hudson/model/Messages_ja.properties
        core/src/main/resources/hudson/model/Messages_pt_BR.properties
        core/src/main/resources/hudson/model/Messages_zh_CN.properties
        http://jenkins-ci.org/commit/jenkins/4f421c0e9f35c8ce1ef52e2da79396b6d9e9fce1
        Log:
        [FIXED JENKINS-10698] Link "Started by user XXX" broken on build status page if user name modified.

        record userId not username.

        Show
        scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Seiji Sogabe Path: changelog.html core/src/main/java/hudson/model/AbstractProject.java core/src/main/java/hudson/model/Cause.java core/src/main/java/hudson/model/ParametersDefinitionProperty.java core/src/main/resources/hudson/model/Cause/UserIdCause/description.jelly core/src/main/resources/hudson/model/Cause/UserIdCause/description.properties core/src/main/resources/hudson/model/Cause/UserIdCause/description_da.properties core/src/main/resources/hudson/model/Cause/UserIdCause/description_de.properties core/src/main/resources/hudson/model/Cause/UserIdCause/description_es.properties core/src/main/resources/hudson/model/Cause/UserIdCause/description_fr.properties core/src/main/resources/hudson/model/Cause/UserIdCause/description_it.properties core/src/main/resources/hudson/model/Cause/UserIdCause/description_ja.properties core/src/main/resources/hudson/model/Cause/UserIdCause/description_ko.properties core/src/main/resources/hudson/model/Cause/UserIdCause/description_nl.properties core/src/main/resources/hudson/model/Cause/UserIdCause/description_pt_BR.properties core/src/main/resources/hudson/model/Cause/UserIdCause/description_ru.properties core/src/main/resources/hudson/model/Cause/UserIdCause/description_sl.properties core/src/main/resources/hudson/model/Cause/UserIdCause/description_sv_SE.properties core/src/main/resources/hudson/model/Cause/UserIdCause/description_zh_CN.properties core/src/main/resources/hudson/model/Messages.properties core/src/main/resources/hudson/model/Messages_da.properties core/src/main/resources/hudson/model/Messages_de.properties core/src/main/resources/hudson/model/Messages_es.properties core/src/main/resources/hudson/model/Messages_fr.properties core/src/main/resources/hudson/model/Messages_ja.properties core/src/main/resources/hudson/model/Messages_pt_BR.properties core/src/main/resources/hudson/model/Messages_zh_CN.properties http://jenkins-ci.org/commit/jenkins/4f421c0e9f35c8ce1ef52e2da79396b6d9e9fce1 Log: [FIXED JENKINS-10698] Link "Started by user XXX" broken on build status page if user name modified. record userId not username.

          People

          • Assignee:
            sogabe sogabe
            Reporter:
            salsa Sami Salonen
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: