Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-11027

SubversionChangeLogSet.LogEntry should return the revision as commitId

    XMLWordPrintable

    Details

    • Similar Issues:

      Description

      SubversionChangeLogSet.LogEntry does not override getCommitId() from ChangeLogSet.Entry; this leaves the default return value of null; not very useful.

      The trivially correct implementation would be

      @Override
      public String getCommitId()

      { return String.valueOf(revision); }

      (edit: stupid copy-paste bug)

        Attachments

          Activity

          Hide
          dogfood dogfood added a comment -

          Integrated in plugins_subversion #109
          [FIXED JENKINS-11027] implement getCommitId

          kutzi :
          Files :

          • /trunk/hudson/plugins/subversion/src/main/java/hudson/scm/SubversionChangeLogSet.java
          • /trunk/hudson/plugins/subversion/pom.xml
          Show
          dogfood dogfood added a comment - Integrated in plugins_subversion #109 [FIXED JENKINS-11027] implement getCommitId kutzi : Files : /trunk/hudson/plugins/subversion/src/main/java/hudson/scm/SubversionChangeLogSet.java /trunk/hudson/plugins/subversion/pom.xml
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: kutzi
          Path:
          pom.xml
          src/main/java/hudson/scm/SubversionChangeLogSet.java
          http://jenkins-ci.org/commit/subversion-plugin/df35d1e8a87476489622f18a05e5638a88defde0
          Log:
          [FIXED JENKINS-11027] implement getCommitId

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: kutzi Path: pom.xml src/main/java/hudson/scm/SubversionChangeLogSet.java http://jenkins-ci.org/commit/subversion-plugin/df35d1e8a87476489622f18a05e5638a88defde0 Log: [FIXED JENKINS-11027] implement getCommitId
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: kutzi
          Path:
          pom.xml
          src/main/java/hudson/scm/SubversionChangeLogSet.java
          http://jenkins-ci.org/commit/subversion-plugin/df35d1e8a87476489622f18a05e5638a88defde0
          Log:
          [FIXED JENKINS-11027] implement getCommitId

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: kutzi Path: pom.xml src/main/java/hudson/scm/SubversionChangeLogSet.java http://jenkins-ci.org/commit/subversion-plugin/df35d1e8a87476489622f18a05e5638a88defde0 Log: [FIXED JENKINS-11027] implement getCommitId

            People

            • Assignee:
              kutzi kutzi
              Reporter:
              espenhw Espen Wiborg
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: