Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-11032

Subversion no longer passes revision information to other plugins via SubversionTagAction

    XMLWordPrintable

    Details

    • Similar Issues:

      Description

      Somewhere between version 1.28 and version 1.32 of the Subversion plugin, the RevisionParameterAction started being ignored. This action is used by upstream builds to limit the revision that will be fetched by downstream builds - to stop downstream builds getting ahead of upstream builds. Specifically, the Parameterized Trigger Plugin and the Tracking SVN Plugin both use this action.

      A vanilla installation of Jenkins 1.428 (which is bundled with Subversion plugin 1.28) works fine. Upgrading the Subversion plugin to 1.32 breaks.

        Attachments

          Issue Links

            Activity

            Hide
            mread Matt Read added a comment -

            This is a problem for me too based on a simple parameterized trigger config between 2 builds. Reproduceable by fixing the upstream build to a revision number using @XXX at the end of the SVN URL. Prior to the upgrade the dependent build also updates to XXX, afterwards it updates to the latest revision available.

            Show
            mread Matt Read added a comment - This is a problem for me too based on a simple parameterized trigger config between 2 builds. Reproduceable by fixing the upstream build to a revision number using @XXX at the end of the SVN URL. Prior to the upgrade the dependent build also updates to XXX, afterwards it updates to the latest revision available.
            Hide
            danny Danny Yates added a comment - - edited

            I have tracked this down.

            A bug was introduced between 1.29 and 1.30. Specifically, hudson.scm.SubversionSCM r39765, which was a patch applied to fix JENKINS-6209.

            The checkout() method beginning at line 671 creates a SubversionTagAction, but the revList is always empty.

            I have attached a one-line patch which fixes the issue, but there are two caveats:

            1) I don't really understand the SVN externals/pinning stuff, so I'm not sure if this patch actually belongs in one of the branches of the "if (p.pinned)" statement.
            2) I can't get the tests to work on a clean checkout. I'm not a Maven guy, and it just seems to download the entire internet and then fail the tests! Accordingly, I haven't updated SubversionSCMTest to prevent regression of my fix.

            This is now a blocker for us at work, so I would be eternally grateful if a committer could review this ASAP.

            Many thanks!

            Show
            danny Danny Yates added a comment - - edited I have tracked this down. A bug was introduced between 1.29 and 1.30. Specifically, hudson.scm.SubversionSCM r39765, which was a patch applied to fix JENKINS-6209 . The checkout() method beginning at line 671 creates a SubversionTagAction, but the revList is always empty. I have attached a one-line patch which fixes the issue, but there are two caveats: 1) I don't really understand the SVN externals/pinning stuff, so I'm not sure if this patch actually belongs in one of the branches of the "if (p.pinned)" statement. 2) I can't get the tests to work on a clean checkout. I'm not a Maven guy, and it just seems to download the entire internet and then fail the tests! Accordingly, I haven't updated SubversionSCMTest to prevent regression of my fix. This is now a blocker for us at work, so I would be eternally grateful if a committer could review this ASAP. Many thanks!
            Hide
            zhh Hua Zhang added a comment - - edited

            Could this also be the fix of JENKINS-10857? Your patch reminds me the missing part of the config.xml described in this comment, and it was broken since 1.30.

            Show
            zhh Hua Zhang added a comment - - edited Could this also be the fix of JENKINS-10857 ? Your patch reminds me the missing part of the config.xml described in this comment , and it was broken since 1.30.
            Hide
            danny Danny Yates added a comment - - edited

            Yes, I suspect it is. I suggest you reference this ticket from yours and mail the devs mailing list to let them know that we think my patch will fix this bug too. If you're feeling brave, you could even try building the SVN plugin with my fix to see if it works!

            Show
            danny Danny Yates added a comment - - edited Yes, I suspect it is. I suggest you reference this ticket from yours and mail the devs mailing list to let them know that we think my patch will fix this bug too. If you're feeling brave, you could even try building the SVN plugin with my fix to see if it works!
            Hide
            sogabe sogabe added a comment -

            fixed.

            Show
            sogabe sogabe added a comment - fixed.

              People

              • Assignee:
                huybrechts huybrechts
                Reporter:
                danny Danny Yates
              • Votes:
                1 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: