Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-11726

NOT_BUILT should not considered a failure

    Details

    • Similar Issues:

      Description

      When a build returns NOT_BUILT, the Gerrit trigger will consider the verifier a "failure".

      This means there's no way to use pathignore-plugin to skip a Gerrit verifier.

      Ideally, it'd just ignore builds that returned NOT_BUILT, when tallying the results of the verifiers.

        Attachments

          Activity

          Hide
          jorgenpt Jørgen Tjernø added a comment -
          Show
          jorgenpt Jørgen Tjernø added a comment - Pull request with fix here: https://github.com/jenkinsci/gerrit-trigger-plugin/pull/7
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Jørgen P. Tjernø
          Path:
          gerrithudsontrigger/src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/config/Config.java
          gerrithudsontrigger/src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/config/IGerritHudsonTriggerConfig.java
          gerrithudsontrigger/src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/gerritnotifier/ParameterExpander.java
          gerrithudsontrigger/src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/gerritnotifier/model/BuildMemory.java
          gerrithudsontrigger/src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/hudsontrigger/GerritTrigger.java
          gerrithudsontrigger/src/main/resources/com/sonyericsson/hudson/plugins/gerrit/trigger/GerritManagement/index.jelly
          gerrithudsontrigger/src/main/resources/com/sonyericsson/hudson/plugins/gerrit/trigger/hudsontrigger/GerritTrigger/config.jelly
          gerrithudsontrigger/src/main/webapp/help-GerritBuildNotBuiltCodeReview.html
          gerrithudsontrigger/src/main/webapp/help-GerritBuildNotBuiltVerified.html
          gerrithudsontrigger/src/main/webapp/help-GerritVerifiedCmdBuildNotBuilt.html
          gerrithudsontrigger/src/main/webapp/trigger/help-BuildNotBuiltMessage.html
          gerrithudsontrigger/src/main/webapp/trigger/help-GerritBuildNotBuiltCodeReview.html
          gerrithudsontrigger/src/main/webapp/trigger/help-GerritBuildNotBuiltVerified.html
          gerrithudsontrigger/src/test/java/com/sonyericsson/hudson/plugins/gerrit/trigger/config/ConfigTest.java
          gerrithudsontrigger/src/test/java/com/sonyericsson/hudson/plugins/gerrit/trigger/gerritnotifier/ParameterExpanderParameterizedTest.java
          gerrithudsontrigger/src/test/java/com/sonyericsson/hudson/plugins/gerrit/trigger/gerritnotifier/ParameterExpanderTest.java
          gerrithudsontrigger/src/test/java/com/sonyericsson/hudson/plugins/gerrit/trigger/mock/DuplicatesUtil.java
          gerrithudsontrigger/src/test/java/com/sonyericsson/hudson/plugins/gerrit/trigger/mock/MockGerritHudsonTriggerConfig.java
          gerrithudsontrigger/src/test/java/com/sonyericsson/hudson/plugins/gerrit/trigger/mock/Setup.java
          http://jenkins-ci.org/commit/gerrit-trigger-plugin/749c877bf3eefa64bc04de33882cff8b4d1baf5f
          Log:
          JENKINS-11726 Do not count NOT_BUILT as a fail.

          With this change, NOT_BUILT changes are ignored when tallying up what code
          review / verified score to give a change. If none of the builds complete
          (they're all "NOT_BUILT"), then we use the score & command assigned to the
          NotBuilt event.

          This is required for plugins to be able to "skip" some gerrit verifiers. (like
          the pathignore-plugin)

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jørgen P. Tjernø Path: gerrithudsontrigger/src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/config/Config.java gerrithudsontrigger/src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/config/IGerritHudsonTriggerConfig.java gerrithudsontrigger/src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/gerritnotifier/ParameterExpander.java gerrithudsontrigger/src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/gerritnotifier/model/BuildMemory.java gerrithudsontrigger/src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/hudsontrigger/GerritTrigger.java gerrithudsontrigger/src/main/resources/com/sonyericsson/hudson/plugins/gerrit/trigger/GerritManagement/index.jelly gerrithudsontrigger/src/main/resources/com/sonyericsson/hudson/plugins/gerrit/trigger/hudsontrigger/GerritTrigger/config.jelly gerrithudsontrigger/src/main/webapp/help-GerritBuildNotBuiltCodeReview.html gerrithudsontrigger/src/main/webapp/help-GerritBuildNotBuiltVerified.html gerrithudsontrigger/src/main/webapp/help-GerritVerifiedCmdBuildNotBuilt.html gerrithudsontrigger/src/main/webapp/trigger/help-BuildNotBuiltMessage.html gerrithudsontrigger/src/main/webapp/trigger/help-GerritBuildNotBuiltCodeReview.html gerrithudsontrigger/src/main/webapp/trigger/help-GerritBuildNotBuiltVerified.html gerrithudsontrigger/src/test/java/com/sonyericsson/hudson/plugins/gerrit/trigger/config/ConfigTest.java gerrithudsontrigger/src/test/java/com/sonyericsson/hudson/plugins/gerrit/trigger/gerritnotifier/ParameterExpanderParameterizedTest.java gerrithudsontrigger/src/test/java/com/sonyericsson/hudson/plugins/gerrit/trigger/gerritnotifier/ParameterExpanderTest.java gerrithudsontrigger/src/test/java/com/sonyericsson/hudson/plugins/gerrit/trigger/mock/DuplicatesUtil.java gerrithudsontrigger/src/test/java/com/sonyericsson/hudson/plugins/gerrit/trigger/mock/MockGerritHudsonTriggerConfig.java gerrithudsontrigger/src/test/java/com/sonyericsson/hudson/plugins/gerrit/trigger/mock/Setup.java http://jenkins-ci.org/commit/gerrit-trigger-plugin/749c877bf3eefa64bc04de33882cff8b4d1baf5f Log: JENKINS-11726 Do not count NOT_BUILT as a fail. With this change, NOT_BUILT changes are ignored when tallying up what code review / verified score to give a change. If none of the builds complete (they're all "NOT_BUILT"), then we use the score & command assigned to the NotBuilt event. This is required for plugins to be able to "skip" some gerrit verifiers. (like the pathignore-plugin)
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Robert Sandell
          Path:
          gerrithudsontrigger/src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/config/Config.java
          gerrithudsontrigger/src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/config/IGerritHudsonTriggerConfig.java
          gerrithudsontrigger/src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/gerritnotifier/ParameterExpander.java
          gerrithudsontrigger/src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/gerritnotifier/model/BuildMemory.java
          gerrithudsontrigger/src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/hudsontrigger/GerritTrigger.java
          gerrithudsontrigger/src/main/resources/com/sonyericsson/hudson/plugins/gerrit/trigger/GerritManagement/index.jelly
          gerrithudsontrigger/src/main/resources/com/sonyericsson/hudson/plugins/gerrit/trigger/hudsontrigger/GerritTrigger/config.jelly
          gerrithudsontrigger/src/main/webapp/help-GerritBuildNotBuiltCodeReview.html
          gerrithudsontrigger/src/main/webapp/help-GerritBuildNotBuiltVerified.html
          gerrithudsontrigger/src/main/webapp/help-GerritVerifiedCmdBuildNotBuilt.html
          gerrithudsontrigger/src/main/webapp/trigger/help-BuildNotBuiltMessage.html
          gerrithudsontrigger/src/main/webapp/trigger/help-GerritBuildNotBuiltCodeReview.html
          gerrithudsontrigger/src/main/webapp/trigger/help-GerritBuildNotBuiltVerified.html
          gerrithudsontrigger/src/test/java/com/sonyericsson/hudson/plugins/gerrit/trigger/config/ConfigTest.java
          gerrithudsontrigger/src/test/java/com/sonyericsson/hudson/plugins/gerrit/trigger/gerritnotifier/ParameterExpanderParameterizedTest.java
          gerrithudsontrigger/src/test/java/com/sonyericsson/hudson/plugins/gerrit/trigger/gerritnotifier/ParameterExpanderTest.java
          gerrithudsontrigger/src/test/java/com/sonyericsson/hudson/plugins/gerrit/trigger/hudsontrigger/GerritTriggerTest.java
          gerrithudsontrigger/src/test/java/com/sonyericsson/hudson/plugins/gerrit/trigger/mock/DuplicatesUtil.java
          gerrithudsontrigger/src/test/java/com/sonyericsson/hudson/plugins/gerrit/trigger/mock/MockGerritHudsonTriggerConfig.java
          gerrithudsontrigger/src/test/java/com/sonyericsson/hudson/plugins/gerrit/trigger/mock/Setup.java
          http://jenkins-ci.org/commit/gerrit-trigger-plugin/7725166dff76f3da884ccde081086953a206d5ef
          Log:
          Merge pull request #7 from jorgenpt/dont-count-not_built

          JENKINS-11726 Do not count NOT_BUILT.

          Compare: https://github.com/jenkinsci/gerrit-trigger-plugin/compare/f70e4fc86864...7725166dff76

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Robert Sandell Path: gerrithudsontrigger/src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/config/Config.java gerrithudsontrigger/src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/config/IGerritHudsonTriggerConfig.java gerrithudsontrigger/src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/gerritnotifier/ParameterExpander.java gerrithudsontrigger/src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/gerritnotifier/model/BuildMemory.java gerrithudsontrigger/src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/hudsontrigger/GerritTrigger.java gerrithudsontrigger/src/main/resources/com/sonyericsson/hudson/plugins/gerrit/trigger/GerritManagement/index.jelly gerrithudsontrigger/src/main/resources/com/sonyericsson/hudson/plugins/gerrit/trigger/hudsontrigger/GerritTrigger/config.jelly gerrithudsontrigger/src/main/webapp/help-GerritBuildNotBuiltCodeReview.html gerrithudsontrigger/src/main/webapp/help-GerritBuildNotBuiltVerified.html gerrithudsontrigger/src/main/webapp/help-GerritVerifiedCmdBuildNotBuilt.html gerrithudsontrigger/src/main/webapp/trigger/help-BuildNotBuiltMessage.html gerrithudsontrigger/src/main/webapp/trigger/help-GerritBuildNotBuiltCodeReview.html gerrithudsontrigger/src/main/webapp/trigger/help-GerritBuildNotBuiltVerified.html gerrithudsontrigger/src/test/java/com/sonyericsson/hudson/plugins/gerrit/trigger/config/ConfigTest.java gerrithudsontrigger/src/test/java/com/sonyericsson/hudson/plugins/gerrit/trigger/gerritnotifier/ParameterExpanderParameterizedTest.java gerrithudsontrigger/src/test/java/com/sonyericsson/hudson/plugins/gerrit/trigger/gerritnotifier/ParameterExpanderTest.java gerrithudsontrigger/src/test/java/com/sonyericsson/hudson/plugins/gerrit/trigger/hudsontrigger/GerritTriggerTest.java gerrithudsontrigger/src/test/java/com/sonyericsson/hudson/plugins/gerrit/trigger/mock/DuplicatesUtil.java gerrithudsontrigger/src/test/java/com/sonyericsson/hudson/plugins/gerrit/trigger/mock/MockGerritHudsonTriggerConfig.java gerrithudsontrigger/src/test/java/com/sonyericsson/hudson/plugins/gerrit/trigger/mock/Setup.java http://jenkins-ci.org/commit/gerrit-trigger-plugin/7725166dff76f3da884ccde081086953a206d5ef Log: Merge pull request #7 from jorgenpt/dont-count-not_built JENKINS-11726 Do not count NOT_BUILT. Compare: https://github.com/jenkinsci/gerrit-trigger-plugin/compare/f70e4fc86864...7725166dff76
          Hide
          rsandell rsandell added a comment -

          Released in 2.6.0

          Show
          rsandell rsandell added a comment - Released in 2.6.0

            People

            • Assignee:
              rsandell rsandell
              Reporter:
              jorgenpt Jørgen Tjernø
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: