Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-11754

Filtering in multi slave config plugin does not work in IE

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Unresolved
    • Icon: Minor Minor
    • None
    • Jenkins 1.439, Multi slave config plugin 1.0.0, Internet Explorer 9.03

      Steps to reproduce:
      Install Jenkins 1.439 on Ubuntu 11.10 using apt-get.
      Add a slave named "foo".
      Install Multi slave config plugin 1.0.0.
      Go to http://localhost:8080/multi-slave-config-plugin/slavefilter

      Expected result:
      A slave named "foo" should appear.

      Actual:
      It shows "Filter resulted in no hits".

      Reason:
      HTML source of http://localhost:8080/multi-slave-config-plugin/slavefilter starts as following:

      <script src='/adjuncts/7501fde2/org/kohsuke/stapler/framework/prototype/prototype.js' type='text/javascript'></script>
      <script src='/adjuncts/7501fde2/org/kohsuke/stapler/bind.js' type='text/javascript'></script>
      <script>
      it=makeStaplerProxy('/$stapler/bound/c74ed200-2114-479f-8b48-9dcbb43fa2d4','6b54e453-04d8-44d1-be11-4ca3f0eccf38',['doSearch']);
      </script>
      <!DOCTYPE html><html><head>
      

      There are script tags before !DOCTYPE. They cause IE to set its document mode to Quirks.

      Workaround:
      Hit F12 and set document mode to IE9 Standards.

      Patch proposal:

      --- a/src/main/resources/com/sonyericsson/hudson/plugins/multislaveconfigplugin/NodeManageLink/slavefilter.jelly
      +++ b/src/main/resources/com/sonyericsson/hudson/plugins/multislaveconfigplugin/NodeManageLink/slavefilter.jelly
      @@ -1,10 +1,10 @@
       <j:jelly xmlns:j="jelly:core" xmlns:st="jelly:stapler" xmlns:l="/lib/layout" xmlns:f="/lib/form">
           <j:set var="sessionId" value="${request.session.getId()}"/>
       
      -    <st:bind var="it" value="${it}"/>
      -
           <l:layout title="${it.DisplayName}" permission="${it.requiredPermission}">
       
      +        <st:bind var="it" value="${it}"/>
      +
               <st:include page="sidepanel.jelly"/>
       
               <l:header>
      

            rsandell rsandell
            ohtake_tomohiro OHTAKE Tomohiro
            Votes:
            1 Vote for this issue
            Watchers:
            0 Start watching this issue

              Created:
              Updated: