Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-12139

Sorting of files in a project's workspace should ignore case

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Component/s: core
    • Labels:
    • Environment:
      Jenkins version 1.443
    • Similar Issues:

      Description

      When browsing the workspace of a project the sort order of files in the directory listing depends on the case of the filenames, which is confusing and wrong.

        Attachments

          Activity

          Hide
          kutzi kutzi added a comment -

          There are but 2 things I'm concerned about regarding this issue:

          • backwards compatibility: users may complain, if the sorting order changes compared to the previous Jenkins version
          • performance: AFAIK Collator is much slower than String.compare, but that shouldn't matter as long as you don't have thousands of files
          Show
          kutzi kutzi added a comment - There are but 2 things I'm concerned about regarding this issue: backwards compatibility: users may complain, if the sorting order changes compared to the previous Jenkins version performance: AFAIK Collator is much slower than String.compare, but that shouldn't matter as long as you don't have thousands of files
          Hide
          oldelvet Richard Mortimer added a comment -

          @kutzi I don't really have any specific security issues in mind. It was really just a passing comment.

          Show
          oldelvet Richard Mortimer added a comment - @kutzi I don't really have any specific security issues in mind. It was really just a passing comment.
          Hide
          fredg Fred G added a comment -

          Concerning the backwards compatibility: If someone wants the old (wrong) sort order back it could be made configurable. I'd suggest to wait until a user has a relevant use case though.

          Show
          fredg Fred G added a comment - Concerning the backwards compatibility: If someone wants the old (wrong) sort order back it could be made configurable. I'd suggest to wait until a user has a relevant use case though.
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Christoph Kutzinski
          Path:
          changelog.html
          core/src/main/java/hudson/model/DirectoryBrowserSupport.java
          http://jenkins-ci.org/commit/jenkins/f37dcabfb87788dd6ee46966d33b7d27b57cb49e
          Log:
          [FIXED JENKINS-12139] Sort workspace file list based on request locale.

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Christoph Kutzinski Path: changelog.html core/src/main/java/hudson/model/DirectoryBrowserSupport.java http://jenkins-ci.org/commit/jenkins/f37dcabfb87788dd6ee46966d33b7d27b57cb49e Log: [FIXED JENKINS-12139] Sort workspace file list based on request locale.
          Hide
          dogfood dogfood added a comment -

          Integrated in jenkins_main_trunk #1389
          [FIXED JENKINS-12139] Sort workspace file list based on request locale.

          Christoph Kutzinski : f37dcabfb87788dd6ee46966d33b7d27b57cb49e
          Files :

          • core/src/main/java/hudson/model/DirectoryBrowserSupport.java
          • changelog.html
          Show
          dogfood dogfood added a comment - Integrated in jenkins_main_trunk #1389 [FIXED JENKINS-12139] Sort workspace file list based on request locale. Christoph Kutzinski : f37dcabfb87788dd6ee46966d33b7d27b57cb49e Files : core/src/main/java/hudson/model/DirectoryBrowserSupport.java changelog.html

            People

            • Assignee:
              kutzi kutzi
              Reporter:
              fredg Fred G
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: