Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-12216

Rake/Ruby build step is not available in actions for other plugins

    Details

    • Type: Bug
    • Status: In Progress (View Workflow)
    • Priority: Minor
    • Resolution: Unresolved
    • Component/s: rake-plugin, ruby-plugin
    • Labels:
      None
    • Environment:
      Jenkins 1.420 & 1.444
      Rake plugin 1.7.7
      Promoted build plugin 2.4
      Conditional buildstep plugin 0.3
    • Similar Issues:

      Description

      With the Rake plugin installed, a rake build step appears in the list of build steps. However, when also using the promoted builds plugin, the list of
      actions to be executed with a promoted build does not contain the rake build step.

      Upon investigation, the list of possible actions in the promoted builds plugin gets compiled using the following condition:

      BuildStepDescriptor bsd = (BuildStepDescriptor) d;
                      if(bsd.isApplicable(PromotionProcess.class))
                          list.add(d);
      

      (in promoted-builds-plugin/src/main/java/hudson/plugins/promoted_builds/PromotionProcess.java)

      I guess the reason why the Rake builder does not appear in the list of actions, is because the RakeDescriptor class
      extends the Descriptor<Builder> class instead of the BuildStepDescriptor<Builder> class:

      public static final class RakeDescriptor extends Descriptor<Builder> {
      

      (in rake-plugin/src/main/java/hudson/plugins/rake/Rake.java)

      My guess is that adding an

      import hudson.tasks.BuildStepDescriptor;
      

      and changing the RakeDescriptor class to:

      public static final class RakeDescriptor extends BuildStepDescriptor<Builder> {
      

      might fix this.

      I have to say I am a complete Java newbie, and the Jenkins code is unknown to me, so
      I might be way off.

        Attachments

          Activity

          Hide
          didi357 Dieter De Meyer added a comment -

          I have fixed this issue and sent a pull request in the rake-plugin project on Github.
          Pull request can be found here: https://github.com/jenkinsci/rake-plugin/pull/9

          Regards.

          Show
          didi357 Dieter De Meyer added a comment - I have fixed this issue and sent a pull request in the rake-plugin project on Github. Pull request can be found here: https://github.com/jenkinsci/rake-plugin/pull/9 Regards.
          Hide
          didi357 Dieter De Meyer added a comment -

          I also fixed this issue in the ruby-plugin and sent a pull request to the Github repository.
          More info at https://github.com/jenkinsci/ruby-plugin/pull/1

          Show
          didi357 Dieter De Meyer added a comment - I also fixed this issue in the ruby-plugin and sent a pull request to the Github repository. More info at https://github.com/jenkinsci/ruby-plugin/pull/1
          Hide
          willaerk Kristof Willaert added a comment -

          I can confirm this fixes the issue.

          Show
          willaerk Kristof Willaert added a comment - I can confirm this fixes the issue.

            People

            • Assignee:
              dieterdemeyer Dieter De Meyer
              Reporter:
              willaerk Kristof Willaert
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated: