Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-12870

Disk usage disabled when job configuration is edited, comes later back magically

    Details

    • Similar Issues:

      Description

      as Disk usage graph is enabled, it sets a job property on all jobs.
      When the job configuration is edited, this property has no UI and is then removed from configuration. Consequently the job don't display the graph anymore. And then after a while the graph comes back "magically".

      Side effect : when Job Config History plugin is used, SYSTEM changes to enable disk usage pollute the configuration history

        Attachments

          Activity

          Hide
          ndeloof Nicolas De Loof added a comment -

          TransientProjectActionFactory can be used to inject Actions in jobs without requirement to artificially plug such a property on jobs

          Show
          ndeloof Nicolas De Loof added a comment - TransientProjectActionFactory can be used to inject Actions in jobs without requirement to artificially plug such a property on jobs
          Show
          ndeloof Nicolas De Loof added a comment - see https://github.com/jenkinsci/disk-usage-plugin/pull/5
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Nicolas De Loof
          Path:
          pom.xml
          src/main/java/hudson/plugins/disk_usage/DiskUsageProjectActionFactory.java
          src/main/java/hudson/plugins/disk_usage/DiskUsageProperty.java
          src/main/java/hudson/plugins/disk_usage/DiskUsageThread.java
          src/main/resources/hudson/plugins/disk_usage/DiskUsageProjectActionFactory/global.jelly
          src/main/resources/hudson/plugins/disk_usage/DiskUsageProjectActionFactory/global_fr.properties
          src/main/resources/hudson/plugins/disk_usage/DiskUsageProjectActionFactory/global_ja.properties
          src/main/resources/hudson/plugins/disk_usage/DiskUsageProjectActionFactory/global_ru.properties
          src/main/resources/hudson/plugins/disk_usage/DiskUsageProperty/global.jelly
          src/main/resources/hudson/plugins/disk_usage/DiskUsageProperty/global_fr.properties
          src/main/resources/hudson/plugins/disk_usage/DiskUsageProperty/global_ja.properties
          src/main/resources/hudson/plugins/disk_usage/DiskUsageProperty/global_ru.properties
          http://jenkins-ci.org/commit/disk-usage-plugin/5af43feb43bf57f090a43e621c6f2fcd3832751c
          Log:
          [FIXED JENKINS-12870]
          refactored DiskUsageAction "injection" using a TransientProjectActionFactory
          avoid to pollute jobs configuration and history with a JobProperty

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Nicolas De Loof Path: pom.xml src/main/java/hudson/plugins/disk_usage/DiskUsageProjectActionFactory.java src/main/java/hudson/plugins/disk_usage/DiskUsageProperty.java src/main/java/hudson/plugins/disk_usage/DiskUsageThread.java src/main/resources/hudson/plugins/disk_usage/DiskUsageProjectActionFactory/global.jelly src/main/resources/hudson/plugins/disk_usage/DiskUsageProjectActionFactory/global_fr.properties src/main/resources/hudson/plugins/disk_usage/DiskUsageProjectActionFactory/global_ja.properties src/main/resources/hudson/plugins/disk_usage/DiskUsageProjectActionFactory/global_ru.properties src/main/resources/hudson/plugins/disk_usage/DiskUsageProperty/global.jelly src/main/resources/hudson/plugins/disk_usage/DiskUsageProperty/global_fr.properties src/main/resources/hudson/plugins/disk_usage/DiskUsageProperty/global_ja.properties src/main/resources/hudson/plugins/disk_usage/DiskUsageProperty/global_ru.properties http://jenkins-ci.org/commit/disk-usage-plugin/5af43feb43bf57f090a43e621c6f2fcd3832751c Log: [FIXED JENKINS-12870] refactored DiskUsageAction "injection" using a TransientProjectActionFactory avoid to pollute jobs configuration and history with a JobProperty
          Hide
          dogfood dogfood added a comment -

          Integrated in plugins_disk-usage #38
          [FIXED JENKINS-12870] (Revision 5af43feb43bf57f090a43e621c6f2fcd3832751c)

          Result = SUCCESS
          Nicolas De Loof :
          Files :

          • src/main/java/hudson/plugins/disk_usage/DiskUsageProjectActionFactory.java
          • src/main/resources/hudson/plugins/disk_usage/DiskUsageProjectActionFactory/global_fr.properties
          • src/main/resources/hudson/plugins/disk_usage/DiskUsageProperty/global_ja.properties
          • src/main/resources/hudson/plugins/disk_usage/DiskUsageProperty/global_fr.properties
          • src/main/resources/hudson/plugins/disk_usage/DiskUsageProperty/global_ru.properties
          • src/main/resources/hudson/plugins/disk_usage/DiskUsageProjectActionFactory/global_ja.properties
          • src/main/java/hudson/plugins/disk_usage/DiskUsageProperty.java
          • pom.xml
          • src/main/java/hudson/plugins/disk_usage/DiskUsageThread.java
          • src/main/resources/hudson/plugins/disk_usage/DiskUsageProjectActionFactory/global.jelly
          • src/main/resources/hudson/plugins/disk_usage/DiskUsageProperty/global.jelly
          • src/main/resources/hudson/plugins/disk_usage/DiskUsageProjectActionFactory/global_ru.properties
          Show
          dogfood dogfood added a comment - Integrated in plugins_disk-usage #38 [FIXED JENKINS-12870] (Revision 5af43feb43bf57f090a43e621c6f2fcd3832751c) Result = SUCCESS Nicolas De Loof : Files : src/main/java/hudson/plugins/disk_usage/DiskUsageProjectActionFactory.java src/main/resources/hudson/plugins/disk_usage/DiskUsageProjectActionFactory/global_fr.properties src/main/resources/hudson/plugins/disk_usage/DiskUsageProperty/global_ja.properties src/main/resources/hudson/plugins/disk_usage/DiskUsageProperty/global_fr.properties src/main/resources/hudson/plugins/disk_usage/DiskUsageProperty/global_ru.properties src/main/resources/hudson/plugins/disk_usage/DiskUsageProjectActionFactory/global_ja.properties src/main/java/hudson/plugins/disk_usage/DiskUsageProperty.java pom.xml src/main/java/hudson/plugins/disk_usage/DiskUsageThread.java src/main/resources/hudson/plugins/disk_usage/DiskUsageProjectActionFactory/global.jelly src/main/resources/hudson/plugins/disk_usage/DiskUsageProperty/global.jelly src/main/resources/hudson/plugins/disk_usage/DiskUsageProjectActionFactory/global_ru.properties
          Hide
          gjoseph Grégory Joseph added a comment - - edited

          I still see the side-effect described here, except the history entry appears as "added" by me, not the SYSTEM user.
          edit: hmm, i'm probably suffering from JENKINS-20176, sorry. Issues might benefit from being linked.

          Show
          gjoseph Grégory Joseph added a comment - - edited I still see the side-effect described here, except the history entry appears as "added" by me, not the SYSTEM user. edit: hmm, i'm probably suffering from JENKINS-20176 , sorry. Issues might benefit from being linked.

            People

            • Assignee:
              ndeloof Nicolas De Loof
              Reporter:
              ndeloof Nicolas De Loof
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: