Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-13192

groovy template meets error when there are git changes

    Details

    • Type: Bug
    • Status: Resolved (View Workflow)
    • Priority: Minor
    • Resolution: Fixed
    • Component/s: email-ext-plugin
    • Labels:
      None
    • Environment:
      ubuntu 11.10/openjdk/jenkins1.452/git
    • Similar Issues:

      Description

      groovy template had some errors for html/txt report when it has git changes, I didn't check for svn/cvs

      Following varible doesn't recognize inside groovy

      • cs.hudsonUser (no husdonUser for changeSet class, it just error instead of return nil)
      • cs.changeNumber (does it work for cvs or svn ?)

      Since I don't know the background and other environment (cvs/svn), I can't provide complete patch

      rgs/larry

        Attachments

          Activity

          Hide
          slide_o_mix Alex Earl added a comment -

          The default template is meant more to be an example rather than a fully working version. Please create a template that will work for your exact situation. If you do see specific errors, please feel free to submit a pull request for those.

          Show
          slide_o_mix Alex Earl added a comment - The default template is meant more to be an example rather than a fully working version. Please create a template that will work for your exact situation. If you do see specific errors, please feel free to submit a pull request for those.
          Hide
          larrycai Larry Cai added a comment -

          Haha, ok, fixed now.

          See pull request https://github.com/jenkinsci/email-ext-plugin/pull/36

          Show
          larrycai Larry Cai added a comment - Haha, ok, fixed now. See pull request https://github.com/jenkinsci/email-ext-plugin/pull/36
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Larry Cai
          Path:
          src/main/resources/hudson/plugins/emailext/templates/groovy-html.template
          http://jenkins-ci.org/commit/email-ext-plugin/4c16db3144bd23fcacbc3f12ebd8611eddfc9f3c
          Log:
          Fix JENKINS-13192

          • husdonUser doesn't exist, use author directly
          • changeNumber doesn't exist, add check whether the property exist, otherwise show space
          • msgAnnotated doesn't exist for it, change to cs

          all those parameters need to check in ChangeLogSet or inherited class

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Larry Cai Path: src/main/resources/hudson/plugins/emailext/templates/groovy-html.template http://jenkins-ci.org/commit/email-ext-plugin/4c16db3144bd23fcacbc3f12ebd8611eddfc9f3c Log: Fix JENKINS-13192 husdonUser doesn't exist, use author directly changeNumber doesn't exist, add check whether the property exist, otherwise show space msgAnnotated doesn't exist for it, change to cs all those parameters need to check in ChangeLogSet or inherited class
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: slide
          Path:
          src/main/resources/hudson/plugins/emailext/templates/groovy-html.template
          http://jenkins-ci.org/commit/email-ext-plugin/552bd6c80ca85c3b288abf338ef7ce7275e42247
          Log:
          Merge pull request #36 from larrycai/master

          Bug fix for JENKINS-13192

          Compare: https://github.com/jenkinsci/email-ext-plugin/compare/5b20b8e...552bd6c

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: slide Path: src/main/resources/hudson/plugins/emailext/templates/groovy-html.template http://jenkins-ci.org/commit/email-ext-plugin/552bd6c80ca85c3b288abf338ef7ce7275e42247 Log: Merge pull request #36 from larrycai/master Bug fix for JENKINS-13192 Compare: https://github.com/jenkinsci/email-ext-plugin/compare/5b20b8e...552bd6c
          Hide
          slide_o_mix Alex Earl added a comment -

          Please close if resolved.

          Show
          slide_o_mix Alex Earl added a comment - Please close if resolved.
          Hide
          cinquero Mark S. added a comment -

          The text variant of the same template still has that bug.

          Show
          cinquero Mark S. added a comment - The text variant of the same template still has that bug.
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: slide
          Path:
          src/main/resources/hudson/plugins/emailext/templates/groovy-text.template
          http://jenkins-ci.org/commit/email-ext-plugin/86f5f9e91b839be3b944d9b4a2fd7ceb2c0dfe41
          Log:
          Fix JENKINS-13192 for text template

          • Fixed the author issue for the text template as well.
          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: slide Path: src/main/resources/hudson/plugins/emailext/templates/groovy-text.template http://jenkins-ci.org/commit/email-ext-plugin/86f5f9e91b839be3b944d9b4a2fd7ceb2c0dfe41 Log: Fix JENKINS-13192 for text template Fixed the author issue for the text template as well.

            People

            • Assignee:
              slide_o_mix Alex Earl
              Reporter:
              larrycai Larry Cai
            • Votes:
              1 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: