Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-13589

Erroneous calculation of threshold crossing

    XMLWordPrintable

    Details

    • Similar Issues:

      Description

      There is a typo in

      https://github.com/jenkinsci/cppcheck-plugin/blob/master/src/main/java/org/jenkinsci/plugins/cppcheck/CppcheckResult.java#L211

      as result plugin incorrectly calculates total amount of errors

      - nbErrors = this.getReport().getWarningSeverityList().size();
      + nbErrors = nbErrors + this.getReport().getWarningSeverityList().size();
      

      and for previous errors

      https://github.com/jenkinsci/cppcheck-plugin/blob/master/src/main/java/org/jenkinsci/plugins/cppcheck/CppcheckResult.java#L213

      - nbPreviousError = previousResult.getReport().getWarningSeverityList().size();
      + nbPreviousError = nbPreviousError + previousResult.getReport().getWarningSeverityList().size();
      

      Please correct.

        Attachments

          Activity

          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Gregory Boissinot
          Path:
          src/main/java/org/jenkinsci/plugins/cppcheck/CppcheckResult.java
          http://jenkins-ci.org/commit/cppcheck-plugin/2c22881a62bd4bd4fa8797cdc7cd8d2afc92f868
          Log:
          Fix JENKINS-13589

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Gregory Boissinot Path: src/main/java/org/jenkinsci/plugins/cppcheck/CppcheckResult.java http://jenkins-ci.org/commit/cppcheck-plugin/2c22881a62bd4bd4fa8797cdc7cd8d2afc92f868 Log: Fix JENKINS-13589
          Hide
          gbois Gregory Boissinot added a comment -

          Thank you so much to report it.
          Fixed

          Show
          gbois Gregory Boissinot added a comment - Thank you so much to report it. Fixed
          Hide
          mixalturek Michal Turek added a comment -

          Closing.

          Show
          mixalturek Michal Turek added a comment - Closing.

            People

            • Assignee:
              gbois Gregory Boissinot
              Reporter:
              jbmaster Alexandr Penzai
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: