Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-13656

Trend graph shows values of wrong parser

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Resolved (View Workflow)
    • Priority: Minor
    • Resolution: Fixed
    • Component/s: warnings-plugin
    • Labels:
      None
    • Environment:
      Jenkins ver. 1.458, warnings v4.4
    • Similar Issues:

      Description

      If there are several parsers activated, then the trend graph picks always the results of the first parser instead of the selected one.

        Attachments

        1. build.xml
          10 kB
        2. build54.png
          build54.png
          6 kB
        3. enlarged_graph.png
          enlarged_graph.png
          8 kB
        4. wrong_graph.png
          wrong_graph.png
          6 kB

          Activity

          darkv Johann Werner created issue -
          Hide
          drulli Ulli Hafner added a comment -

          Can you please provide more details. Eg. screenshot, etc.

          Show
          drulli Ulli Hafner added a comment - Can you please provide more details. Eg. screenshot, etc.
          Hide
          darkv Johann Werner added a comment -

          Sorry, it appears that the wrong values in that case were caused by an intermediate build of the warnings plugin v4.0 that lacked the Javadoc parser.
          Though I see on another project that a wrong value is shown in the graph. See the attached screenshot. The values for builds #51 and #52 have been processed by warnings v3.28 and are correct but then #53 (using warnings v4.4) shows wrong value where it should have 457.

          Show
          darkv Johann Werner added a comment - Sorry, it appears that the wrong values in that case were caused by an intermediate build of the warnings plugin v4.0 that lacked the Javadoc parser. Though I see on another project that a wrong value is shown in the graph. See the attached screenshot. The values for builds #51 and #52 have been processed by warnings v3.28 and are correct but then #53 (using warnings v4.4) shows wrong value where it should have 457.
          darkv Johann Werner made changes -
          Field Original Value New Value
          Attachment wrong_graph.png [ 21780 ]
          Hide
          drulli Ulli Hafner added a comment -

          Hmm, seems that there is no result at all (0 warnings). Does the same image appear if you enlarge the graph? Or press CTRL-F5 to recreate the graph...

          Show
          drulli Ulli Hafner added a comment - Hmm, seems that there is no result at all (0 warnings). Does the same image appear if you enlarge the graph? Or press CTRL-F5 to recreate the graph...
          Hide
          drulli Ulli Hafner added a comment -

          And please attach the build.xml file of your build #53.

          Show
          drulli Ulli Hafner added a comment - And please attach the build.xml file of your build #53.
          drulli Ulli Hafner made changes -
          Summary Trend graph is shifted Trend graph shows zero instead of actual value
          drulli Ulli Hafner made changes -
          Description The trend graph is shifted one step to the left thus having wrong y values: the displayed value for the build n is the one of build (n-1). The trend graph does not show all results. At least for one build zero is shown even though there are > 400 warnings.
          Hide
          drulli Ulli Hafner added a comment - - edited

          And finally: can you start another build just to see if the warnings count stays at zero in the graph...

          Show
          drulli Ulli Hafner added a comment - - edited And finally: can you start another build just to see if the warnings count stays at zero in the graph...
          Hide
          darkv Johann Werner added a comment -

          It looks like it's greater than 0 (see screenshot of enlarged graph). CTRL-F5 doesn't have any effect (is that command anywhere documented?).
          The build.xml file won't make you happy, the ant build uses more than 50 build.xml files in several different locations (actually the build is for https://github.com/projectwonder/wonder)

          Show
          darkv Johann Werner added a comment - It looks like it's greater than 0 (see screenshot of enlarged graph). CTRL-F5 doesn't have any effect (is that command anywhere documented?). The build.xml file won't make you happy, the ant build uses more than 50 build.xml files in several different locations (actually the build is for https://github.com/projectwonder/wonder )
          darkv Johann Werner made changes -
          Attachment enlarged_graph.png [ 21781 ]
          Attachment build54.png [ 21782 ]
          Hide
          drulli Ulli Hafner added a comment -

          Sorry, I mean the build.xml file in Jenkins build folder of your project. There Jenkins serializes the build results. In that file I can check if the WarningsResult is correctly serialized.

          Did you already start another build?

          Show
          drulli Ulli Hafner added a comment - Sorry, I mean the build.xml file in Jenkins build folder of your project. There Jenkins serializes the build results. In that file I can check if the WarningsResult is correctly serialized. Did you already start another build?
          Hide
          darkv Johann Werner added a comment -

          There is the build.xml file.
          I did a new build for which I attached already a screenshot before (build #54) but that showed no change.

          Show
          darkv Johann Werner added a comment - There is the build.xml file. I did a new build for which I attached already a screenshot before (build #54) but that showed no change.
          darkv Johann Werner made changes -
          Attachment build.xml [ 21783 ]
          Hide
          drulli Ulli Hafner added a comment -

          Ok, thanks. From the build.xml I see that there are 7 warnings for Java and 457 for JavaDoc.

          Maybe the wrong result is used in the JavaDoc trend. Does the trend graph for Java warnings work?

          Show
          drulli Ulli Hafner added a comment - Ok, thanks. From the build.xml I see that there are 7 warnings for Java and 457 for JavaDoc. Maybe the wrong result is used in the JavaDoc trend. Does the trend graph for Java warnings work?
          Hide
          darkv Johann Werner added a comment -

          The Java trend graph seems correct.
          On another project I have 1 Java and 0 Javadoc warnings but both graphs show 1. So your assumption seems plausible.

          Show
          darkv Johann Werner added a comment - The Java trend graph seems correct. On another project I have 1 Java and 0 Javadoc warnings but both graphs show 1. So your assumption seems plausible.
          Hide
          drulli Ulli Hafner added a comment -

          Ok, I can reproduce the problem. Seems that always the first result is used...

          Show
          drulli Ulli Hafner added a comment - Ok, I can reproduce the problem. Seems that always the first result is used...
          drulli Ulli Hafner made changes -
          Summary Trend graph shows zero instead of actual value Trend graph shows values of wrong parser
          Description The trend graph does not show all results. At least for one build zero is shown even though there are > 400 warnings. If there are several parsers activated, then the trend graph picks always the results of the first parser instead of the selected one.
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Ulli Hafner
          Path:
          src/main/java/hudson/plugins/analysis/core/BuildHistory.java
          http://jenkins-ci.org/commit/analysis-core-plugin/bc48fb59837664ebddab0ef7233cd42e8f6a4c9e
          Log:
          [FIXED JENKINS-13656] Pick correct results for baseline.

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Ulli Hafner Path: src/main/java/hudson/plugins/analysis/core/BuildHistory.java http://jenkins-ci.org/commit/analysis-core-plugin/bc48fb59837664ebddab0ef7233cd42e8f6a4c9e Log: [FIXED JENKINS-13656] Pick correct results for baseline.
          scm_issue_link SCM/JIRA link daemon made changes -
          Status Open [ 1 ] Resolved [ 5 ]
          Resolution Fixed [ 1 ]
          Hide
          dogfood dogfood added a comment -

          Integrated in plugins_analysis-core #10445
          [FIXED JENKINS-13656] Pick correct results for baseline. (Revision bc48fb59837664ebddab0ef7233cd42e8f6a4c9e)

          Result = SUCCESS
          Ulli Hafner :
          Files :

          • src/main/java/hudson/plugins/analysis/core/BuildHistory.java
          Show
          dogfood dogfood added a comment - Integrated in plugins_analysis-core #10445 [FIXED JENKINS-13656] Pick correct results for baseline. (Revision bc48fb59837664ebddab0ef7233cd42e8f6a4c9e) Result = SUCCESS Ulli Hafner : Files : src/main/java/hudson/plugins/analysis/core/BuildHistory.java
          Hide
          drulli Ulli Hafner added a comment -

          Integrated in Jenkins Analysis Plug-ins (Compile) #488
          [FIXED JENKINS-13656] Pick correct results for baseline. (Revision bc48fb59837664ebddab0ef7233cd42e8f6a4c9e)

          Result = SUCCESS

          Show
          drulli Ulli Hafner added a comment - Integrated in Jenkins Analysis Plug-ins (Compile) #488 [FIXED JENKINS-13656] Pick correct results for baseline. (Revision bc48fb59837664ebddab0ef7233cd42e8f6a4c9e) Result = SUCCESS
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Ulli Hafner
          Path:
          src/main/java/hudson/plugins/analysis/core/BuildResult.java
          http://jenkins-ci.org/commit/analysis-core-plugin/6a01bb768e88b9697652e8e006cb39d00967ebfc
          Log:
          [FIXED JENKINS-13656] Make build history creation overridable.

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Ulli Hafner Path: src/main/java/hudson/plugins/analysis/core/BuildResult.java http://jenkins-ci.org/commit/analysis-core-plugin/6a01bb768e88b9697652e8e006cb39d00967ebfc Log: [FIXED JENKINS-13656] Make build history creation overridable.
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Ulli Hafner
          Path:
          pom.xml
          src/main/java/hudson/plugins/warnings/WarningsResult.java
          http://jenkins-ci.org/commit/warnings-plugin/7db20dda08df20c7ba829a4c1b0f3d462e307140
          Log:
          [FIXED JENKINS-13656] Use warnings history when restoring an instance of
          WarningsResult.

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Ulli Hafner Path: pom.xml src/main/java/hudson/plugins/warnings/WarningsResult.java http://jenkins-ci.org/commit/warnings-plugin/7db20dda08df20c7ba829a4c1b0f3d462e307140 Log: [FIXED JENKINS-13656] Use warnings history when restoring an instance of WarningsResult.
          Hide
          dogfood dogfood added a comment -

          Integrated in plugins_analysis-core #10446
          [FIXED JENKINS-13656] Make build history creation overridable. (Revision 6a01bb768e88b9697652e8e006cb39d00967ebfc)

          Result = SUCCESS
          Ulli Hafner :
          Files :

          • src/main/java/hudson/plugins/analysis/core/BuildResult.java
          Show
          dogfood dogfood added a comment - Integrated in plugins_analysis-core #10446 [FIXED JENKINS-13656] Make build history creation overridable. (Revision 6a01bb768e88b9697652e8e006cb39d00967ebfc) Result = SUCCESS Ulli Hafner : Files : src/main/java/hudson/plugins/analysis/core/BuildResult.java
          Hide
          dogfood dogfood added a comment -

          Integrated in plugins_warnings #404
          [FIXED JENKINS-13656] Use warnings history when restoring an instance of (Revision 7db20dda08df20c7ba829a4c1b0f3d462e307140)

          Result = UNSTABLE
          Ulli Hafner :
          Files :

          • pom.xml
          • src/main/java/hudson/plugins/warnings/WarningsResult.java
          Show
          dogfood dogfood added a comment - Integrated in plugins_warnings #404 [FIXED JENKINS-13656] Use warnings history when restoring an instance of (Revision 7db20dda08df20c7ba829a4c1b0f3d462e307140) Result = UNSTABLE Ulli Hafner : Files : pom.xml src/main/java/hudson/plugins/warnings/WarningsResult.java
          Hide
          drulli Ulli Hafner added a comment -

          Integrated in Jenkins Analysis Plug-ins (Compile) #492
          [FIXED JENKINS-13656] Make build history creation overridable. (Revision 6a01bb768e88b9697652e8e006cb39d00967ebfc)

          Result = SUCCESS

          Show
          drulli Ulli Hafner added a comment - Integrated in Jenkins Analysis Plug-ins (Compile) #492 [FIXED JENKINS-13656] Make build history creation overridable. (Revision 6a01bb768e88b9697652e8e006cb39d00967ebfc) Result = SUCCESS
          rtyler R. Tyler Croy made changes -
          Workflow JNJira [ 144123 ] JNJira + In-Review [ 190919 ]

            People

            • Assignee:
              drulli Ulli Hafner
              Reporter:
              darkv Johann Werner
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: