Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-14144

Build config history getting spammed

    XMLWordPrintable

    Details

    • Similar Issues:

      Attachments

      1. config.xml
        2 kB
      2. envInject.xml
        0.3 kB
      3. jobConfigHistory.xml
        0.4 kB
      4. plugins.xml
        6 kB
      5. test-job.tar.gz
        4 kB

        Issue Links

          Activity

          Hide
          ndeloof Nicolas De Loof added a comment -

          Proposal for a partial workaround : https://github.com/jenkinsci/envinject-plugin/pull/17

          Seems current design (to add/remove a technical buildwrapper) introduce a possible race condition :
          with concurrent builds enabled, build 1 may remove buildWrapper after build 2 added one, but before it actually was used to set build 2 environment.

          Show
          ndeloof Nicolas De Loof added a comment - Proposal for a partial workaround : https://github.com/jenkinsci/envinject-plugin/pull/17 Seems current design (to add/remove a technical buildwrapper) introduce a possible race condition : with concurrent builds enabled, build 1 may remove buildWrapper after build 2 added one, but before it actually was used to set build 2 environment.
          Hide
          jglick Jesse Glick added a comment -

          #18 now.

          Show
          jglick Jesse Glick added a comment - #18 now.
          Hide
          ndeloof Nicolas De Loof added a comment -

          indeed, proposed https://github.com/jenkinsci/envinject-plugin/pull/18 as a real fix. #17 was only a quick and dirty workaroud

          Show
          ndeloof Nicolas De Loof added a comment - indeed, proposed https://github.com/jenkinsci/envinject-plugin/pull/18 as a real fix. #17 was only a quick and dirty workaroud
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Nicolas De Loof
          Path:
          pom.xml
          src/main/java/org/jenkinsci/plugins/envinject/EnvInjectListener.java
          src/main/java/org/jenkinsci/plugins/envinject/service/BuildWrapperService.java
          http://jenkins-ci.org/commit/envinject-plugin/a9be296cb4a2293b6123addacaeb629b8ba99ae1
          Log:
          JENKINS-14144 use a WorkspaceListener to avoid injecting a temporary BuildWrapper

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Nicolas De Loof Path: pom.xml src/main/java/org/jenkinsci/plugins/envinject/EnvInjectListener.java src/main/java/org/jenkinsci/plugins/envinject/service/BuildWrapperService.java http://jenkins-ci.org/commit/envinject-plugin/a9be296cb4a2293b6123addacaeb629b8ba99ae1 Log: JENKINS-14144 use a WorkspaceListener to avoid injecting a temporary BuildWrapper
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Gregory Boissinot
          Path:
          pom.xml
          src/main/java/org/jenkinsci/plugins/envinject/EnvInjectListener.java
          src/main/java/org/jenkinsci/plugins/envinject/service/BuildWrapperService.java
          http://jenkins-ci.org/commit/envinject-plugin/dd3834c83ecf6f0c3310ae492893bd63c46d927e
          Log:
          Merge pull request #18 from ndeloof/JENKINS-14144-alt

          [FIXED JENKINS-14144] use a WorkspaceListener to avoid injecting a temporary BuildWrapper

          Compare: https://github.com/jenkinsci/envinject-plugin/compare/96a526963b53...dd3834c83ecf

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Gregory Boissinot Path: pom.xml src/main/java/org/jenkinsci/plugins/envinject/EnvInjectListener.java src/main/java/org/jenkinsci/plugins/envinject/service/BuildWrapperService.java http://jenkins-ci.org/commit/envinject-plugin/dd3834c83ecf6f0c3310ae492893bd63c46d927e Log: Merge pull request #18 from ndeloof/ JENKINS-14144 -alt [FIXED JENKINS-14144] use a WorkspaceListener to avoid injecting a temporary BuildWrapper Compare: https://github.com/jenkinsci/envinject-plugin/compare/96a526963b53...dd3834c83ecf

            People

            • Assignee:
              gbois Gregory Boissinot
              Reporter:
              rprots Roman Prots'
            • Votes:
              5 Vote for this issue
              Watchers:
              13 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: