Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-14288

thinBackup doesn't put back the current shutdown flag after backing up

    Details

    • Type: Bug
    • Status: Resolved (View Workflow)
    • Priority: Major
    • Resolution: Fixed
    • Component/s: thinbackup-plugin
    • Labels:
      None
    • Environment:
      Windows 7. Jenkins v1.472. ThinBackup v1.6
    • Similar Issues:

      Description

      Hi there,

      It appears that once thinBackup has run, Jenkins is always taken out of shutdown mode even if it was in shutdown before thinBackup ran.

      Consider this:

      1) Jenkins is in shutdown mode.
      2) thinBackup runs.
      3) Jenkins is no longer in shutdown.

      This is a bug and the plugin should be updated to put back the shutdown flag setting after backing up.

      Regards,
      Tom.

        Attachments

          Activity

          Hide
          tfields Thomas Fields added a comment -

          That's correct.

          Show
          tfields Thomas Fields added a comment - That's correct.
          Hide
          tofuatjava Thomas Fürer added a comment -

          In reply to comment #5:
          > That's correct.

          sorry for the delay. I was simply confused, but it was a simple fix. I just committed a change. I will also try to push a new release but I need to do some testing before. so please hold on.

          thomas

          Show
          tofuatjava Thomas Fürer added a comment - In reply to comment #5: > That's correct. sorry for the delay. I was simply confused, but it was a simple fix. I just committed a change. I will also try to push a new release but I need to do some testing before. so please hold on. thomas
          Hide
          tofuatjava Thomas Fürer added a comment -

          Integrated in thinBackup #47
          JENKINS-14288: thinBackup doesn't put back the current shutdown flag after backing up (Revision 40678)

          Result = FAILURE
          tofuatjava : 40678
          Files :

          • /trunk/hudson/plugins/thinBackup/src/main/java/org/jvnet/hudson/plugins/thinbackup/ThinBackupPeriodicWork.java
          • /trunk/hudson/plugins/thinBackup/src/main/java/org/jvnet/hudson/plugins/thinbackup/utils/Utils.java
          Show
          tofuatjava Thomas Fürer added a comment - Integrated in thinBackup #47 JENKINS-14288 : thinBackup doesn't put back the current shutdown flag after backing up (Revision 40678) Result = FAILURE tofuatjava : 40678 Files : /trunk/hudson/plugins/thinBackup/src/main/java/org/jvnet/hudson/plugins/thinbackup/ThinBackupPeriodicWork.java /trunk/hudson/plugins/thinBackup/src/main/java/org/jvnet/hudson/plugins/thinbackup/utils/Utils.java
          Hide
          tofuatjava Thomas Fürer added a comment -

          Integrated in thinBackup #50
          JENKINS-14288: thinBackup doesn't put back the current shutdown flag after backing up (Revision 40678)

          Result = FAILURE
          tofuatjava : 40678
          Files :

          • /trunk/hudson/plugins/thinBackup/src/main/java/org/jvnet/hudson/plugins/thinbackup/ThinBackupPeriodicWork.java
          • /trunk/hudson/plugins/thinBackup/src/main/java/org/jvnet/hudson/plugins/thinbackup/utils/Utils.java
          Show
          tofuatjava Thomas Fürer added a comment - Integrated in thinBackup #50 JENKINS-14288 : thinBackup doesn't put back the current shutdown flag after backing up (Revision 40678) Result = FAILURE tofuatjava : 40678 Files : /trunk/hudson/plugins/thinBackup/src/main/java/org/jvnet/hudson/plugins/thinbackup/ThinBackupPeriodicWork.java /trunk/hudson/plugins/thinBackup/src/main/java/org/jvnet/hudson/plugins/thinbackup/utils/Utils.java
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: tofuatgit
          Path:
          src/main/java/org/jvnet/hudson/plugins/thinbackup/ThinBackupPeriodicWork.java
          src/main/java/org/jvnet/hudson/plugins/thinbackup/utils/Utils.java
          http://jenkins-ci.org/commit/thin-backup-plugin/e125d9972cb8ab326c52e1b759e456f35849fa1a
          Log:
          JENKINS-14288: thinBackup doesn't put back the current shutdown flag after backing up

          git-svn-id: https://svn.jenkins-ci.org/trunk/hudson/plugins/thinBackup@40678 71c3de6d-444a-0410-be80-ed276b4c234a

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: tofuatgit Path: src/main/java/org/jvnet/hudson/plugins/thinbackup/ThinBackupPeriodicWork.java src/main/java/org/jvnet/hudson/plugins/thinbackup/utils/Utils.java http://jenkins-ci.org/commit/thin-backup-plugin/e125d9972cb8ab326c52e1b759e456f35849fa1a Log: JENKINS-14288 : thinBackup doesn't put back the current shutdown flag after backing up git-svn-id: https://svn.jenkins-ci.org/trunk/hudson/plugins/thinBackup@40678 71c3de6d-444a-0410-be80-ed276b4c234a

            People

            • Assignee:
              tofuatjava Thomas Fürer
              Reporter:
              tfields Thomas Fields
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: