Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-14481

Quickly identify only the new errors

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Closed (View Workflow)
    • Priority: Minor
    • Resolution: Fixed
    • Component/s: cppcheck-plugin
    • Labels:
      None
    • Environment:
      All
    • Similar Issues:

      Description

      I know the build page details which cppcheck category had new errors. I am asking for a change not related to this build page, but to the cppheck result page.

      It would be tremendously helpful if the Details table had a new column which could specifically identify the new errors for that build.

      Our use case now is that an email goes out to a developer if they introduce new cppcheck errors. They are directed to the Cppcheck Result page. Yes it shows the total number of new errors, but that isn't helpful to the developer if there were a handful or many previous errors not yet fixed. It is hard for them to know which errors they are responsible for. Adding a new column to the table would quickly show them the newly introduced errors that they are responsible to fix.

      Another way to handle it would be to add a link to the Errors Trend table under the number of new errors. The link could take you to a table of only the new errors.

        Attachments

          Activity

          Hide
          jk Jan Klass added a comment -

          I don’t think an additional column is the way to go.
          Instead, as you suggested, a separate table should be used to show new errors (and another to show fixed errors).
          The overview integer indicating how many new errors there are should then link to that table/a separate result page with that table.

          Show
          jk Jan Klass added a comment - I don’t think an additional column is the way to go. Instead, as you suggested, a separate table should be used to show new errors (and another to show fixed errors). The overview integer indicating how many new errors there are should then link to that table/a separate result page with that table.
          Hide
          mixalturek Michal Turek added a comment -

          I'm thinking about a similar approach used in TODOs Plugin. There is a screenshot of the Results table on that page. What do you think?

          Show
          mixalturek Michal Turek added a comment - I'm thinking about a similar approach used in TODOs Plugin . There is a screenshot of the Results table on that page. What do you think?
          Hide
          jk Jan Klass added a comment -

          Approach concerning GUI? Sure, the colored table looks perfectly fine. Thank you for taking this task!

          Show
          jk Jan Klass added a comment - Approach concerning GUI? Sure, the colored table looks perfectly fine. Thank you for taking this task!
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Michal Turek
          Path:
          src/main/java/com/thalesgroup/hudson/plugins/cppcheck/model/CppcheckFile.java
          src/main/java/com/thalesgroup/hudson/plugins/cppcheck/model/CppcheckSourceContainer.java
          src/main/java/com/thalesgroup/hudson/plugins/cppcheck/model/CppcheckWorkspaceFile.java
          src/main/java/org/jenkinsci/plugins/cppcheck/CppcheckDiffState.java
          src/main/java/org/jenkinsci/plugins/cppcheck/CppcheckResult.java
          src/main/resources/org/jenkinsci/plugins/cppcheck/CppcheckResult/details.jelly
          src/main/resources/org/jenkinsci/plugins/cppcheck/Messages.properties
          http://jenkins-ci.org/commit/cppcheck-plugin/0ee027cfefc81c14217215665c508a1bbf536871
          Log:
          JENKINS-14481 Quickly identify only the new errors

          • A new column added to the report details table. It can contain "new", "solved" or "unchanged" flags to distinguish state of comparison with the previous report (if any). The column is mainly defined for an ability of sorting.
          • "New" issues are additionally highlighted with red background, "solved" issues are green and "unchanged" has white color as usual.
          • Solved issues also don't have the links to the source code, because it isn't available (issue was solved and the code is no longer present).
          • New CppcheckDiffState enum/flag added and stored as transient in CppcheckWorkspaceFile class. It is a dynamic parameter that should not be saved to any XML file.
          • The real comparison is done in CppcheckDiffState.diffCurrentAndPrevious().
          • If source file is not available, no line will be displayed in the report (zero was present before).
          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Michal Turek Path: src/main/java/com/thalesgroup/hudson/plugins/cppcheck/model/CppcheckFile.java src/main/java/com/thalesgroup/hudson/plugins/cppcheck/model/CppcheckSourceContainer.java src/main/java/com/thalesgroup/hudson/plugins/cppcheck/model/CppcheckWorkspaceFile.java src/main/java/org/jenkinsci/plugins/cppcheck/CppcheckDiffState.java src/main/java/org/jenkinsci/plugins/cppcheck/CppcheckResult.java src/main/resources/org/jenkinsci/plugins/cppcheck/CppcheckResult/details.jelly src/main/resources/org/jenkinsci/plugins/cppcheck/Messages.properties http://jenkins-ci.org/commit/cppcheck-plugin/0ee027cfefc81c14217215665c508a1bbf536871 Log: JENKINS-14481 Quickly identify only the new errors A new column added to the report details table. It can contain "new", "solved" or "unchanged" flags to distinguish state of comparison with the previous report (if any). The column is mainly defined for an ability of sorting. "New" issues are additionally highlighted with red background, "solved" issues are green and "unchanged" has white color as usual. Solved issues also don't have the links to the source code, because it isn't available (issue was solved and the code is no longer present). New CppcheckDiffState enum/flag added and stored as transient in CppcheckWorkspaceFile class. It is a dynamic parameter that should not be saved to any XML file. The real comparison is done in CppcheckDiffState.diffCurrentAndPrevious(). If source file is not available, no line will be displayed in the report (zero was present before).
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Michal Turek
          Path:
          src/main/java/com/thalesgroup/hudson/plugins/cppcheck/model/CppcheckFile.java
          src/main/java/com/thalesgroup/hudson/plugins/cppcheck/model/CppcheckSourceContainer.java
          src/main/java/com/thalesgroup/hudson/plugins/cppcheck/model/CppcheckWorkspaceFile.java
          src/main/java/org/jenkinsci/plugins/cppcheck/CppcheckDiffState.java
          src/main/java/org/jenkinsci/plugins/cppcheck/CppcheckResult.java
          src/main/resources/org/jenkinsci/plugins/cppcheck/CppcheckResult/details.jelly
          src/main/resources/org/jenkinsci/plugins/cppcheck/Messages.properties
          http://jenkins-ci.org/commit/cppcheck-plugin/ce2c74bd41c802efab3ca089290295d8876ef36d
          Log:
          Merge pull request #6 from mixalturek/master

          JENKINS-14481 Quickly identify only the new errors

          Compare: https://github.com/jenkinsci/cppcheck-plugin/compare/7f9f96c7cb29...ce2c74bd41c8

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Michal Turek Path: src/main/java/com/thalesgroup/hudson/plugins/cppcheck/model/CppcheckFile.java src/main/java/com/thalesgroup/hudson/plugins/cppcheck/model/CppcheckSourceContainer.java src/main/java/com/thalesgroup/hudson/plugins/cppcheck/model/CppcheckWorkspaceFile.java src/main/java/org/jenkinsci/plugins/cppcheck/CppcheckDiffState.java src/main/java/org/jenkinsci/plugins/cppcheck/CppcheckResult.java src/main/resources/org/jenkinsci/plugins/cppcheck/CppcheckResult/details.jelly src/main/resources/org/jenkinsci/plugins/cppcheck/Messages.properties http://jenkins-ci.org/commit/cppcheck-plugin/ce2c74bd41c802efab3ca089290295d8876ef36d Log: Merge pull request #6 from mixalturek/master JENKINS-14481 Quickly identify only the new errors Compare: https://github.com/jenkinsci/cppcheck-plugin/compare/7f9f96c7cb29...ce2c74bd41c8
          Hide
          mixalturek Michal Turek added a comment -

          Implemented, will be released in version 1.15.

          Show
          mixalturek Michal Turek added a comment - Implemented, will be released in version 1.15.

            People

            • Assignee:
              mixalturek Michal Turek
              Reporter:
              robs RobS
            • Votes:
              3 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: