Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-1489

JIRA plugin - security level for comment

    Details

    • Type: New Feature
    • Status: Resolved (View Workflow)
    • Priority: Major
    • Resolution: Fixed
    • Component/s: jira-plugin
    • Labels:
      None
    • Environment:
      Platform: All, OS: Linux
    • Similar Issues:

      Description

      Hi all!

      This should be a pretty simple addition to the jira plugin. Our JIRA install has
      issue security levels installed, we have an internal security level for comments
      about the implementation we don't want our clients to see.

      The build integration comment would definitely fall under that category.

      I'm happy to help with the implementation

        Attachments

          Issue Links

            Activity

            Hide
            kohsuke Kohsuke Kawaguchi added a comment -

            I'm not a JIRA expert, so I don't know what "issue security level" means, but
            you are certainly more than welcome to submit a patch!

            Show
            kohsuke Kohsuke Kawaguchi added a comment - I'm not a JIRA expert, so I don't know what "issue security level" means, but you are certainly more than welcome to submit a patch!
            Hide
            lukematthews lukematthews added a comment -

            Created an attachment (id=227)
            Screenshot of adding security to a comment

            Show
            lukematthews lukematthews added a comment - Created an attachment (id=227) Screenshot of adding security to a comment
            Hide
            lukematthews lukematthews added a comment -

            The combo box underneath the comments section is the field I'd like to be able
            to set. I'll do some more digging to get some more info.

            Show
            lukematthews lukematthews added a comment - The combo box underneath the comments section is the field I'd like to be able to set. I'll do some more digging to get some more info.
            Hide
            kohsuke Kohsuke Kawaguchi added a comment -

            Assigned the newly created 'jira' subcomponent.

            Show
            kohsuke Kohsuke Kawaguchi added a comment - Assigned the newly created 'jira' subcomponent.
            Hide
            riftware riftware added a comment -

            Any example on how to set that field programatically? Is it part of a standard
            JIRA install or is it a customization you have made to your specific install?
            I don't recall seeing it in our JIRA install but I'm not in charge of
            configuring JIRA

            Show
            riftware riftware added a comment - Any example on how to set that field programatically? Is it part of a standard JIRA install or is it a customization you have made to your specific install? I don't recall seeing it in our JIRA install but I'm not in charge of configuring JIRA
            Hide
            rodym rodym added a comment -

            I know the JIRA SOAP RPC API supports settings the security level of a comment to a group or a role. The current SOAP stubs that are included with the plugin do not support it, the saved wsdl-file seems to have some of the fields for a "RemoteComment" commented out.

            I could re-add these fields and update the plugin so one could set the visibility of the comment.

            Show
            rodym rodym added a comment - I know the JIRA SOAP RPC API supports settings the security level of a comment to a group or a role. The current SOAP stubs that are included with the plugin do not support it, the saved wsdl-file seems to have some of the fields for a "RemoteComment" commented out. I could re-add these fields and update the plugin so one could set the visibility of the comment.
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in hudson
            User: : rodym
            Path:
            trunk/hudson/plugins/jira/src/main/java/hudson/plugins/jira/JiraProjectProperty.java
            trunk/hudson/plugins/jira/src/main/java/hudson/plugins/jira/JiraSession.java
            trunk/hudson/plugins/jira/src/main/java/hudson/plugins/jira/JiraSite.java
            trunk/hudson/plugins/jira/src/main/java/hudson/plugins/jira/Updater.java
            trunk/hudson/plugins/jira/src/main/resources/hudson/plugins/jira/JiraProjectProperty/global.jelly
            trunk/hudson/plugins/jira/src/main/webapp/help-group-visibility.html
            trunk/hudson/plugins/jira/src/main/wsdl/jirasoapservice-v2.wsdl
            trunk/hudson/plugins/jira/src/test/java/hudson/plugins/jira/MockJiraSite.java
            trunk/hudson/plugins/jira/src/test/java/hudson/plugins/jira/UpdaterTest.java
            http://jenkins-ci.org/commit/33081
            Log:
            JENKINS-1489

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in hudson User: : rodym Path: trunk/hudson/plugins/jira/src/main/java/hudson/plugins/jira/JiraProjectProperty.java trunk/hudson/plugins/jira/src/main/java/hudson/plugins/jira/JiraSession.java trunk/hudson/plugins/jira/src/main/java/hudson/plugins/jira/JiraSite.java trunk/hudson/plugins/jira/src/main/java/hudson/plugins/jira/Updater.java trunk/hudson/plugins/jira/src/main/resources/hudson/plugins/jira/JiraProjectProperty/global.jelly trunk/hudson/plugins/jira/src/main/webapp/help-group-visibility.html trunk/hudson/plugins/jira/src/main/wsdl/jirasoapservice-v2.wsdl trunk/hudson/plugins/jira/src/test/java/hudson/plugins/jira/MockJiraSite.java trunk/hudson/plugins/jira/src/test/java/hudson/plugins/jira/UpdaterTest.java http://jenkins-ci.org/commit/33081 Log: JENKINS-1489
            Hide
            kreyssel Conny Kreyßel added a comment -

            I have submitted a patch to support project roles security levels for comments.

            Please check it to get it into main.

            https://github.com/kreyssel/jira-plugin/commit/b340a529f6fb056d0744cebff18e9c0b9464a7a2

            Show
            kreyssel Conny Kreyßel added a comment - I have submitted a patch to support project roles security levels for comments. Please check it to get it into main. https://github.com/kreyssel/jira-plugin/commit/b340a529f6fb056d0744cebff18e9c0b9464a7a2
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Conny Kreyssel
            Path:
            src/main/java/hudson/plugins/jira/JiraProjectProperty.java
            src/main/java/hudson/plugins/jira/JiraSession.java
            src/main/java/hudson/plugins/jira/JiraSite.java
            src/main/java/hudson/plugins/jira/Updater.java
            src/main/resources/hudson/plugins/jira/JiraProjectProperty/global.jelly
            src/main/webapp/help-role-visibility.html
            src/test/java/hudson/plugins/jira/MockJiraSite.java
            src/test/java/hudson/plugins/jira/UpdaterTest.java
            http://jenkins-ci.org/commit/jira-plugin/a022864fb2e5a1dbc6b183177440a3fb383d8d54
            Log:
            [FIXED JENKINS-1489] Fix for project roles

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Conny Kreyssel Path: src/main/java/hudson/plugins/jira/JiraProjectProperty.java src/main/java/hudson/plugins/jira/JiraSession.java src/main/java/hudson/plugins/jira/JiraSite.java src/main/java/hudson/plugins/jira/Updater.java src/main/resources/hudson/plugins/jira/JiraProjectProperty/global.jelly src/main/webapp/help-role-visibility.html src/test/java/hudson/plugins/jira/MockJiraSite.java src/test/java/hudson/plugins/jira/UpdaterTest.java http://jenkins-ci.org/commit/jira-plugin/a022864fb2e5a1dbc6b183177440a3fb383d8d54 Log: [FIXED JENKINS-1489] Fix for project roles
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Conny Kreyssel
            Path:
            src/main/java/hudson/plugins/jira/JiraProjectProperty.java
            src/main/java/hudson/plugins/jira/JiraSession.java
            src/main/java/hudson/plugins/jira/JiraSite.java
            src/main/java/hudson/plugins/jira/Updater.java
            src/main/resources/hudson/plugins/jira/JiraProjectProperty/global.jelly
            src/main/webapp/help-role-visibility.html
            src/test/java/hudson/plugins/jira/MockJiraSite.java
            src/test/java/hudson/plugins/jira/UpdaterTest.java
            http://jenkins-ci.org/commit/jira-plugin/b340a529f6fb056d0744cebff18e9c0b9464a7a2
            Log:
            Fix for project roles for JENKINS-1489

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Conny Kreyssel Path: src/main/java/hudson/plugins/jira/JiraProjectProperty.java src/main/java/hudson/plugins/jira/JiraSession.java src/main/java/hudson/plugins/jira/JiraSite.java src/main/java/hudson/plugins/jira/Updater.java src/main/resources/hudson/plugins/jira/JiraProjectProperty/global.jelly src/main/webapp/help-role-visibility.html src/test/java/hudson/plugins/jira/MockJiraSite.java src/test/java/hudson/plugins/jira/UpdaterTest.java http://jenkins-ci.org/commit/jira-plugin/b340a529f6fb056d0744cebff18e9c0b9464a7a2 Log: Fix for project roles for JENKINS-1489
            Hide
            gecon27 Ioannis Oikonomou added a comment -

            Hello,

            We get the following error when adding a JIRA group in Jenkins for comment visibility:

            Updating JIRA-1234
            Looks like JIRA-1234 is no valid JIRA issue or you don't have permission to update the issue.
            Issue will not be updated.
            com.atlassian.jira.rpc.exception.RemotePermissionException: You do not have permission to get a group.
            

            Is it necessary that the JIRA user configured on Jenkins has global admin rights?
            Why is the plugin calling getGroup() - which indeed most probably does require global admin rights, rather than just set directly the JIRA group on the comment object level?

            Thanks,
            Ioannis

            Show
            gecon27 Ioannis Oikonomou added a comment - Hello, We get the following error when adding a JIRA group in Jenkins for comment visibility: Updating JIRA-1234 Looks like JIRA-1234 is no valid JIRA issue or you don't have permission to update the issue. Issue will not be updated. com.atlassian.jira.rpc.exception.RemotePermissionException: You do not have permission to get a group. Is it necessary that the JIRA user configured on Jenkins has global admin rights? Why is the plugin calling getGroup() - which indeed most probably does require global admin rights, rather than just set directly the JIRA group on the comment object level? Thanks, Ioannis
            Hide
            briansw_bellsouth_net Brian Wilson added a comment -

            We are also seeing the same error message. The error message is vague and I don't think it points to the correct concern.

            The actual errors look like the following:
            12:12:16 Updating BRPRJ-2173
            12:12:16 Looks like BRPRJ-2173 is no valid JIRA issue or you don't have permission to update the issue.
            12:12:16 Issue will not be updated.
            12:12:16 com.atlassian.jira.rpc.exception.RemotePermissionException: You do not have permission to get a group.
            12:12:16 Updating BRPRJ-1535
            12:12:16 Looks like BRPRJ-1535 is no valid JIRA issue or you don't have permission to update the issue.
            12:12:16 Issue will not be updated.
            12:12:16 com.atlassian.jira.rpc.exception.RemotePermissionException: You do not have permission to get a group.
            12:12:16 Updating BRPRJ-1716
            12:12:17 Looks like BRPRJ-1716 is no valid JIRA issue or you don't have permission to update the issue.
            12:12:17 Issue will not be updated.
            12:12:17 com.atlassian.jira.rpc.exception.RemotePermissionException: You do not have permission to get a group.

            The JIRA Issues are valid and the group we are using is also a valid group. It appears that this plugin just doesn't work or requires some configuration that is not documented.

            We are using Jenkins 1.533, and JIRA 6.0.8 on linux servers. Jenkins is being run from Tomcat 6.0.29. Our Jenkins "JIRA Plugin" is version 1.38. The settings for the plugin are working (they validate), and I have confirmed our group does exist in JIRA.

            Show
            briansw_bellsouth_net Brian Wilson added a comment - We are also seeing the same error message. The error message is vague and I don't think it points to the correct concern. The actual errors look like the following: 12:12:16 Updating BRPRJ-2173 12:12:16 Looks like BRPRJ-2173 is no valid JIRA issue or you don't have permission to update the issue. 12:12:16 Issue will not be updated. 12:12:16 com.atlassian.jira.rpc.exception.RemotePermissionException: You do not have permission to get a group. 12:12:16 Updating BRPRJ-1535 12:12:16 Looks like BRPRJ-1535 is no valid JIRA issue or you don't have permission to update the issue. 12:12:16 Issue will not be updated. 12:12:16 com.atlassian.jira.rpc.exception.RemotePermissionException: You do not have permission to get a group. 12:12:16 Updating BRPRJ-1716 12:12:17 Looks like BRPRJ-1716 is no valid JIRA issue or you don't have permission to update the issue. 12:12:17 Issue will not be updated. 12:12:17 com.atlassian.jira.rpc.exception.RemotePermissionException: You do not have permission to get a group. The JIRA Issues are valid and the group we are using is also a valid group. It appears that this plugin just doesn't work or requires some configuration that is not documented. We are using Jenkins 1.533, and JIRA 6.0.8 on linux servers. Jenkins is being run from Tomcat 6.0.29. Our Jenkins "JIRA Plugin" is version 1.38. The settings for the plugin are working (they validate), and I have confirmed our group does exist in JIRA.
            Hide
            warden Radek Antoniuk added a comment -

            Anyone still getting this on plugin 2.x via REST API ?

            Show
            warden Radek Antoniuk added a comment - Anyone still getting this on plugin 2.x via REST API ?
            Hide
            warden Radek Antoniuk added a comment -

            Please create new bug report if this is still the case.

            Show
            warden Radek Antoniuk added a comment - Please create new bug report if this is still the case.

              People

              • Assignee:
                rodym rodym
                Reporter:
                lukematthews lukematthews
              • Votes:
                5 Vote for this issue
                Watchers:
                7 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: