Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-14900

Copying from workspace drops files matching Ant's default excludes

    Details

    • Similar Issues:

      Attachments

        Issue Links

          Activity

          Hide
          davehunt Dave Hunt added a comment -

          With Jenkins 1.455 the plugin was successfully copying a workspace that contained a Mercurial repository. It appears that since JENKINS-9118 was resolved and Ant was upgraded to 1.8.3 the default excludes now cover Mercurial's repository files, and therefore the files are not being copied. This is similar to JENKINS-13888 for the Clone Workspace plugin, and may similarly require a change to Jenkins core.

          Show
          davehunt Dave Hunt added a comment - With Jenkins 1.455 the plugin was successfully copying a workspace that contained a Mercurial repository. It appears that since JENKINS-9118 was resolved and Ant was upgraded to 1.8.3 the default excludes now cover Mercurial's repository files, and therefore the files are not being copied. This is similar to JENKINS-13888 for the Clone Workspace plugin, and may similarly require a change to Jenkins core.
          Hide
          davehunt Dave Hunt added a comment -

          Pull request with failing test that demonstrates this issue is here: https://github.com/jenkinsci/copyartifact-plugin/pull/12

          This is preventing us from upgrading Jenkins past version 1.455 (March 2012)

          Show
          davehunt Dave Hunt added a comment - Pull request with failing test that demonstrates this issue is here: https://github.com/jenkinsci/copyartifact-plugin/pull/12 This is preventing us from upgrading Jenkins past version 1.455 (March 2012)
          Hide
          mindless Alan Harder added a comment -

          sorry, haven't worked on jenkins in a couple years

          Show
          mindless Alan Harder added a comment - sorry, haven't worked on jenkins in a couple years
          Hide
          davehunt Dave Hunt added a comment -

          Apologies if this is the wrong person to assign to - I was going by recent commits to this plugin.

          Show
          davehunt Dave Hunt added a comment - Apologies if this is the wrong person to assign to - I was going by recent commits to this plugin.
          Hide
          jglick Jesse Glick added a comment -

          I did fix one bug in the plugin, but I do not consider myself a maintainer of it.

          Show
          jglick Jesse Glick added a comment - I did fix one bug in the plugin, but I do not consider myself a maintainer of it.
          Hide
          davehunt Dave Hunt added a comment -

          Another attempt at assigning based on commit history. Hoping to find someone that can fix this or at least mentor me to fix it.

          Show
          davehunt Dave Hunt added a comment - Another attempt at assigning based on commit history. Hoping to find someone that can fix this or at least mentor me to fix it.
          Hide
          fredg Fred G added a comment -

          Same here, sorry. I fixed a few bugs, but I'm not the maintainer.

          I'll try to have a look at it, but can't promise anything.
          Your best bet is trying to fix it yourself.

          Show
          fredg Fred G added a comment - Same here, sorry. I fixed a few bugs, but I'm not the maintainer. I'll try to have a look at it, but can't promise anything. Your best bet is trying to fix it yourself.
          Hide
          davehunt Dave Hunt added a comment -

          I was afraid you'd say that Fred! I would appreciate you looking at this and giving me any pointers. I have already attempted to fix it myself, but so far had little success.

          Show
          davehunt Dave Hunt added a comment - I was afraid you'd say that Fred! I would appreciate you looking at this and giving me any pointers. I have already attempted to fix it myself, but so far had little success.
          Hide
          ikedam ikedam added a comment -

          https://github.com/jenkinsci/copyartifact-plugin/pull/42

          Fix for this issue should be introduced with fix for JENKINS-18662.

          Show
          ikedam ikedam added a comment - https://github.com/jenkinsci/copyartifact-plugin/pull/42 Fix for this issue should be introduced with fix for JENKINS-18662 .
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Dave Hunt
          Path:
          pom.xml
          src/test/java/hudson/plugins/copyartifact/CopyArtifactTest.java
          http://jenkins-ci.org/commit/copyartifact-plugin/ecfa6f42aaf6c1bc40db7cd93703c733d152fed7
          Log:
          Failing test for JENKINS-14900.

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Dave Hunt Path: pom.xml src/test/java/hudson/plugins/copyartifact/CopyArtifactTest.java http://jenkins-ci.org/commit/copyartifact-plugin/ecfa6f42aaf6c1bc40db7cd93703c733d152fed7 Log: Failing test for JENKINS-14900 .
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: ikedam
          Path:
          src/test/java/hudson/plugins/copyartifact/CopyArtifactTest.java
          http://jenkins-ci.org/commit/copyartifact-plugin/c04a128b5e0642b9519c8949024439d146750ad9
          Log:
          Merge pull request #12 from davehunt/JENKINS-14900-TEST

          Failing test for JENKINS-14900.

          Conflicts:
          pom.xml

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: ikedam Path: src/test/java/hudson/plugins/copyartifact/CopyArtifactTest.java http://jenkins-ci.org/commit/copyartifact-plugin/c04a128b5e0642b9519c8949024439d146750ad9 Log: Merge pull request #12 from davehunt/ JENKINS-14900 -TEST Failing test for JENKINS-14900 . Conflicts: pom.xml
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: ikedam
          Path:
          src/test/java/hudson/plugins/copyartifact/CopyArtifactTest.java
          http://jenkins-ci.org/commit/copyartifact-plugin/1f7f665a1840c56c622cd7533726a41532cdd5b1
          Log:
          JENKINS-14900 Added a test to reproduce JENKINS-14900 when flatten=true.

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: ikedam Path: src/test/java/hudson/plugins/copyartifact/CopyArtifactTest.java http://jenkins-ci.org/commit/copyartifact-plugin/1f7f665a1840c56c622cd7533726a41532cdd5b1 Log: JENKINS-14900 Added a test to reproduce JENKINS-14900 when flatten=true.
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: ikedam
          Path:
          src/main/java/hudson/plugins/copyartifact/CopyArtifact.java
          src/main/java/hudson/plugins/copyartifact/FingerprintingCopyMethod.java
          http://jenkins-ci.org/commit/copyartifact-plugin/609ca2e0e09db223961ae5faae74bb06e85eb4a0
          Log:
          [FIXED JENKINS-14900] Disabled ant default excludes.

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: ikedam Path: src/main/java/hudson/plugins/copyartifact/CopyArtifact.java src/main/java/hudson/plugins/copyartifact/FingerprintingCopyMethod.java http://jenkins-ci.org/commit/copyartifact-plugin/609ca2e0e09db223961ae5faae74bb06e85eb4a0 Log: [FIXED JENKINS-14900] Disabled ant default excludes.
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: ikedam
          Path:
          src/main/java/hudson/plugins/copyartifact/Copier.java
          src/main/java/hudson/plugins/copyartifact/CopyArtifact.java
          src/main/java/hudson/plugins/copyartifact/FilePathCopyMethod.java
          src/main/java/hudson/plugins/copyartifact/FingerprintingCopyMethod.java
          src/main/resources/hudson/plugins/copyartifact/CopyArtifact/config.jelly
          src/main/resources/hudson/plugins/copyartifact/CopyArtifact/config_ja.properties
          src/main/resources/hudson/plugins/copyartifact/CopyArtifact/help-excludes.html
          src/main/resources/hudson/plugins/copyartifact/CopyArtifact/help-excludes_ja.html
          src/main/resources/hudson/plugins/copyartifact/CopyArtifact/help-filter.html
          src/main/resources/hudson/plugins/copyartifact/CopyArtifact/help-filter_de.html
          src/main/resources/hudson/plugins/copyartifact/CopyArtifact/help-filter_ja.html
          src/test/java/hudson/plugins/copyartifact/CopyArtifactTest.java
          http://jenkins-ci.org/commit/copyartifact-plugin/13282b4c62a11477ad6451030bd692560e858304
          Log:
          Merge pull request #42 from ikedam/feature/JENKINS-14900_Excludes

          JENKINS-14900 JENKINS-18662 JENKINS-23444 Fixes for filter.

          Compare: https://github.com/jenkinsci/copyartifact-plugin/compare/e894206e94ca...13282b4c62a1

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: ikedam Path: src/main/java/hudson/plugins/copyartifact/Copier.java src/main/java/hudson/plugins/copyartifact/CopyArtifact.java src/main/java/hudson/plugins/copyartifact/FilePathCopyMethod.java src/main/java/hudson/plugins/copyartifact/FingerprintingCopyMethod.java src/main/resources/hudson/plugins/copyartifact/CopyArtifact/config.jelly src/main/resources/hudson/plugins/copyartifact/CopyArtifact/config_ja.properties src/main/resources/hudson/plugins/copyartifact/CopyArtifact/help-excludes.html src/main/resources/hudson/plugins/copyartifact/CopyArtifact/help-excludes_ja.html src/main/resources/hudson/plugins/copyartifact/CopyArtifact/help-filter.html src/main/resources/hudson/plugins/copyartifact/CopyArtifact/help-filter_de.html src/main/resources/hudson/plugins/copyartifact/CopyArtifact/help-filter_ja.html src/test/java/hudson/plugins/copyartifact/CopyArtifactTest.java http://jenkins-ci.org/commit/copyartifact-plugin/13282b4c62a11477ad6451030bd692560e858304 Log: Merge pull request #42 from ikedam/feature/ JENKINS-14900 _Excludes JENKINS-14900 JENKINS-18662 JENKINS-23444 Fixes for filter. Compare: https://github.com/jenkinsci/copyartifact-plugin/compare/e894206e94ca...13282b4c62a1
          Hide
          ikedam ikedam added a comment -

          Released the fix in copyartifact 1.31.

          Show
          ikedam ikedam added a comment - Released the fix in copyartifact 1.31.

            People

            • Assignee:
              davehunt Dave Hunt
              Reporter:
              davehunt Dave Hunt
            • Votes:
              1 Vote for this issue
              Watchers:
              7 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: