Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-15806

Exit code of `hg pull` not checked

    XMLWordPrintable

    Details

    • Similar Issues:

      Description

      See pull request @ https://github.com/jenkinsci/mercurial-plugin/pull/31

      Currently it appears that the Mercurial plugin doesn't check the exit code of the hg pull used to update the repository (see hudson.plugins.mercurial.MercurialSCM#update() - https://github.com/jenkinsci/mercurial-plugin/blob/master/src/main/java/hudson/plugins/mercurial/MercurialSCM.java#L496)

      So, if the upstream repo has gone away for some reason (say, hypothetically, I've rm-ed it), the hg pull will fail and exit with a status code of 255, but the build will continue regardless

        Attachments

          Issue Links

            Activity

            doismellburning Kristian Glass created issue -
            sioux Rene Kroon made changes -
            Field Original Value New Value
            Status Open [ 1 ] In Progress [ 3 ]
            sioux Rene Kroon made changes -
            Description Currently it appears that the Mercurial plugin doesn't check the exit code of the {{hg pull}} used to update the repository (see {{hudson.plugins.mercurial.MercurialSCM#update()}} - https://github.com/jenkinsci/mercurial-plugin/blob/master/src/main/java/hudson/plugins/mercurial/MercurialSCM.java#L496)

            So, if the upstream repo has gone away for some reason (say, hypothetically, I've rm-ed it), the {{hg pull}} will fail and exit with a status code of 255, but the build will continue regardless
            See pull request @ https://github.com/jenkinsci/mercurial-plugin/pull/31


            Currently it appears that the Mercurial plugin doesn't check the exit code of the {{hg pull}} used to update the repository (see {{hudson.plugins.mercurial.MercurialSCM#update()}} - https://github.com/jenkinsci/mercurial-plugin/blob/master/src/main/java/hudson/plugins/mercurial/MercurialSCM.java#L496)

            So, if the upstream repo has gone away for some reason (say, hypothetically, I've rm-ed it), the {{hg pull}} will fail and exit with a status code of 255, but the build will continue regardless
            sioux Rene Kroon made changes -
            Assignee Jesse Glick [ jglick ] Rene Kroon [ sioux ]
            scm_issue_link SCM/JIRA link daemon made changes -
            Status In Progress [ 3 ] Resolved [ 5 ]
            Resolution Fixed [ 1 ]
            jglick Jesse Glick made changes -
            Link This issue is duplicated by JENKINS-22092 [ JENKINS-22092 ]
            anjohnson Andrew Johnson made changes -
            Resolution Fixed [ 1 ]
            Status Resolved [ 5 ] Reopened [ 4 ]
            Assignee Rene Kroon [ sioux ] Jesse Glick [ jglick ]
            jglick Jesse Glick made changes -
            Status Reopened [ 4 ] Resolved [ 5 ]
            Resolution Fixed [ 1 ]
            rtyler R. Tyler Croy made changes -
            Workflow JNJira [ 146607 ] JNJira + In-Review [ 192001 ]

              People

              • Assignee:
                jglick Jesse Glick
                Reporter:
                doismellburning Kristian Glass
              • Votes:
                5 Vote for this issue
                Watchers:
                9 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: