Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-15826

CVS plugin excluded regions no longer match on the file path

    Details

    • Type: Bug
    • Status: Resolved (View Workflow)
    • Priority: Major
    • Resolution: Fixed
    • Component/s: cvs-plugin
    • Labels:
      None
    • Similar Issues:

      Description

      After upgrading from version 1.6 of the CVS plugin to 2.6 (and then to 2.7), our "excludes regions" have stopped working. That's because we have a pattern like

      [^/]*\.ext
      

      to prevent changes to .ext files in the root directory of the checkout from triggering builds, and we have patterns like

      directoryToExclude/.*
      

      to prevent any file in directoryToExclude from triggering a build. But we do expect a build to be triggered by changes to a .ext file that is in a directory that is not excluded. That was true of version 1.6, but not after upgrading to 2.6.

      Not that you don't already know this, but looking at the source code for version 2.6 of the CVS plugin, it looks like the CvsFile is constructed (in CvsLog) using only file.getSimpleName() and not file.getFullName() which means that the loop over excludePatterns in AbstractCvs is not taking the full path into account. (However, I wouldn't know what negative side effects there would be, if any, to making the single change.)

        Attachments

          Activity

            People

            • Assignee:
              mc1arke Michael Clarke
              Reporter:
              jeremy Jeremy Michelson
            • Votes:
              2 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: