Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-16075

Lint icon not shown when selecting a particular build

    XMLWordPrintable

    Details

    • Similar Issues:

      Description

      The lint icon is shown in the left pane of the browser. But when selecting a particular build, the main window does not show the icon but a 'broken image'.

        Attachments

          Activity

          designentropy Joris van der Pol created issue -
          Hide
          designentropy Joris van der Pol added a comment -

          Seems android-48x48.png is missing

          Show
          designentropy Joris van der Pol added a comment - Seems android-48x48.png is missing
          Hide
          orrc Christopher Orr added a comment -

          This should have been fixed in plugin version 2.6 (I think).
          Which version of the plugin are you using and which version of Jenkins?

          Can you please paste the link to the android-48x48.png which fails to load?

          Show
          orrc Christopher Orr added a comment - This should have been fixed in plugin version 2.6 (I think). Which version of the plugin are you using and which version of Jenkins? Can you please paste the link to the android-48x48.png which fails to load?
          Hide
          designentropy Joris van der Pol added a comment -
          Show
          designentropy Joris van der Pol added a comment - Link for the 48x48 icon: http://xps:8080/static/944d390a/static/944d390a/plugin/android-lint/icons/android-48x48.png Link for the 24x24 icon: http://xps:8080/static/944d390a/plugin/android-lint/icons/android-24x24.png Jenkins version 1.492 Android Lint Plugin version: 2.0.1
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Christopher Orr
          Path:
          src/main/resources/org/jenkinsci/plugins/android_lint/LintMavenResultAction/summary.jelly
          src/main/resources/org/jenkinsci/plugins/android_lint/LintResultAction/summary.jelly
          http://jenkins-ci.org/commit/android-lint-plugin/71f1a1e72a4324711db23af8d867c7d5832f7c0a
          Log:
          [FIXED JENKINS-16075] Remove now-redundant resURL from summary jelly files.

          Apparently Jenkins now inserts the 'static' URL itself, so this isn't needed.

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Christopher Orr Path: src/main/resources/org/jenkinsci/plugins/android_lint/LintMavenResultAction/summary.jelly src/main/resources/org/jenkinsci/plugins/android_lint/LintResultAction/summary.jelly http://jenkins-ci.org/commit/android-lint-plugin/71f1a1e72a4324711db23af8d867c7d5832f7c0a Log: [FIXED JENKINS-16075] Remove now-redundant resURL from summary jelly files. Apparently Jenkins now inserts the 'static' URL itself, so this isn't needed.
          scm_issue_link SCM/JIRA link daemon made changes -
          Field Original Value New Value
          Status Open [ 1 ] Resolved [ 5 ]
          Resolution Fixed [ 1 ]
          Hide
          orrc Christopher Orr added a comment -

          Version 2.0.2 of the plugin has now been released, which fixes this issue.

          Show
          orrc Christopher Orr added a comment - Version 2.0.2 of the plugin has now been released, which fixes this issue.
          orrc Christopher Orr made changes -
          Status Resolved [ 5 ] Closed [ 6 ]
          Hide
          mwigzell Mark Wigzell added a comment -

          Installed 1.505 Jenkins with 2.0.3 of Android Lint plugin, lint icon still broken.

          Reason is that the root of the icon path is doubled in the actual HTML for the respective pages in Jenkins build display.

          Show
          mwigzell Mark Wigzell added a comment - Installed 1.505 Jenkins with 2.0.3 of Android Lint plugin, lint icon still broken. Reason is that the root of the icon path is doubled in the actual HTML for the respective pages in Jenkins build display.
          mwigzell Mark Wigzell made changes -
          Resolution Fixed [ 1 ]
          Status Closed [ 6 ] Reopened [ 4 ]
          Hide
          orrc Christopher Orr added a comment -

          Hi Mark,

          I'll take a look. Could you please paste the URL of the image which fails to load?

          Show
          orrc Christopher Orr added a comment - Hi Mark, I'll take a look. Could you please paste the URL of the image which fails to load?
          Hide
          mwigzell Mark Wigzell added a comment -

          <a href="/job/Entune.Android/androidLint"><img height="24" style="margin: 2px;" alt="" width="24" src="/static/06707550//static/06707550/plugin/android-lint/icons/android-24x24.png" /></a> <a href="/job/Entune.Android/androidLint">Lint Issues</a></div><div class="task">

          You can see that the ref to /static/06707550 is doubled.

          Show
          mwigzell Mark Wigzell added a comment - <a href="/job/Entune.Android/androidLint"><img height="24" style="margin: 2px;" alt="" width="24" src="/static/06707550//static/06707550/plugin/android-lint/icons/android-24x24.png" /></a> <a href="/job/Entune.Android/androidLint">Lint Issues</a></div><div class="task"> You can see that the ref to /static/06707550 is doubled.
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Christopher Orr
          Path:
          src/main/java/org/jenkinsci/plugins/android_lint/LintDescriptor.java
          http://jenkins-ci.org/commit/android-lint-plugin/7d90c1de9206daa9f3d13961687e4cf7e40b0ac9
          Log:
          [FIXED JENKINS-16075] Remove redundant resource path from icon URL.

          Apparently the fix for JENKINS-16530 now includes this automatically
          for all plugin images, regardless of whether the plugin was already
          doing the right thing and allowing caching.

          Compare: https://github.com/jenkinsci/android-lint-plugin/compare/8a56499d1ece...7d90c1de9206

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Christopher Orr Path: src/main/java/org/jenkinsci/plugins/android_lint/LintDescriptor.java http://jenkins-ci.org/commit/android-lint-plugin/7d90c1de9206daa9f3d13961687e4cf7e40b0ac9 Log: [FIXED JENKINS-16075] Remove redundant resource path from icon URL. Apparently the fix for JENKINS-16530 now includes this automatically for all plugin images, regardless of whether the plugin was already doing the right thing and allowing caching. Compare: https://github.com/jenkinsci/android-lint-plugin/compare/8a56499d1ece...7d90c1de9206
          Hide
          orrc Christopher Orr added a comment -

          Looks like it was broken due to a change in Jenkins 1.501.

          I'll release a new plugin version in the next day or two.

          Show
          orrc Christopher Orr added a comment - Looks like it was broken due to a change in Jenkins 1.501. I'll release a new plugin version in the next day or two.
          Hide
          orrc Christopher Orr added a comment -

          Marking this as fixed. I guess the bot doesn't like resolving "reopened" issues.

          Show
          orrc Christopher Orr added a comment - Marking this as fixed. I guess the bot doesn't like resolving "reopened" issues.
          orrc Christopher Orr made changes -
          Status Reopened [ 4 ] Resolved [ 5 ]
          Resolution Fixed [ 1 ]
          Hide
          orrc Christopher Orr added a comment -

          Version 2.1 has been released, which includes this fix.

          Show
          orrc Christopher Orr added a comment - Version 2.1 has been released, which includes this fix.
          orrc Christopher Orr made changes -
          Status Resolved [ 5 ] Closed [ 6 ]
          rtyler R. Tyler Croy made changes -
          Workflow JNJira [ 146878 ] JNJira + In-Review [ 206293 ]

            People

            • Assignee:
              orrc Christopher Orr
              Reporter:
              designentropy Joris van der Pol
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: