Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-16389

Emailing users at the end of a failed build very slow for big Jenkins instance using CVS

    Details

    • Similar Issues:

      Description

      Basically the same issue as JENKINS-15440, only for CVS.
      Description was mainly copied from there.

      At the end of a failing build, the hudson.tasks.MailSender.buildCulpritList determines who to email.
      The problem comes when hudson.scm.MailAddressResolverImpl.findMailAddressFor determines the email address of the user by finding all builds a user has committed to. This is done by iterating over every single Jenkins project (hudson.model.User.getProjects() first finds all projects and then uses AbstractProject.hasParticipant - which reads the changelog to see if the user participated).

      For a large system (we have tens of thousands of builds), this is not at all efficient.

      Unfortunately findMailAddressFor takes a user and not a project (as the obvious implementation would be to work out the email address from the commit).

      Also, the results aren't cached and so this is run for every user every time.

        Attachments

          Issue Links

            Activity

            Hide
            olivergondza Oliver Gondža added a comment -
            Show
            olivergondza Oliver Gondža added a comment - Removed in cvs-2.8 [1] . Resolver plugin available at [2] . [1] https://github.com/jenkinsci/cvs-plugin/pull/18 [2] https://github.com/jenkinsci/cvs-mail-address-resolver-plugin
            Hide
            kutzi kutzi added a comment - - edited

            See comments on https://github.com/jenkinsci/cvs-mail-address-resolver-plugin/commit/2a58adbefdfdbc73bcad033f3e53724478910f71

            I've generally the opinion that this code should be erased without leaving any traces

            Show
            kutzi kutzi added a comment - - edited See comments on https://github.com/jenkinsci/cvs-mail-address-resolver-plugin/commit/2a58adbefdfdbc73bcad033f3e53724478910f71 I've generally the opinion that this code should be erased without leaving any traces

              People

              • Assignee:
                olivergondza Oliver Gondža
                Reporter:
                kutzi kutzi
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: