Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-16645

Information/Informational - Severity - Android Lint Plugin

    XMLWordPrintable

    Details

    • Similar Issues:

      Description

      In the specification of lint is the Serverity of information given as
      the String "Information"
      (http://grepcode.com/file/repo1.maven.org/maven2/com.android.tools.lint/lint_api/r16/com/android/tools/lint/detector/api/Severity.java).
      Further more here is an result-example:
      <issue id="OldTargetApi" severity="Information" message="Not
      targetin..........">

      In the file: android-lint-plugin / src / main / java / org / jenkinsci
      / plugins / android_lint / parser / LintParser.java

      in your method:

      private Priority getPriority(String severity) {
      if (SEVERITY_FATAL.equals(severity) ||
      SEVERITY_ERROR.equals(severity))

      { return Priority.HIGH; }

      if (SEVERITY_INFORMATIONAL.equals(severity))

      { return Priority.LOW; }

      return Priority.NORMAL;
      }

      you check against the constant SEVERITY_INFORMATIONAL which is
      "Informational", this is wrong. As you can see in the specification
      the string itself should be "Information".

      The correct constant should be:
      /** Severity constant value from

      {@link com.android.tools.lint.detector.api.Severity}

      . */
      private static final String SEVERITY_INFORMATIONAL = "Information";

        Attachments

          Activity

          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Christopher Orr
          Path:
          src/main/java/org/jenkinsci/plugins/android_lint/parser/LintParser.java
          src/test/resources/org/jenkinsci/plugins/android_lint/parser/lint-results_r20.xml
          http://jenkins-ci.org/commit/android-lint-plugin/8263e067ab3df0f260e46bb467519b75074e85c1
          Log:
          [FIXED JENKINS-16645] Fix constant value for 'informational' severity.


          You received this message because you are subscribed to the Google Groups "Jenkins Commits" group.
          To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-commits+unsubscribe@googlegroups.com.
          For more options, visit https://groups.google.com/groups/opt_out.

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Christopher Orr Path: src/main/java/org/jenkinsci/plugins/android_lint/parser/LintParser.java src/test/resources/org/jenkinsci/plugins/android_lint/parser/lint-results_r20.xml http://jenkins-ci.org/commit/android-lint-plugin/8263e067ab3df0f260e46bb467519b75074e85c1 Log: [FIXED JENKINS-16645] Fix constant value for 'informational' severity. – You received this message because you are subscribed to the Google Groups "Jenkins Commits" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-commits+unsubscribe@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out .
          Hide
          orrc Christopher Orr added a comment -

          Thanks for the info.

          Version 2.0.3 of the plugin has been release, including this fix.

          Show
          orrc Christopher Orr added a comment - Thanks for the info. Version 2.0.3 of the plugin has been release, including this fix.

            People

            • Assignee:
              orrc Christopher Orr
              Reporter:
              najjannaj Jan Loebel
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: