Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-16711

Cannot process %20 in repository URL

    Details

    • Similar Issues:

      Description

      A URL cannot contain blains. According to the RFC, all blanks (and some other characters) have to be encoded as %20 etc. As a result, "svn info" shows correct URLs (i. e. URLs with %20 in it, not with blanks in it).

      When providing a URL with %20 in it to the Jenkins GUI, Jenkins makes two errors:

      1. It says that this URL is not in the repository, which is simply wrong.
      2. It can checkout using this URL but is unable to further proceed.

      So the syntax handling should be improved.

        Attachments

          Issue Links

            Activity

            Hide
            mkarg Markus KARG added a comment -

            I do not understand why the priority was reduced: According to (2) this big effectively makes it impossible to use SVN repos having %20 in its URL.

            Show
            mkarg Markus KARG added a comment - I do not understand why the priority was reduced: According to (2) this big effectively makes it impossible to use SVN repos having %20 in its URL.
            Hide
            recena Manuel Recena Soto added a comment -

            Markus KARG, Using Subversion Plugin 2.5.4:

            Started by user anonymous
            [EnvInject] - Loading node environment variables.
            Building in workspace /Users/recena/Development/projects/subversion-plugin/work/jobs/JENKINS-16711-2/workspace
            Checking out a fresh workspace because there's no workspace at /Users/recena/Development/projects/subversion-plugin/work/jobs/JENKINS-16711-2/workspace
            Cleaning local Directory .
            Checking out http://192.168.1.113/svn/JENKINS%2016711 at revision '2015-12-14T10:29:23.016 +0100'
            A         README.txt
            At revision 1
            Finished: SUCCESS
            

            The job works fine. I'm working on improve the form validation.

            Show
            recena Manuel Recena Soto added a comment - Markus KARG , Using Subversion Plugin 2.5.4: Started by user anonymous [EnvInject] - Loading node environment variables. Building in workspace /Users/recena/Development/projects/subversion-plugin/work/jobs/JENKINS-16711-2/workspace Checking out a fresh workspace because there's no workspace at /Users/recena/Development/projects/subversion-plugin/work/jobs/JENKINS-16711-2/workspace Cleaning local Directory . Checking out http://192.168.1.113/svn/JENKINS%2016711 at revision '2015-12-14T10:29:23.016 +0100' A README.txt At revision 1 Finished: SUCCESS The job works fine. I'm working on improve the form validation.
            Hide
            mkarg Markus KARG added a comment - - edited

            Thanks for fixing this. It did not work for me when I filed the bug. Possibly there had been improvements already meanwhile.

            BTW, possibly the problem was caused on my machine because the local path within the workspace folder has a blank in it? It seems yours does not.

            Show
            mkarg Markus KARG added a comment - - edited Thanks for fixing this. It did not work for me when I filed the bug. Possibly there had been improvements already meanwhile. BTW, possibly the problem was caused on my machine because the local path within the workspace folder has a blank in it? It seems yours does not.
            Hide
            recena Manuel Recena Soto added a comment -

            Markus KARG, I'm reviewing the current implementation in order to follow this specification. Also, from the documention:

            Also, Subversion APIs require all URL parameters to be properly URI-encoded. So, instead of passing file:///home/username/My File.txt as the URL of a file named My File.txt, you need to pass file:///home/username/My%20File.txt. Again, Subversion supplies helper functions that your application can use—svn_path_uri_encode() and svn_path_uri_decode(), for URI encoding and decoding, respectively.

            Show
            recena Manuel Recena Soto added a comment - Markus KARG , I'm reviewing the current implementation in order to follow this specification . Also, from the documention: Also, Subversion APIs require all URL parameters to be properly URI-encoded. So, instead of passing file:///home/username/My File.txt as the URL of a file named My File.txt, you need to pass file:///home/username/My%20File.txt . Again, Subversion supplies helper functions that your application can use—svn_path_uri_encode() and svn_path_uri_decode(), for URI encoding and decoding, respectively.
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Manuel Recena
            Path:
            src/main/java/hudson/scm/SubversionChangeLogBuilder.java
            src/main/java/hudson/scm/SubversionSCM.java
            src/main/java/hudson/scm/subversion/CheckoutUpdater.java
            src/main/java/hudson/scm/subversion/UpdateUpdater.java
            src/main/resources/hudson/scm/subversion/Messages.properties
            http://jenkins-ci.org/commit/subversion-plugin/3a9cf510c6caa285478aeb4f5b914d30165947d4
            Log:
            JENKINS-16711 Allow repository URL-encoded

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Manuel Recena Path: src/main/java/hudson/scm/SubversionChangeLogBuilder.java src/main/java/hudson/scm/SubversionSCM.java src/main/java/hudson/scm/subversion/CheckoutUpdater.java src/main/java/hudson/scm/subversion/UpdateUpdater.java src/main/resources/hudson/scm/subversion/Messages.properties http://jenkins-ci.org/commit/subversion-plugin/3a9cf510c6caa285478aeb4f5b914d30165947d4 Log: JENKINS-16711 Allow repository URL-encoded
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Manuel Recena
            Path:
            src/main/java/hudson/scm/SubversionSCM.java
            http://jenkins-ci.org/commit/subversion-plugin/defa2084f7f41d8199ec9eaa4d8e5780cf1b9023
            Log:
            JENKINS-16711 If a revision (@NNN) is specified in the repository URL, it is considered in the validation process

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Manuel Recena Path: src/main/java/hudson/scm/SubversionSCM.java http://jenkins-ci.org/commit/subversion-plugin/defa2084f7f41d8199ec9eaa4d8e5780cf1b9023 Log: JENKINS-16711 If a revision (@NNN) is specified in the repository URL, it is considered in the validation process
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Manuel Recena
            Path:
            src/main/java/hudson/scm/SubversionChangeLogBuilder.java
            src/main/java/hudson/scm/SubversionSCM.java
            src/main/java/hudson/scm/subversion/CheckoutUpdater.java
            src/main/java/hudson/scm/subversion/UpdateUpdater.java
            src/main/resources/hudson/scm/subversion/Messages.properties
            http://jenkins-ci.org/commit/subversion-plugin/7e586e7a786742c44e2dfe1d3793c88ccc858a5a
            Log:
            Merge pull request #149 from recena/JENKINS-16711

            JENKINS-16711 Allow repository URL-encoded

            Compare: https://github.com/jenkinsci/subversion-plugin/compare/ae4ae6408801...7e586e7a7867

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Manuel Recena Path: src/main/java/hudson/scm/SubversionChangeLogBuilder.java src/main/java/hudson/scm/SubversionSCM.java src/main/java/hudson/scm/subversion/CheckoutUpdater.java src/main/java/hudson/scm/subversion/UpdateUpdater.java src/main/resources/hudson/scm/subversion/Messages.properties http://jenkins-ci.org/commit/subversion-plugin/7e586e7a786742c44e2dfe1d3793c88ccc858a5a Log: Merge pull request #149 from recena/ JENKINS-16711 JENKINS-16711 Allow repository URL-encoded Compare: https://github.com/jenkinsci/subversion-plugin/compare/ae4ae6408801...7e586e7a7867
            Hide
            svensteiniger Sven Steiniger added a comment -

            Can you please check whether the changes are the cause for JENKINS-32169? Thanks.

            Show
            svensteiniger Sven Steiniger added a comment - Can you please check whether the changes are the cause for JENKINS-32169 ? Thanks.
            Hide
            recena Manuel Recena Soto added a comment - - edited

            Sven Steiniger, better if we continue here JENKINS-32169

            Show
            recena Manuel Recena Soto added a comment - - edited Sven Steiniger , better if we continue here JENKINS-32169
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Manuel Recena
            Path:
            src/main/java/hudson/scm/SubversionSCM.java
            src/main/java/jenkins/scm/impl/subversion/SubversionSCMSource.java
            http://jenkins-ci.org/commit/subversion-plugin/2b160a1ec3bc18224082141bf3683276d7aac6a8
            Log:
            JENKINS-16711 SVNPath must be built from a decoded path

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Manuel Recena Path: src/main/java/hudson/scm/SubversionSCM.java src/main/java/jenkins/scm/impl/subversion/SubversionSCMSource.java http://jenkins-ci.org/commit/subversion-plugin/2b160a1ec3bc18224082141bf3683276d7aac6a8 Log: JENKINS-16711 SVNPath must be built from a decoded path
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Manuel Recena
            Path:
            src/main/java/hudson/scm/SubversionSCM.java
            src/main/java/jenkins/scm/impl/subversion/SubversionSCMSource.java
            http://jenkins-ci.org/commit/subversion-plugin/94b8c22306c77acf7fd7c386d8bc708c350faba7
            Log:
            Merge pull request #152 from recena/JENKINS-16711-PART2

            JENKINS-16711 SVNPath must be built from a decoded path

            Compare: https://github.com/jenkinsci/subversion-plugin/compare/dd634079c9f9...94b8c22306c7

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Manuel Recena Path: src/main/java/hudson/scm/SubversionSCM.java src/main/java/jenkins/scm/impl/subversion/SubversionSCMSource.java http://jenkins-ci.org/commit/subversion-plugin/94b8c22306c77acf7fd7c386d8bc708c350faba7 Log: Merge pull request #152 from recena/ JENKINS-16711 -PART2 JENKINS-16711 SVNPath must be built from a decoded path Compare: https://github.com/jenkinsci/subversion-plugin/compare/dd634079c9f9...94b8c22306c7
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Manuel Recena
            Path:
            src/main/java/hudson/scm/SubversionChangeLogBuilder.java
            src/main/java/hudson/scm/SubversionEventHandlerImpl.java
            http://jenkins-ci.org/commit/subversion-plugin/ec10c72dd0a4a05add0f63733d36450ff7f2e7a1
            Log:
            JENKINS-16711 Encode the URLs when are shown in the logger

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Manuel Recena Path: src/main/java/hudson/scm/SubversionChangeLogBuilder.java src/main/java/hudson/scm/SubversionEventHandlerImpl.java http://jenkins-ci.org/commit/subversion-plugin/ec10c72dd0a4a05add0f63733d36450ff7f2e7a1 Log: JENKINS-16711 Encode the URLs when are shown in the logger
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Manuel Recena
            Path:
            src/main/java/hudson/scm/SubversionChangeLogBuilder.java
            src/main/java/hudson/scm/SubversionEventHandlerImpl.java
            http://jenkins-ci.org/commit/subversion-plugin/910139260fbcbf3d9fc6ab8d8251b73e41ebe935
            Log:
            Merge pull request #153 from recena/JENKINS-16711-PART3

            JENKINS-16711 Encode the URLs when are shown in the logger

            Compare: https://github.com/jenkinsci/subversion-plugin/compare/94b8c22306c7...910139260fbc

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Manuel Recena Path: src/main/java/hudson/scm/SubversionChangeLogBuilder.java src/main/java/hudson/scm/SubversionEventHandlerImpl.java http://jenkins-ci.org/commit/subversion-plugin/910139260fbcbf3d9fc6ab8d8251b73e41ebe935 Log: Merge pull request #153 from recena/ JENKINS-16711 -PART3 JENKINS-16711 Encode the URLs when are shown in the logger Compare: https://github.com/jenkinsci/subversion-plugin/compare/94b8c22306c7...910139260fbc

              People

              • Assignee:
                recena Manuel Recena Soto
                Reporter:
                mkarg Markus KARG
              • Votes:
                1 Vote for this issue
                Watchers:
                5 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: