Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-16815

UpdateSite.updateDirectly fails to specify ID and version

    Details

    • Similar Issues:

      Description

      UpdateSite.updateDirectly (from #692) fails to append ?id=...&version=... to the URL it downloads, preventing a "smart" update center with routing rules from serving appropriate content.

      This can be very dangerous; in particular trunk versions of maven-plugin (1.501 as of this writing) have a fatal linkage error when run on 1.480.x which even prevents startup (forces manual recovery). Of course the UI would show a warning about the core version mismatch, but you would not want to call updateAllSites and then programmatically ask to install an unspecified version of this plugin!

      Compare DownloadService.generateFragment and the associated downloadService JavaScript.

        Attachments

          Activity

          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Ryan Campbell
          Path:
          core/src/main/java/hudson/model/UpdateSite.java
          http://jenkins-ci.org/commit/jenkins/7fdd27f7bd83a8323e07df304bb4722116d852ff
          Log:
          JENKINS-16815 Specify ID and version in UpdateSite.updateDirectly

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Ryan Campbell Path: core/src/main/java/hudson/model/UpdateSite.java http://jenkins-ci.org/commit/jenkins/7fdd27f7bd83a8323e07df304bb4722116d852ff Log: JENKINS-16815 Specify ID and version in UpdateSite.updateDirectly
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Nicolas De loof
          Path:
          core/src/main/java/hudson/model/UpdateSite.java
          http://jenkins-ci.org/commit/jenkins/cfd629d86682a38feb80c2feac8fcdec130b1df0
          Log:
          Merge pull request #710 from recampbell/update-site-parameters

          JENKINS-16815 Specify ID and version in UpdateSite.updateDirectly

          Compare: https://github.com/jenkinsci/jenkins/compare/6270556267ce...cfd629d86682


          You received this message because you are subscribed to the Google Groups "Jenkins Commits" group.
          To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-commits+unsubscribe@googlegroups.com.
          For more options, visit https://groups.google.com/groups/opt_out.

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Nicolas De loof Path: core/src/main/java/hudson/model/UpdateSite.java http://jenkins-ci.org/commit/jenkins/cfd629d86682a38feb80c2feac8fcdec130b1df0 Log: Merge pull request #710 from recampbell/update-site-parameters JENKINS-16815 Specify ID and version in UpdateSite.updateDirectly Compare: https://github.com/jenkinsci/jenkins/compare/6270556267ce...cfd629d86682 – You received this message because you are subscribed to the Google Groups "Jenkins Commits" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-commits+unsubscribe@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out .
          Hide
          dogfood dogfood added a comment -

          Integrated in jenkins_main_trunk #2278
          JENKINS-16815 Specify ID and version in UpdateSite.updateDirectly (Revision 7fdd27f7bd83a8323e07df304bb4722116d852ff)

          Result = SUCCESS
          Ryan Campbell : 7fdd27f7bd83a8323e07df304bb4722116d852ff
          Files :

          • core/src/main/java/hudson/model/UpdateSite.java
          Show
          dogfood dogfood added a comment - Integrated in jenkins_main_trunk #2278 JENKINS-16815 Specify ID and version in UpdateSite.updateDirectly (Revision 7fdd27f7bd83a8323e07df304bb4722116d852ff) Result = SUCCESS Ryan Campbell : 7fdd27f7bd83a8323e07df304bb4722116d852ff Files : core/src/main/java/hudson/model/UpdateSite.java

            People

            • Assignee:
              recampbell Ryan Campbell
              Reporter:
              jglick Jesse Glick
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: