Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-16837

Don't change build status

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed (View Workflow)
    • Priority: Critical
    • Resolution: Fixed
    • Component/s: jacoco-plugin
    • Labels:
      None
    • Environment:
      Jenkins JaCoCo plugin/1.0.10
    • Similar Issues:

      Description

      Do not change build status depending on health threshold.

      It does not make sense. When you have an application without any tests does that mean it can't be built? A build is unstable when some tests fail (i.e. the app under the test does not behave as expected), not when you don't have enough tests.

        Attachments

          Issue Links

            Activity

            Hide
            ognjenb Ognjen Bubalo added a comment -

            Ok. Is it better to change the background colors e.g. in the new JaCoCo column?

            Show
            ognjenb Ognjen Bubalo added a comment - Ok. Is it better to change the background colors e.g. in the new JaCoCo column?
            Hide
            frantam Franta Mejta added a comment -

            I think that just reporting health is sufficient.
            You can alter the new column, I don't use it anyway Showing coverage in weather report seems enough to me.

            Show
            frantam Franta Mejta added a comment - I think that just reporting health is sufficient. You can alter the new column, I don't use it anyway Showing coverage in weather report seems enough to me.
            Hide
            ognjenb Ognjen Bubalo added a comment -

            Will be fixed in the next release.

            Show
            ognjenb Ognjen Bubalo added a comment - Will be fixed in the next release.
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Ognjen Bubalo
            Path:
            src/main/java/hudson/plugins/jacoco/JacocoBuildAction.java
            src/main/java/hudson/plugins/jacoco/JacocoHealthReportThresholds.java
            src/main/java/hudson/plugins/jacoco/JacocoPublisher.java
            src/main/java/hudson/plugins/jacoco/report/CoverageReport.java
            src/main/resources/hudson/plugins/jacoco/JacocoPublisher/config.jelly
            http://jenkins-ci.org/commit/jacoco-plugin/cb492c16ade3847569bbcb3e72c8bd52024a0077
            Log:
            Fixing
            JENKINS-16837: Don't change build status

            Compare: https://github.com/jenkinsci/jacoco-plugin/compare/a1243a6a16bc...cb492c16ade3


            You received this message because you are subscribed to the Google Groups "Jenkins Commits" group.
            To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-commits+unsubscribe@googlegroups.com.
            For more options, visit https://groups.google.com/groups/opt_out.

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Ognjen Bubalo Path: src/main/java/hudson/plugins/jacoco/JacocoBuildAction.java src/main/java/hudson/plugins/jacoco/JacocoHealthReportThresholds.java src/main/java/hudson/plugins/jacoco/JacocoPublisher.java src/main/java/hudson/plugins/jacoco/report/CoverageReport.java src/main/resources/hudson/plugins/jacoco/JacocoPublisher/config.jelly http://jenkins-ci.org/commit/jacoco-plugin/cb492c16ade3847569bbcb3e72c8bd52024a0077 Log: Fixing JENKINS-16837 : Don't change build status Compare: https://github.com/jenkinsci/jacoco-plugin/compare/a1243a6a16bc...cb492c16ade3 – You received this message because you are subscribed to the Google Groups "Jenkins Commits" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-commits+unsubscribe@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out .

              People

              • Assignee:
                ognjenb Ognjen Bubalo
                Reporter:
                frantam Franta Mejta
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: