Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-16851

Strategy GerritTrigger missing with git plugin 1.1.28

    XMLWordPrintable

    Details

    • Similar Issues:

      Description

      After upgrading to git plugin 1.1.28 the GerritTrigger strategy is not available anymore, all gerrit trigger jobs fail.

        Attachments

          Activity

          pedersen Björn Pedersen created issue -
          Hide
          pedersen Björn Pedersen added a comment -

          Changes in the BuildChooserDeafault/Inverse in git plugin:

          -import hudson.plugins.git.IGitAPI;
          +import hudson.plugins.git.client.IGitAPI;

          Show
          pedersen Björn Pedersen added a comment - Changes in the BuildChooserDeafault/Inverse in git plugin: -import hudson.plugins.git.IGitAPI; +import hudson.plugins.git.client.IGitAPI;
          Hide
          marcelhuber Marcel Huber added a comment -

          I encountered same effects when using jenkins 1.502 and either git-plugin 1.1.27 or 1.1.28. So it might be related to 'platform' changes and not only git-plugin-changes.

          Show
          marcelhuber Marcel Huber added a comment - I encountered same effects when using jenkins 1.502 and either git-plugin 1.1.27 or 1.1.28. So it might be related to 'platform' changes and not only git-plugin-changes.
          Hide
          pedersen Björn Pedersen added a comment -

          After reverting git-plugin to 1.1.26 everything is back to normal here. The change was introduced in git 1.1.27, 1.1.28 was just a minor bugfix.

          Show
          pedersen Björn Pedersen added a comment - After reverting git-plugin to 1.1.26 everything is back to normal here. The change was introduced in git 1.1.27, 1.1.28 was just a minor bugfix.
          Hide
          marcelhuber Marcel Huber added a comment -

          Thank you Björn, I did not step back in git-plugin versions so I missed this one, sorry.

          Show
          marcelhuber Marcel Huber added a comment - Thank you Björn, I did not step back in git-plugin versions so I missed this one, sorry.
          pedersen Björn Pedersen made changes -
          Field Original Value New Value
          Summary Strategy GerritTrigger missing with plugin 1.1.28 Strategy GerritTrigger missing with git plugin 1.1.28
          Hide
          rsandell rsandell added a comment -

          The git plugin beats me again

          I've managed to fix the incompatibility, and in the process I happened to fix the changelog issue in GT as well.
          But that introduced an infinite loop between the git plugin and Mailer in core when the culprits are being calculated at the end of the build.
          From the looks of it it does not have to do with my changes, but I need to dive into it more before I let it loose in the wild.

          Show
          rsandell rsandell added a comment - The git plugin beats me again I've managed to fix the incompatibility, and in the process I happened to fix the changelog issue in GT as well. But that introduced an infinite loop between the git plugin and Mailer in core when the culprits are being calculated at the end of the build. From the looks of it it does not have to do with my changes, but I need to dive into it more before I let it loose in the wild.
          Hide
          jglick Jesse Glick added a comment -
          Show
          jglick Jesse Glick added a comment - https://wiki.jenkins-ci.org/display/JENKINS/Git+Plugin claims this is fixed in 1.1.29.
          Hide
          rsandell rsandell added a comment -

          I probably need to do some changes in the Gerrit Trigger as well, because the current code assumes that the IGitApi reference is something else (by casting it) so that it can do some log parsing. And with the new git api implementation that assumption is wrong.

          Show
          rsandell rsandell added a comment - I probably need to do some changes in the Gerrit Trigger as well, because the current code assumes that the IGitApi reference is something else (by casting it) so that it can do some log parsing. And with the new git api implementation that assumption is wrong.
          Hide
          pedersen Björn Pedersen added a comment -
          Show
          pedersen Björn Pedersen added a comment - The infinite loop could be: https://issues.jenkins-ci.org/browse/JENKINS-16849
          Hide
          rsandell rsandell added a comment -

          Yes that looks very similar.

          Show
          rsandell rsandell added a comment - Yes that looks very similar.
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: rsandell
          Path:
          gerrithudsontrigger/pom.xml
          gerrithudsontrigger/src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/hudsontrigger/GerritTriggerBuildChooser.java
          http://jenkins-ci.org/commit/gerrit-trigger-plugin/65271af7819f62d258ec1cadd70434129bf299c9
          Log:
          Fix For JENKINS-16851

          It is probably fixed in git plugin v. 1.1.29
          this commit should remove any use of deprecated APIs.
          But when I test this I gen something very similar to
          JENKINS-16849 at the end of the build.


          You received this message because you are subscribed to the Google Groups "Jenkins Commits" group.
          To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-commits+unsubscribe@googlegroups.com.
          For more options, visit https://groups.google.com/groups/opt_out.

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: rsandell Path: gerrithudsontrigger/pom.xml gerrithudsontrigger/src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/hudsontrigger/GerritTriggerBuildChooser.java http://jenkins-ci.org/commit/gerrit-trigger-plugin/65271af7819f62d258ec1cadd70434129bf299c9 Log: Fix For JENKINS-16851 It is probably fixed in git plugin v. 1.1.29 this commit should remove any use of deprecated APIs. But when I test this I gen something very similar to JENKINS-16849 at the end of the build. – You received this message because you are subscribed to the Google Groups "Jenkins Commits" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-commits+unsubscribe@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out .
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Robert Sandell
          Path:
          gerrithudsontrigger/pom.xml
          gerrithudsontrigger/src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/hudsontrigger/GerritTriggerBuildChooser.java
          http://jenkins-ci.org/commit/gerrit-trigger-plugin/155ab6790a33b6f0b229976a40f5ee5f64d1ce22
          Log:
          Removed use of deprecated APIs for git BuildChooser

          Followup fix for JENKINS-16851 which is fixed in git plugin v. 1.2.0
          this commit should remove any use of deprecated APIs after the
          introduction of gitclient plugin.

          Change-Id: Ibaa11fe9e06150555af675aae1a32f29cb15aab3

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Robert Sandell Path: gerrithudsontrigger/pom.xml gerrithudsontrigger/src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/hudsontrigger/GerritTriggerBuildChooser.java http://jenkins-ci.org/commit/gerrit-trigger-plugin/155ab6790a33b6f0b229976a40f5ee5f64d1ce22 Log: Removed use of deprecated APIs for git BuildChooser Followup fix for JENKINS-16851 which is fixed in git plugin v. 1.2.0 this commit should remove any use of deprecated APIs after the introduction of gitclient plugin. Change-Id: Ibaa11fe9e06150555af675aae1a32f29cb15aab3
          Hide
          rsandell rsandell added a comment -

          Released in
          Git Plugin 1.2.0
          Gerrit Trigger Plugin 2.8.0

          Show
          rsandell rsandell added a comment - Released in Git Plugin 1.2.0 Gerrit Trigger Plugin 2.8.0
          rsandell rsandell made changes -
          Status Open [ 1 ] Resolved [ 5 ]
          Resolution Fixed [ 1 ]
          markewaite Mark Waite made changes -
          Status Resolved [ 5 ] Closed [ 6 ]
          rtyler R. Tyler Croy made changes -
          Workflow JNJira [ 147680 ] JNJira + In-Review [ 206416 ]

            People

            • Assignee:
              rsandell rsandell
              Reporter:
              pedersen Björn Pedersen
            • Votes:
              4 Vote for this issue
              Watchers:
              8 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: