Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-16919

Email-ext throws NullPointerException when "attach build log" is checked on 1.480.3

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Resolved (View Workflow)
    • Priority: Major
    • Resolution: Fixed
    • Component/s: email-ext-plugin
    • Environment:
      OS Windows_NT
      PROCESSOR_ARCHITECTURE x86
      PROCESSOR_ARCHITEW6432 AMD64

      java.runtime.version 1.6.0_26-b03
      Jenkins war org.jenkins-ci.main:jenkins-war:1.480.3
    • Similar Issues:

      Description

      List of plugins used in project:

      multiple-scms
      mercurial
      subversion
      nant
      sonar
      flexible-publish
      email-ext

      I perform a fairly simple build, use the flexible-plugin to only archive on success and then send an email. Without "attach build log" checked everything works, with it checked I get the following error:

      Run condition [Current build status] enabling perform for step [Archive the artifacts]
      Archiving artifacts
      Checking for post-build
      Performing post-build step
      Checking if email needs to be generated
      Email was triggered for: Success
      Sending email for trigger: Success
      NOT overriding default server settings, using Mailer to create session
      messageContentType = text/plain; charset=UTF-8
      Request made to attach build log
      Adding recipients from recipient list
      Successfully created MimeMessage
      Sending email to: MY.USERNAME@MYPLACEOFEMPLOYMENT.com
      ERROR: Could not send email as a part of the post-build publishers.
      java.lang.NullPointerException
      at hudson.plugins.emailext.ExtendedEmailPublisher.sendMail(ExtendedEmailPublisher.java:311)
      at hudson.plugins.emailext.ExtendedEmailPublisher._perform(ExtendedEmailPublisher.java:289)
      at hudson.plugins.emailext.ExtendedEmailPublisher.perform(ExtendedEmailPublisher.java:249)
      at hudson.tasks.BuildStepMonitor$3.perform(BuildStepMonitor.java:36)
      at hudson.model.AbstractBuild$AbstractBuildExecution.perform(AbstractBuild.java:718)
      at hudson.model.AbstractBuild$AbstractBuildExecution.performAllBuildSteps(AbstractBuild.java:693)
      at hudson.model.Build$BuildExecution.cleanUp(Build.java:192)
      at hudson.model.Run.execute(Run.java:1546)
      at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:46)
      at hudson.model.ResourceController.execute(ResourceController.java:88)
      at hudson.model.Executor.run(Executor.java:237)
      Some error occured trying to send the email...check the Jenkins log

        Attachments

        1. email-ext.hpi
          4.99 MB
        2. email-ext.hpi
          4.99 MB
        3. zip-build-before-attach.diff
          11 kB

          Activity

          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Alex Earl
          Path:
          src/main/java/hudson/plugins/emailext/ExtendedEmailPublisher.java
          http://jenkins-ci.org/commit/email-ext-plugin/9f207ef592417158ad01c711c1a6b9349c9edb5a
          Log:
          Fix JENKINS-16919

          Fixed NPE by checking return of the getters for the SendFailedException.


          You received this message because you are subscribed to the Google Groups "Jenkins Commits" group.
          To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-commits+unsubscribe@googlegroups.com.
          For more options, visit https://groups.google.com/groups/opt_out.

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Alex Earl Path: src/main/java/hudson/plugins/emailext/ExtendedEmailPublisher.java http://jenkins-ci.org/commit/email-ext-plugin/9f207ef592417158ad01c711c1a6b9349c9edb5a Log: Fix JENKINS-16919 Fixed NPE by checking return of the getters for the SendFailedException. – You received this message because you are subscribed to the Google Groups "Jenkins Commits" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-commits+unsubscribe@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out .
          Hide
          slide_o_mix Alex Earl added a comment -

          Fixed NPE when error occurs sending email.

          Show
          slide_o_mix Alex Earl added a comment - Fixed NPE when error occurs sending email.
          Hide
          morchard Mark Orchard added a comment -

          Hi Alex,

          I'm not entirely sure this is the right place to ask (actually I'm sure it isn't). I've added the option to compress the build log before attaching it to the email, I've tested the change on my local jenkins instance, and would like to push the change back into the email-ext repo, but I'm not sure what the process is, for now I've attached a git patch file to this ticket.

          Show
          morchard Mark Orchard added a comment - Hi Alex, I'm not entirely sure this is the right place to ask (actually I'm sure it isn't). I've added the option to compress the build log before attaching it to the email, I've tested the change on my local jenkins instance, and would like to push the change back into the email-ext repo, but I'm not sure what the process is, for now I've attached a git patch file to this ticket.
          Hide
          slide_o_mix Alex Earl added a comment -

          Best thing to do is fork the plugin on GitHub, make the changes and push to your fork then issue a pull request.

          Show
          slide_o_mix Alex Earl added a comment - Best thing to do is fork the plugin on GitHub, make the changes and push to your fork then issue a pull request.
          Hide
          morchard Mark Orchard added a comment -

          Cool, thanks. I'll try that... Time to go learn howto git!

          Show
          morchard Mark Orchard added a comment - Cool, thanks. I'll try that... Time to go learn howto git!

            People

            • Assignee:
              slide_o_mix Alex Earl
              Reporter:
              morchard Mark Orchard
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: