Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-17074

ImprovementTrigger doesn't trigger when a build improves all the way to having 0 test failures

    Details

    • Similar Issues:

      Description

      According to the trigger help, the improvement trigger will send an email "... any time there is an improvement. A build is considered to have improved wheneverit has fewer failures than the previous build." When a build improves all the way to having 0 test failures, this trigger is not triggered. I looked at the code and the ImprovementTrigger is using number of current failures > 0 (numCurrFailures > 0) as part of the criteria if the trigger should run.

      However, this condition matches the help text. Can the code be fixed? Or, the help text could be changed, but I'd prefer fixing the code so that this trigger produces the similar "back to stable" email messages. Thanks.

      EDIT: I see that there is a "Fixed" trigger, so maybe just tweak the help text?

        Attachments

          Activity

          Hide
          slide_o_mix Alex Earl added a comment -

          Feel free to submit a pull request with updated help text that you feel would be more clear.

          Show
          slide_o_mix Alex Earl added a comment - Feel free to submit a pull request with updated help text that you feel would be more clear.
          Hide
          slide_o_mix Alex Earl added a comment -

          Please feel free to submit a pull request with what you would consider more descriptive or better documentation.

          Show
          slide_o_mix Alex Earl added a comment - Please feel free to submit a pull request with what you would consider more descriptive or better documentation.
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Alex Earl
          Path:
          src/main/resources/hudson/plugins/emailext/plugins/trigger/Messages.properties
          http://jenkins-ci.org/commit/email-ext-plugin/2d987adcf6bd27eeb7b3239d66b82e9cd16215dc
          Log:
          Fix JENKINS-17074

          Updated the help test for Improvement Trigger.

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Alex Earl Path: src/main/resources/hudson/plugins/emailext/plugins/trigger/Messages.properties http://jenkins-ci.org/commit/email-ext-plugin/2d987adcf6bd27eeb7b3239d66b82e9cd16215dc Log: Fix JENKINS-17074 Updated the help test for Improvement Trigger.
          Hide
          slide_o_mix Alex Earl added a comment -

          Updated the help text to be more clear.

          Show
          slide_o_mix Alex Earl added a comment - Updated the help text to be more clear.

            People

            • Assignee:
              joshunger Josh Unger
              Reporter:
              joshunger Josh Unger
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: