Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-17074

ImprovementTrigger doesn't trigger when a build improves all the way to having 0 test failures

    Details

    • Similar Issues:

      Description

      According to the trigger help, the improvement trigger will send an email "... any time there is an improvement. A build is considered to have improved wheneverit has fewer failures than the previous build." When a build improves all the way to having 0 test failures, this trigger is not triggered. I looked at the code and the ImprovementTrigger is using number of current failures > 0 (numCurrFailures > 0) as part of the criteria if the trigger should run.

      However, this condition matches the help text. Can the code be fixed? Or, the help text could be changed, but I'd prefer fixing the code so that this trigger produces the similar "back to stable" email messages. Thanks.

      EDIT: I see that there is a "Fixed" trigger, so maybe just tweak the help text?

        Attachments

          Activity

          joshunger Josh Unger created issue -
          joshunger Josh Unger made changes -
          Field Original Value New Value
          Description According to the trigger help, the improvement trigger will send an email "... any time there is an improvement. A build is considered to have improved wheneverit has fewer failures than the previous build." When a build improves all the way to having 0 test failures, this trigger is not triggered. I looked at the code and the ImprovementTrigger is using number of current failures > 0 (numCurrFailures > 0) as part of the criteria if the trigger should run.

          However, this condition matches the help text. Can the code be fixed? Or, the help text could be changed, but I'd prefer fixing the code so that this trigger produces the similar "back to stable" email messages. Thanks.
          According to the trigger help, the improvement trigger will send an email "... any time there is an improvement. A build is considered to have improved wheneverit has fewer failures than the previous build." When a build improves all the way to having 0 test failures, this trigger is not triggered. I looked at the code and the ImprovementTrigger is using number of current failures > 0 (numCurrFailures > 0) as part of the criteria if the trigger should run.

          However, this condition matches the help text. Can the code be fixed? Or, the help text could be changed, but I'd prefer fixing the code so that this trigger produces the similar "back to stable" email messages. Thanks.

          EDIT: I see that there is a "Fixed" trigger, so maybe just tweak the help text?
          slide_o_mix Alex Earl made changes -
          Assignee Alex Earl [ slide_o_mix ] Josh Unger [ joshunger ]
          slide_o_mix Alex Earl made changes -
          Status Open [ 1 ] Resolved [ 5 ]
          Resolution Fixed [ 1 ]
          rtyler R. Tyler Croy made changes -
          Workflow JNJira [ 147905 ] JNJira + In-Review [ 192636 ]

            People

            • Assignee:
              joshunger Josh Unger
              Reporter:
              joshunger Josh Unger
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: