Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-17439

Perforce Quick Clean Does Not Remove All Build Files; Fails to Halt the Build

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Open (View Workflow)
    • Priority: Critical
    • Resolution: Unresolved
    • Component/s: perforce-plugin
    • Labels:
      None
    • Environment:
      Windows 2008 Server
    • Similar Issues:

      Description

      I hit a case where the Perforce "quick clean" option does not remove all of my class files.

      This leaves a class file in the /classes output directory, and when rebuilt, blocks the anonymous (MyClass$Anon.class) files from being generated, breaking the build.

      I do not see any error messages that indicate the root cause of this issue.

      This issues took me hours to track down and verify. If quick-clean had aborted the build when it fails, this would have saved a lot of headache.

      Here is failing directory before the clean:

      d---- 4/2/2013 3:52 PM firstperson
      d---- 4/2/2013 3:52 PM orbit
      a-- 4/2/2013 3:52 PM 16553 BasicView.class
      a-- 4/2/2013 3:52 PM 4859 BasicViewPropertyLimits.class
      a-- 4/2/2013 3:52 PM 2793 ViewElevationAnimator.class
      a-- 4/2/2013 3:52 PM 470 ViewModel.class
      a-- 4/2/2013 3:52 PM 1237 ViewPropertyAccessor$ElevationAccessor.class
      a-- 4/2/2013 3:52 PM 913 ViewPropertyAccessor$EyePositionAccessor.class
      a-- 4/2/2013 3:52 PM 876 ViewPropertyAccessor$HeadingAccessor.class
      a-- 4/2/2013 3:52 PM 868 ViewPropertyAccessor$PitchAccessor.class
      a-- 4/2/2013 3:52 PM 1422 ViewPropertyAccessor.class
      a-- 4/2/2013 3:52 PM 826 ViewPropertyLimits.class
      a-- 4/2/2013 3:52 PM 1366 ViewUtil$ViewState.class
      a-- 4/2/2013 3:52 PM 11575 ViewUtil.class

      After the clean I get:

      d---- 4/2/2013 4:43 PM firstperson
      d---- 4/2/2013 4:43 PM orbit
      a-- 4/2/2013 3:52 PM 1422 ViewPropertyAccessor.class

      As far as I can tell, there is no reason why this file should not have been removed.

        Attachments

          Activity

          Hide
          rpetti Rob Petti added a comment -

          Again, this is working fine for me in production, so I honestly don't know how to debug it.

          File a separate ticket for the .p4config issue. It's more complicated than you think, because your .p4config file can actually be named anything you want (as it is configurable by the P4CONFIG environment variable, which the p4 plugin clears when it runs).

          Show
          rpetti Rob Petti added a comment - Again, this is working fine for me in production, so I honestly don't know how to debug it. File a separate ticket for the .p4config issue. It's more complicated than you think, because your .p4config file can actually be named anything you want (as it is configurable by the P4CONFIG environment variable, which the p4 plugin clears when it runs).
          Hide
          alexey_larsky Alexey Larsky added a comment -

          Which Perforce client and server versions do you use?
          Each us ws has .p4client configuration.
          Which exact command should remove untracked files?

          PS. We use perforce with local proxies.

          Server version: P4D/LINUX26X86_64/2011.1/428451 (2012/03/08)
          Proxy version: P4P/LINUX26X86/2010.2/341251 (2011/08/05)
          ...
          Broker version: P4BROKER/LINUX26X86_64/2011.1/370818

          PPS. Perforce promises native 'p4 clean' command in ver. 2014.1
          http://www.p4ideax.com/ideas/434/add-a-clean-operation-to-p4-and-p4v

          Show
          alexey_larsky Alexey Larsky added a comment - Which Perforce client and server versions do you use? Each us ws has .p4client configuration. Which exact command should remove untracked files? PS. We use perforce with local proxies. Server version: P4D/LINUX26X86_64/2011.1/428451 (2012/03/08) Proxy version: P4P/LINUX26X86/2010.2/341251 (2011/08/05) ... Broker version: P4BROKER/LINUX26X86_64/2011.1/370818 PPS. Perforce promises native 'p4 clean' command in ver. 2014.1 http://www.p4ideax.com/ideas/434/add-a-clean-operation-to-p4-and-p4v
          Hide
          rpetti Rob Petti added a comment -

          I use 2012.1, also with proxies in each office.

          There is no single command to remove untracked files. The plugin compares what you have to your p4 have list (which is presumably empty, since you appear to be using a read-only replica) then removes anything that peforce doesn't think you have synced.

          Yes, p4 clean support will come in a future version of the plugin.

          Show
          rpetti Rob Petti added a comment - I use 2012.1, also with proxies in each office. There is no single command to remove untracked files. The plugin compares what you have to your p4 have list (which is presumably empty, since you appear to be using a read-only replica) then removes anything that peforce doesn't think you have synced. Yes, p4 clean support will come in a future version of the plugin.
          Hide
          rpetti Rob Petti added a comment -

          You will probably want to ensure that the broker is not configured to prevent any commands from running. That's caused the plugin problems in the past, and may be what you are experiencing.

          Show
          rpetti Rob Petti added a comment - You will probably want to ensure that the broker is not configured to prevent any commands from running. That's caused the plugin problems in the past, and may be what you are experiencing.
          Hide
          alexey_larsky Alexey Larsky added a comment -

          Update p4proxy 2010.2/341251 to 2013.3/740675 solve the issue.
          Before update p4proxy (2010.2/341251) version was less then p4d version (2011.1/428451).

          Show
          alexey_larsky Alexey Larsky added a comment - Update p4proxy 2010.2/341251 to 2013.3/740675 solve the issue. Before update p4proxy (2010.2/341251) version was less then p4d version (2011.1/428451).

            People

            • Assignee:
              Unassigned
              Reporter:
              cmcginty Casey McGinty
            • Votes:
              1 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated: