Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-17503

Global exclude list of user accounts

    Details

    • Type: New Feature
    • Status: Resolved (View Workflow)
    • Priority: Minor
    • Resolution: Fixed
    • Component/s: email-ext-plugin
    • Labels:
      None
    • Environment:
      Jenkins 1.480.3
      Email-ext 2.28
    • Similar Issues:

      Description

      Our CI system uses so called build accounts to execute builds. These accounts are considered as committers as they do changes to vcs. These accounts do not have email addresses, or email addresses are invalid. Email addresses for committers are searched from directory server in our system. I would like to rule out these build accounts from email sending altogether.

      First implementation alternative is to have a global exclude list of user accounts. For these accounts, email address resolution would be skipped and thus the whole email sending.

      Second implementation alternative is to remove build account email addresses from the email message prior its sending. This is not as optimal as the first alternative as it requires email address resolution, but it gets the job done. This solution alternative requires configuration at global level too and is therefore related to JENKINS-14508.

      As a workaround, I can use project level pre-send script to filter out unwanted email addresses.

        Attachments

          Issue Links

            Activity

            Hide
            slide_o_mix Alex Earl added a comment -

            The address resolution is actually done in the scm plugins, so there would have to be changes to those to support the blacklist idea. Email-ext just calls the core address resolution functionality.

            Show
            slide_o_mix Alex Earl added a comment - The address resolution is actually done in the scm plugins, so there would have to be changes to those to support the blacklist idea. Email-ext just calls the core address resolution functionality.
            Hide
            shinsato shinsato added a comment -

            Would be nice to have a global solution with a simple ui rather than a change to each scm.

            Show
            shinsato shinsato added a comment - Would be nice to have a global solution with a simple ui rather than a change to each scm.
            Hide
            salsa Sami Salonen added a comment -

            Isn't it so that Email-ext gets the user IDs of committers? Could it then simply filter out blacklisted ones before requesting email address resolution for the remaining ones?

            Show
            salsa Sami Salonen added a comment - Isn't it so that Email-ext gets the user IDs of committers? Could it then simply filter out blacklisted ones before requesting email address resolution for the remaining ones?
            Hide
            slide_o_mix Alex Earl added a comment -

            That could be done, but I think a global solution would be better.

            Show
            slide_o_mix Alex Earl added a comment - That could be done, but I think a global solution would be better.
            Hide
            shinsato shinsato added a comment -

            Am interested in doing this right - but I submitted a pull request so an implementation in email-ext could be looked at as part of the conversation: https://github.com/jenkinsci/email-ext-plugin/pull/63

            Show
            shinsato shinsato added a comment - Am interested in doing this right - but I submitted a pull request so an implementation in email-ext could be looked at as part of the conversation: https://github.com/jenkinsci/email-ext-plugin/pull/63
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Harold Shinsato
            Path:
            src/main/java/hudson/plugins/emailext/ExtendedEmailPublisher.java
            src/main/java/hudson/plugins/emailext/ExtendedEmailPublisherDescriptor.java
            src/main/resources/hudson/plugins/emailext/ExtendedEmailPublisher/global.groovy
            src/main/webapp/help/globalConfig/excludedCommitters.html
            http://jenkins-ci.org/commit/email-ext-plugin/57c6b86d67f0a89842ec41f8c0097dac533179d8
            Log:
            Fix for JENKINS-17503

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Harold Shinsato Path: src/main/java/hudson/plugins/emailext/ExtendedEmailPublisher.java src/main/java/hudson/plugins/emailext/ExtendedEmailPublisherDescriptor.java src/main/resources/hudson/plugins/emailext/ExtendedEmailPublisher/global.groovy src/main/webapp/help/globalConfig/excludedCommitters.html http://jenkins-ci.org/commit/email-ext-plugin/57c6b86d67f0a89842ec41f8c0097dac533179d8 Log: Fix for JENKINS-17503
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Alex Earl
            Path:
            src/main/java/hudson/plugins/emailext/ExtendedEmailPublisher.java
            src/main/java/hudson/plugins/emailext/ExtendedEmailPublisherDescriptor.java
            src/main/resources/hudson/plugins/emailext/ExtendedEmailPublisher/global.groovy
            src/main/webapp/help/globalConfig/excludedCommitters.html
            http://jenkins-ci.org/commit/email-ext-plugin/519f012a2a59782e1fcccf6ab1de6aebff14b993
            Log:
            Merge pull request #63 from hajush/master

            Fix for JENKINS-17503 by adding an excluded committer list to email-ext global config

            Compare: https://github.com/jenkinsci/email-ext-plugin/compare/4af57bfdfccc...519f012a2a59

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Alex Earl Path: src/main/java/hudson/plugins/emailext/ExtendedEmailPublisher.java src/main/java/hudson/plugins/emailext/ExtendedEmailPublisherDescriptor.java src/main/resources/hudson/plugins/emailext/ExtendedEmailPublisher/global.groovy src/main/webapp/help/globalConfig/excludedCommitters.html http://jenkins-ci.org/commit/email-ext-plugin/519f012a2a59782e1fcccf6ab1de6aebff14b993 Log: Merge pull request #63 from hajush/master Fix for JENKINS-17503 by adding an excluded committer list to email-ext global config Compare: https://github.com/jenkinsci/email-ext-plugin/compare/4af57bfdfccc...519f012a2a59
            Hide
            slide_o_mix Alex Earl added a comment -

            Merged pull request

            Show
            slide_o_mix Alex Earl added a comment - Merged pull request

              People

              • Assignee:
                slide_o_mix Alex Earl
                Reporter:
                salsa Sami Salonen
              • Votes:
                0 Vote for this issue
                Watchers:
                5 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: