Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-17626

Retry count resets when job with other parameters is successful

    Details

    • Type: Bug
    • Status: Closed (View Workflow)
    • Priority: Minor
    • Resolution: Fixed
    • Component/s: naginator-plugin
    • Labels:
      None
    • Environment:
      jenkins 1.510, naginator plugin v 1.8
    • Similar Issues:

      Description

      Create a parameterized job, append naginator plugin, set fix retry time to e.g. 2 minutes and retry count to 3. Then and add a short action which can fail the build depending on the parametervalue.

      1) Launch the job with a parametervalue which causes the job to fail.
      2) Wait until naginator has started the job again (1. retry)
      3) Wait until naginator has started the job again (2. retry)
      4) during the waiting time for the third retry, start the job with parametervalue for a successful build.
      5) Wait until naginator has started the first (failing) job again (3. retry)

      Expected:
      The first job which fails all the time will not be started again after the third retry.

      Actually:
      Seems the successful build in (4) was resetting the count of (3) because the failed job is rebuild two times again.

        Attachments

          Issue Links

            Activity

            Hide
            ikedam ikedam added a comment -
            Show
            ikedam ikedam added a comment - Sent a pull request: https://github.com/jenkinsci/naginator-plugin/pull/19
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: ikedam
            Path:
            src/test/java/com/chikli/hudson/plugin/naginator/NaginatorListenerTest.java
            http://jenkins-ci.org/commit/naginator-plugin/d692788c49ff858c598e3cad6aac5580d57c6764
            Log:
            JENKINS-17626 Added a test to reproduce JENKINS-17626.

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: ikedam Path: src/test/java/com/chikli/hudson/plugin/naginator/NaginatorListenerTest.java http://jenkins-ci.org/commit/naginator-plugin/d692788c49ff858c598e3cad6aac5580d57c6764 Log: JENKINS-17626 Added a test to reproduce JENKINS-17626 .
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: ikedam
            Path:
            src/main/java/com/chikli/hudson/plugin/naginator/NaginatorAction.java
            src/main/java/com/chikli/hudson/plugin/naginator/NaginatorListener.java
            src/main/java/com/chikli/hudson/plugin/naginator/NaginatorMatrixAction.java
            src/main/java/com/chikli/hudson/plugin/naginator/NaginatorRetryAction.java
            src/test/java/com/chikli/hudson/plugin/naginator/ProgressiveDelayTest.java
            http://jenkins-ci.org/commit/naginator-plugin/eb8773647e669a2b36c8d7de9bbb70e9394aeb0c
            Log:
            [FIXED JENKINS-17626] Stores retry counts in NaginatorAction and reschedules build exact configured times.

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: ikedam Path: src/main/java/com/chikli/hudson/plugin/naginator/NaginatorAction.java src/main/java/com/chikli/hudson/plugin/naginator/NaginatorListener.java src/main/java/com/chikli/hudson/plugin/naginator/NaginatorMatrixAction.java src/main/java/com/chikli/hudson/plugin/naginator/NaginatorRetryAction.java src/test/java/com/chikli/hudson/plugin/naginator/ProgressiveDelayTest.java http://jenkins-ci.org/commit/naginator-plugin/eb8773647e669a2b36c8d7de9bbb70e9394aeb0c Log: [FIXED JENKINS-17626] Stores retry counts in NaginatorAction and reschedules build exact configured times.
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Nicolas De loof
            Path:
            src/main/java/com/chikli/hudson/plugin/naginator/NaginatorAction.java
            src/main/java/com/chikli/hudson/plugin/naginator/NaginatorListener.java
            src/main/java/com/chikli/hudson/plugin/naginator/NaginatorMatrixAction.java
            src/main/java/com/chikli/hudson/plugin/naginator/NaginatorRetryAction.java
            src/test/java/com/chikli/hudson/plugin/naginator/NaginatorListenerTest.java
            src/test/java/com/chikli/hudson/plugin/naginator/ProgressiveDelayTest.java
            http://jenkins-ci.org/commit/naginator-plugin/6b07b088edcd576082d734cede6f52f21dd1f270
            Log:
            Merge pull request #19 from ikedam/feature/JENKINS-17626_FixRetryCount

            JENKINS-17626 Count the number a build rescheduled precisely

            Compare: https://github.com/jenkinsci/naginator-plugin/compare/a8f193d70c14...6b07b088edcd

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Nicolas De loof Path: src/main/java/com/chikli/hudson/plugin/naginator/NaginatorAction.java src/main/java/com/chikli/hudson/plugin/naginator/NaginatorListener.java src/main/java/com/chikli/hudson/plugin/naginator/NaginatorMatrixAction.java src/main/java/com/chikli/hudson/plugin/naginator/NaginatorRetryAction.java src/test/java/com/chikli/hudson/plugin/naginator/NaginatorListenerTest.java src/test/java/com/chikli/hudson/plugin/naginator/ProgressiveDelayTest.java http://jenkins-ci.org/commit/naginator-plugin/6b07b088edcd576082d734cede6f52f21dd1f270 Log: Merge pull request #19 from ikedam/feature/ JENKINS-17626 _FixRetryCount JENKINS-17626 Count the number a build rescheduled precisely Compare: https://github.com/jenkinsci/naginator-plugin/compare/a8f193d70c14...6b07b088edcd
            Hide
            ikedam ikedam added a comment -

            Fixed in 1.16.
            It will be available in the update center in a day.
            Please try that.

            Show
            ikedam ikedam added a comment - Fixed in 1.16. It will be available in the update center in a day. Please try that.

              People

              • Assignee:
                ikedam ikedam
                Reporter:
                zioschild Sven Appenrodt
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: