Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-17674

Expand SecurityRealm to support case insensitivity better

    Details

    • Type: Improvement
    • Status: Resolved (View Workflow)
    • Priority: Major
    • Resolution: Fixed
    • Component/s: core
    • Labels:
      None
    • Similar Issues:

      Description

      Some {{SecurityRealm}}s are case insensitive, notably Active Director, but the current core abstraction assumes that user names and group names are totally case sensitive.

      In JENKINS-12607, I attempted a fix to canonicalize the names to lower case, but this resulted in massive regression because various parts of Jenkins (such as AuthorizationStrategy stores information keyed by the user name, and changing the user name breaks them.

      We need to expand abstractions in the core (perhaps by even patching Acegi?) so that authorization code would naturally steer toward doing proper comparison.

        Attachments

          Issue Links

            Activity

            kohsuke Kohsuke Kawaguchi created issue -
            kohsuke Kohsuke Kawaguchi made changes -
            Field Original Value New Value
            Link This issue is related to JENKINS-12607 [ JENKINS-12607 ]
            kohsuke Kohsuke Kawaguchi made changes -
            Link This issue is related to JENKINS-12594 [ JENKINS-12594 ]
            raspy Krzysztof Malinowski made changes -
            Link This issue is blocking JENKINS-12180 [ JENKINS-12180 ]
            raspy Krzysztof Malinowski made changes -
            Link This issue is related to JENKINS-12180 [ JENKINS-12180 ]
            raspy Krzysztof Malinowski made changes -
            Link This issue is blocking JENKINS-12180 [ JENKINS-12180 ]
            mdkf Michael Fowler made changes -
            Link This issue is related to JENKINS-6377 [ JENKINS-6377 ]
            mdkf Michael Fowler made changes -
            Link This issue is related to JENKINS-3218 [ JENKINS-3218 ]
            mdkf Michael Fowler made changes -
            Link This issue is related to JENKINS-4354 [ JENKINS-4354 ]
            mdkf Michael Fowler made changes -
            Link This issue is blocking JENKINS-4354 [ JENKINS-4354 ]
            mdkf Michael Fowler made changes -
            Link This issue is blocking JENKINS-4550 [ JENKINS-4550 ]
            oleg_nenashev Oleg Nenashev made changes -
            Link This issue depends on JENKINS-22247 [ JENKINS-22247 ]
            oleg_nenashev Oleg Nenashev made changes -
            Status Open [ 1 ] Resolved [ 5 ]
            Resolution Fixed [ 1 ]
            rtyler R. Tyler Croy made changes -
            Workflow JNJira [ 148854 ] JNJira + In-Review [ 192904 ]

              People

              • Assignee:
                Unassigned
                Reporter:
                kohsuke Kohsuke Kawaguchi
              • Votes:
                6 Vote for this issue
                Watchers:
                6 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: