Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-17724

/about no longer shows third-party licenses

    XMLWordPrintable

    Details

    • Similar Issues:

      Description

      Regression in 1.506. <st:include page="/META-INF/licenses.xml"/> no longer works. Probably due to: https://github.com/stapler/stapler/compare/stapler-parent-1.199...stapler-parent-1.207

        Attachments

          Activity

          Hide
          jglick Jesse Glick added a comment -

          https://github.com/stapler/stapler/commit/fef6e6151f5122bafd44dba24409778038b4c539 (or an earlier commit) is responsible: !hasAllowedExtension("/META-INF/licenses.xml") so resolveScript returns null.

          Show
          jglick Jesse Glick added a comment - https://github.com/stapler/stapler/commit/fef6e6151f5122bafd44dba24409778038b4c539 (or an earlier commit) is responsible: !hasAllowedExtension("/META-INF/licenses.xml") so resolveScript returns null .
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Jesse Glick
          Path:
          changelog.html
          core/src/main/java/hudson/AboutJenkins.java
          core/src/main/resources/hudson/AboutJenkins/index.jelly
          http://jenkins-ci.org/commit/jenkins/0bf434845b5de755d730fb73ae1688b02dba8894
          Log:
          [FIXED JENKINS-17724] /about was not showing licenses.
          A recent Stapler update caused the Jelly facet to ignore *.xml.
          So need to use raw j:include (as plugins were doing), not st:include (as core did).

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: changelog.html core/src/main/java/hudson/AboutJenkins.java core/src/main/resources/hudson/AboutJenkins/index.jelly http://jenkins-ci.org/commit/jenkins/0bf434845b5de755d730fb73ae1688b02dba8894 Log: [FIXED JENKINS-17724] /about was not showing licenses. A recent Stapler update caused the Jelly facet to ignore *.xml. So need to use raw j:include (as plugins were doing), not st:include (as core did).
          Hide
          dogfood dogfood added a comment -

          Integrated in jenkins_main_trunk #2486
          [FIXED JENKINS-17724] /about was not showing licenses. (Revision 0bf434845b5de755d730fb73ae1688b02dba8894)

          Result = SUCCESS
          Jesse Glick : 0bf434845b5de755d730fb73ae1688b02dba8894
          Files :

          • changelog.html
          • core/src/main/resources/hudson/AboutJenkins/index.jelly
          • core/src/main/java/hudson/AboutJenkins.java
          Show
          dogfood dogfood added a comment - Integrated in jenkins_main_trunk #2486 [FIXED JENKINS-17724] /about was not showing licenses. (Revision 0bf434845b5de755d730fb73ae1688b02dba8894) Result = SUCCESS Jesse Glick : 0bf434845b5de755d730fb73ae1688b02dba8894 Files : changelog.html core/src/main/resources/hudson/AboutJenkins/index.jelly core/src/main/java/hudson/AboutJenkins.java
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Jesse Glick
          Path:
          changelog.html
          core/src/main/java/hudson/AboutJenkins.java
          core/src/main/resources/hudson/AboutJenkins/index.jelly
          http://jenkins-ci.org/commit/jenkins/45699fed47c0b1f1154296d7cba44c852b7df3d1
          Log:
          [FIXED JENKINS-17724] /about was not showing licenses.
          A recent Stapler update caused the Jelly facet to ignore *.xml.
          So need to use raw j:include (as plugins were doing), not st:include (as core did).(cherry picked from commit 0bf434845b5de755d730fb73ae1688b02dba8894)

          Conflicts:
          changelog.html
          core/src/main/resources/hudson/AboutJenkins/index.jelly

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: changelog.html core/src/main/java/hudson/AboutJenkins.java core/src/main/resources/hudson/AboutJenkins/index.jelly http://jenkins-ci.org/commit/jenkins/45699fed47c0b1f1154296d7cba44c852b7df3d1 Log: [FIXED JENKINS-17724] /about was not showing licenses. A recent Stapler update caused the Jelly facet to ignore *.xml. So need to use raw j:include (as plugins were doing), not st:include (as core did).(cherry picked from commit 0bf434845b5de755d730fb73ae1688b02dba8894) Conflicts: changelog.html core/src/main/resources/hudson/AboutJenkins/index.jelly

            People

            • Assignee:
              jglick Jesse Glick
              Reporter:
              jglick Jesse Glick
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: