Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-17798

build badge icon requires authentication

    XMLWordPrintable

    Details

    • Similar Issues:

      Description

      Maybe expose job status icon using an UnprotectedRootAction
      JENKINS/build-status-icon/

      {jobFullName}

      Then maybe have to consider impact on DISCOVER permission ?

        Attachments

          Issue Links

            Activity

            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: imod
            Path:
            pom.xml
            src/main/java/org/jenkinsci/plugins/badge/BadgeActionFactory.java
            src/main/java/org/jenkinsci/plugins/badge/ImageResolver.java
            src/main/java/org/jenkinsci/plugins/badge/PluginImpl.java
            src/main/java/org/jenkinsci/plugins/badge/PublicBadgeAction.java
            src/main/resources/org/jenkinsci/plugins/badge/BadgeAction/index.groovy
            src/main/resources/org/jenkinsci/plugins/badge/BadgeAction/index.properties
            src/main/resources/org/jenkinsci/plugins/badge/Messages.properties
            src/test/java/org/jenkinsci/plugins/badge/PublicBadgeActionTest.java
            http://jenkins-ci.org/commit/embeddable-build-status-plugin/7d2b5945c5a279ab4545aa41dedcd453eb66b15f
            Log:
            [FIXED JENKINS-17798] expose build badge via unprotected URL, but with new Permission

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: imod Path: pom.xml src/main/java/org/jenkinsci/plugins/badge/BadgeActionFactory.java src/main/java/org/jenkinsci/plugins/badge/ImageResolver.java src/main/java/org/jenkinsci/plugins/badge/PluginImpl.java src/main/java/org/jenkinsci/plugins/badge/PublicBadgeAction.java src/main/resources/org/jenkinsci/plugins/badge/BadgeAction/index.groovy src/main/resources/org/jenkinsci/plugins/badge/BadgeAction/index.properties src/main/resources/org/jenkinsci/plugins/badge/Messages.properties src/test/java/org/jenkinsci/plugins/badge/PublicBadgeActionTest.java http://jenkins-ci.org/commit/embeddable-build-status-plugin/7d2b5945c5a279ab4545aa41dedcd453eb66b15f Log: [FIXED JENKINS-17798] expose build badge via unprotected URL, but with new Permission
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Jesse Glick
            Path:
            pom.xml
            src/main/java/org/jenkinsci/plugins/badge/BadgeActionFactory.java
            src/main/java/org/jenkinsci/plugins/badge/ImageResolver.java
            src/main/java/org/jenkinsci/plugins/badge/PluginImpl.java
            src/main/java/org/jenkinsci/plugins/badge/PublicBadgeAction.java
            src/main/resources/org/jenkinsci/plugins/badge/BadgeAction/index.groovy
            src/main/resources/org/jenkinsci/plugins/badge/BadgeAction/index.properties
            src/main/resources/org/jenkinsci/plugins/badge/Messages.properties
            src/test/java/org/jenkinsci/plugins/badge/PublicBadgeActionTest.java
            http://jenkins-ci.org/commit/embeddable-build-status-plugin/3a6e78d3e0a4127e990b2cb39b2d9ab1faa2c71e
            Log:
            Merge pull request #4 from imod/unprotected-status

            [FIXED JENKINS-17798] expose build badge via unprotected URL, but with new Permission

            Compare: https://github.com/jenkinsci/embeddable-build-status-plugin/compare/11843c79f8e3...3a6e78d3e0a4

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: pom.xml src/main/java/org/jenkinsci/plugins/badge/BadgeActionFactory.java src/main/java/org/jenkinsci/plugins/badge/ImageResolver.java src/main/java/org/jenkinsci/plugins/badge/PluginImpl.java src/main/java/org/jenkinsci/plugins/badge/PublicBadgeAction.java src/main/resources/org/jenkinsci/plugins/badge/BadgeAction/index.groovy src/main/resources/org/jenkinsci/plugins/badge/BadgeAction/index.properties src/main/resources/org/jenkinsci/plugins/badge/Messages.properties src/test/java/org/jenkinsci/plugins/badge/PublicBadgeActionTest.java http://jenkins-ci.org/commit/embeddable-build-status-plugin/3a6e78d3e0a4127e990b2cb39b2d9ab1faa2c71e Log: Merge pull request #4 from imod/unprotected-status [FIXED JENKINS-17798] expose build badge via unprotected URL, but with new Permission Compare: https://github.com/jenkinsci/embeddable-build-status-plugin/compare/11843c79f8e3...3a6e78d3e0a4
            Hide
            aisystems Bob Rockers added a comment -

            Sorry to bug everyone on a successfully closed ticket, but where do I actually configure this setting? This is exactly the problem I need to overcome with github's camo image proxy but I cannot find the VIEW_STATUS setting anywhere.

            Show
            aisystems Bob Rockers added a comment - Sorry to bug everyone on a successfully closed ticket, but where do I actually configure this setting? This is exactly the problem I need to overcome with github's camo image proxy but I cannot find the VIEW_STATUS setting anywhere.
            Hide
            msound Mani Soundararajan added a comment -

            @aisystems I found "View Status" under Jenkins -> Global Security -> Authorization -> Matrix-based security.

            However I am trying to use the GitHub Committer auth strategy instead of Matrix. If you find a way of getting it to work with github oauth please post here.

            Show
            msound Mani Soundararajan added a comment - @aisystems I found "View Status" under Jenkins -> Global Security -> Authorization -> Matrix-based security. However I am trying to use the GitHub Committer auth strategy instead of Matrix. If you find a way of getting it to work with github oauth please post here.
            Hide
            retronym retronym added a comment -

            Mani Soundararajan

            I think either:

            1) the `GitHub OAuth` plugin would need to be changed to allow anoynmous access to the "ViewStatus" permission https://github.com/jenkinsci/embeddable-build-status-plugin/compare/11843c79f8e3...3a6e78d3e0a4#diff-25df045777dd8f7465c9cbac4dea6416R63, or
            2) this plugin would need to change to use the standard "hudson.model.Hudson.Read" / "hudson.model.Item.Read" permissions: https://github.com/jenkinsci/embeddable-build-status-plugin/compare/11843c79f8e3...3a6e78d3e0a4#diff-25df045777dd8f7465c9cbac4dea6416R103

            (Disclaimer: I'm not a Jenkins plugin expert, I just had a quick browse of the two code bases)

            Show
            retronym retronym added a comment - Mani Soundararajan I think either: 1) the `GitHub OAuth` plugin would need to be changed to allow anoynmous access to the "ViewStatus" permission https://github.com/jenkinsci/embeddable-build-status-plugin/compare/11843c79f8e3...3a6e78d3e0a4#diff-25df045777dd8f7465c9cbac4dea6416R63 , or 2) this plugin would need to change to use the standard "hudson.model.Hudson.Read" / "hudson.model.Item.Read" permissions: https://github.com/jenkinsci/embeddable-build-status-plugin/compare/11843c79f8e3...3a6e78d3e0a4#diff-25df045777dd8f7465c9cbac4dea6416R103 (Disclaimer: I'm not a Jenkins plugin expert, I just had a quick browse of the two code bases)

              People

              • Assignee:
                kohsuke Kohsuke Kawaguchi
                Reporter:
                ndeloof Nicolas De Loof
              • Votes:
                0 Vote for this issue
                Watchers:
                9 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: