Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-17955

DownstreamPassCondition mishandles jobs in folders

    Details

      Description

      DownstreamPassCondition.jobs is in some places (e.g. getJobList) interpreted as a list of paths relative to the current job, yet in other places as a list of absolute paths (e.g. contains). Also there is no form validation on this field. The result is that you may be tempted to use a relative path to a downstream job in the same folder, but the promotion will silently never occur unless you use an absolute path.

        Activity

        Hide
        jglick Jesse Glick added a comment -

        PromotionTrigger also seems flawed. jobName is interpreted in appliesTo as a fullDisplayName, i.e. Folder Display Name » Job Display Name; but in the DescriptorImpl as a fullName, i.e. folder/job.

        Show
        jglick Jesse Glick added a comment - PromotionTrigger also seems flawed. jobName is interpreted in appliesTo as a fullDisplayName , i.e. Folder Display Name » Job Display Name ; but in the DescriptorImpl as a fullName , i.e. folder/job .
        Hide
        scm_issue_link SCM/JIRA link daemon added a comment -

        Code changed in jenkins
        User: Nicolas De Loof
        Path:
        src/main/java/hudson/plugins/promoted_builds/PromotionTrigger.java
        src/main/java/hudson/plugins/promoted_builds/conditions/DownstreamPassCondition.java
        http://jenkins-ci.org/commit/promoted-builds-plugin/063a50bfe65e845bd74507507d1b4038a7338dc2
        Log:
        [FIXED JENKINS-17955] fix job (full)Name comparison

        Show
        scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Nicolas De Loof Path: src/main/java/hudson/plugins/promoted_builds/PromotionTrigger.java src/main/java/hudson/plugins/promoted_builds/conditions/DownstreamPassCondition.java http://jenkins-ci.org/commit/promoted-builds-plugin/063a50bfe65e845bd74507507d1b4038a7338dc2 Log: [FIXED JENKINS-17955] fix job (full)Name comparison

          People

          • Assignee:
            ndeloof Nicolas De Loof
            Reporter:
            jglick Jesse Glick
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: