Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-18014

[Email-ext plugin] ${ENV, var="FOO"} for 2.29 doesn't work anymore.

    Details

    • Similar Issues:

      Description

      After upgrading Email-ext plugin to 2.29 from 2.27.1 using the ${ENV, var="FOO"} format no longer works. $FOO does however. Once I reverted back to 2.27.1 it started working again.

        Attachments

          Issue Links

            Activity

            Hide
            slide_o_mix Alex Earl added a comment -

            The reason for that is the environment variables are actually replaced differently (through a mechanism in the Jenkins core, which doesn't support escaping). This replacement of environment variables is done before token macro does it's replacement.

            Show
            slide_o_mix Alex Earl added a comment - The reason for that is the environment variables are actually replaced differently (through a mechanism in the Jenkins core, which doesn't support escaping). This replacement of environment variables is done before token macro does it's replacement.
            Hide
            slide_o_mix Alex Earl added a comment -

            I have a pull request in for the Token Macro plugin that would change the way escapes for tokens work. This should allow using \${ENV...}

            Show
            slide_o_mix Alex Earl added a comment - I have a pull request in for the Token Macro plugin that would change the way escapes for tokens work. This should allow using \${ENV...}
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Alex Earl
            Path:
            src/main/java/org/jenkinsci/plugins/tokenmacro/TokenMacro.java
            src/main/java/org/jenkinsci/plugins/tokenmacro/Tokenizer.java
            src/test/java/org/jenkinsci/plugins/tokenmacro/TokenMacroTest.java
            http://jenkins-ci.org/commit/token-macro-plugin/e1523eca5fb78fad1112193829ee4782620d9ce5
            Log:
            Fix JENKINS-18014

            Changed the way that macros are escaped to using something similar to Groovy with two $'s. This required actually looking for the items that matched with two $'s and then handling that case special.

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Alex Earl Path: src/main/java/org/jenkinsci/plugins/tokenmacro/TokenMacro.java src/main/java/org/jenkinsci/plugins/tokenmacro/Tokenizer.java src/test/java/org/jenkinsci/plugins/tokenmacro/TokenMacroTest.java http://jenkins-ci.org/commit/token-macro-plugin/e1523eca5fb78fad1112193829ee4782620d9ce5 Log: Fix JENKINS-18014 Changed the way that macros are escaped to using something similar to Groovy with two $'s. This required actually looking for the items that matched with two $'s and then handling that case special.
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Alex Earl
            Path:
            src/main/java/org/jenkinsci/plugins/tokenmacro/TokenMacro.java
            src/main/java/org/jenkinsci/plugins/tokenmacro/Tokenizer.java
            src/test/java/org/jenkinsci/plugins/tokenmacro/TokenMacroTest.java
            http://jenkins-ci.org/commit/token-macro-plugin/8c10736b54aac32f1590720fa2f843febaf31b32
            Log:
            Merge pull request #12 from slide/master

            Fix JENKINS-18014

            Compare: https://github.com/jenkinsci/token-macro-plugin/compare/766cdb04c67a...8c10736b54aa

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Alex Earl Path: src/main/java/org/jenkinsci/plugins/tokenmacro/TokenMacro.java src/main/java/org/jenkinsci/plugins/tokenmacro/Tokenizer.java src/test/java/org/jenkinsci/plugins/tokenmacro/TokenMacroTest.java http://jenkins-ci.org/commit/token-macro-plugin/8c10736b54aac32f1590720fa2f843febaf31b32 Log: Merge pull request #12 from slide/master Fix JENKINS-18014 Compare: https://github.com/jenkinsci/token-macro-plugin/compare/766cdb04c67a...8c10736b54aa
            Hide
            slide_o_mix Alex Earl added a comment -

            This will be fixed in the token macro plugin in 1.8

            Show
            slide_o_mix Alex Earl added a comment - This will be fixed in the token macro plugin in 1.8

              People

              • Assignee:
                slide_o_mix Alex Earl
                Reporter:
                ericthefree Eric Freeman
              • Votes:
                1 Vote for this issue
                Watchers:
                5 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: