Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-18109

Show all violations highlighted on a single page

    XMLWordPrintable

    Details

    • Similar Issues:

      Description

      Under file path link can be visible source code where will be highlighted all violations. It's not really comfortable to click e.g. 50 times on line number link.

        Attachments

          Activity

          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Michal Turek
          Path:
          src/main/java/com/thalesgroup/hudson/plugins/cppcheck/CppcheckSource.java
          src/main/java/com/thalesgroup/hudson/plugins/cppcheck/model/CppcheckFile.java
          src/main/java/com/thalesgroup/hudson/plugins/cppcheck/model/CppcheckWorkspaceFile.java
          src/main/java/org/jenkinsci/plugins/cppcheck/CppcheckResult.java
          src/main/java/org/jenkinsci/plugins/cppcheck/CppcheckSourceAll.java
          src/main/resources/com/thalesgroup/hudson/plugins/cppcheck/CppcheckSource/index.jelly
          src/main/resources/org/jenkinsci/plugins/cppcheck/CppcheckResult/details.jelly
          src/main/resources/org/jenkinsci/plugins/cppcheck/CppcheckSourceAll/index.jelly
          http://jenkins-ci.org/commit/cppcheck-plugin/1f0faed8f2ae6e92ac7a4e46b5b5f43bf07f22a4
          Log:
          JENKINS-18109 Show all violations highlighted on a single page

          • New URL ".../cppcheckResult/source.all" points to a dynamic page rendered using a newly implemented class CppcheckSourceAll. Optional parameters are before=NUM and after=NUM to specify number of displayed lines, their default value is 5. A link was added above the table on the details page.
          • Variable cppcheckfile refactored to cppcheckFile (f/F) to prevent copy-paste errors.
          • Null check for return value of diffCurrentAndPrevious() removed, the method never returns null (found by FindBugs).
          • Source details show only part of the path relative to the workspace in the header instead of the very long absolute path, the method getFileNameHtmlWrap() removed.
          • Cppcheck message must be HTML escaped before passing to the page (e.g. "Comparison of a variable having boolean value using relational (<, >, <= or >=) operator.").
          • Missing space added to the tooltip on the page with source code of a whole file.
          • Annotations added to deprecated members present for backward compatibility.
          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Michal Turek Path: src/main/java/com/thalesgroup/hudson/plugins/cppcheck/CppcheckSource.java src/main/java/com/thalesgroup/hudson/plugins/cppcheck/model/CppcheckFile.java src/main/java/com/thalesgroup/hudson/plugins/cppcheck/model/CppcheckWorkspaceFile.java src/main/java/org/jenkinsci/plugins/cppcheck/CppcheckResult.java src/main/java/org/jenkinsci/plugins/cppcheck/CppcheckSourceAll.java src/main/resources/com/thalesgroup/hudson/plugins/cppcheck/CppcheckSource/index.jelly src/main/resources/org/jenkinsci/plugins/cppcheck/CppcheckResult/details.jelly src/main/resources/org/jenkinsci/plugins/cppcheck/CppcheckSourceAll/index.jelly http://jenkins-ci.org/commit/cppcheck-plugin/1f0faed8f2ae6e92ac7a4e46b5b5f43bf07f22a4 Log: JENKINS-18109 Show all violations highlighted on a single page New URL ".../cppcheckResult/source.all" points to a dynamic page rendered using a newly implemented class CppcheckSourceAll. Optional parameters are before=NUM and after=NUM to specify number of displayed lines, their default value is 5. A link was added above the table on the details page. Variable cppcheckfile refactored to cppcheckFile (f/F) to prevent copy-paste errors. Null check for return value of diffCurrentAndPrevious() removed, the method never returns null (found by FindBugs). Source details show only part of the path relative to the workspace in the header instead of the very long absolute path, the method getFileNameHtmlWrap() removed. Cppcheck message must be HTML escaped before passing to the page (e.g. "Comparison of a variable having boolean value using relational (<, >, <= or >=) operator."). Missing space added to the tooltip on the page with source code of a whole file. Annotations added to deprecated members present for backward compatibility.
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Michal Turek
          Path:
          src/main/java/com/thalesgroup/hudson/plugins/cppcheck/CppcheckSource.java
          src/main/java/com/thalesgroup/hudson/plugins/cppcheck/model/CppcheckFile.java
          src/main/java/com/thalesgroup/hudson/plugins/cppcheck/model/CppcheckWorkspaceFile.java
          src/main/java/org/jenkinsci/plugins/cppcheck/CppcheckResult.java
          src/main/java/org/jenkinsci/plugins/cppcheck/CppcheckSourceAll.java
          src/main/resources/com/thalesgroup/hudson/plugins/cppcheck/CppcheckSource/index.jelly
          src/main/resources/org/jenkinsci/plugins/cppcheck/CppcheckResult/details.jelly
          src/main/resources/org/jenkinsci/plugins/cppcheck/CppcheckSourceAll/index.jelly
          http://jenkins-ci.org/commit/cppcheck-plugin/cf2d85a3ea38643060db857777f2adad87a5e9e1
          Log:
          Merge pull request #14 from mixalturek/master

          JENKINS-18109 Show all violations highlighted on a single page

          Compare: https://github.com/jenkinsci/cppcheck-plugin/compare/1dba0fe34a4f...cf2d85a3ea38

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Michal Turek Path: src/main/java/com/thalesgroup/hudson/plugins/cppcheck/CppcheckSource.java src/main/java/com/thalesgroup/hudson/plugins/cppcheck/model/CppcheckFile.java src/main/java/com/thalesgroup/hudson/plugins/cppcheck/model/CppcheckWorkspaceFile.java src/main/java/org/jenkinsci/plugins/cppcheck/CppcheckResult.java src/main/java/org/jenkinsci/plugins/cppcheck/CppcheckSourceAll.java src/main/resources/com/thalesgroup/hudson/plugins/cppcheck/CppcheckSource/index.jelly src/main/resources/org/jenkinsci/plugins/cppcheck/CppcheckResult/details.jelly src/main/resources/org/jenkinsci/plugins/cppcheck/CppcheckSourceAll/index.jelly http://jenkins-ci.org/commit/cppcheck-plugin/cf2d85a3ea38643060db857777f2adad87a5e9e1 Log: Merge pull request #14 from mixalturek/master JENKINS-18109 Show all violations highlighted on a single page Compare: https://github.com/jenkinsci/cppcheck-plugin/compare/1dba0fe34a4f...cf2d85a3ea38
          Hide
          mixalturek Michal Turek added a comment -

          Implemented, will be released in version 1.16.

          Show
          mixalturek Michal Turek added a comment - Implemented, will be released in version 1.16.

            People

            • Assignee:
              mixalturek Michal Turek
              Reporter:
              exotic Jan Magur
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: