Details

    • Type: Bug
    • Status: Resolved (View Workflow)
    • Priority: Major
    • Resolution: Fixed
    • Component/s: viewVC-plugin
    • Labels:
      None
    • Environment:
      Centos 6.4 x64 (Linux kera 2.6.32-358.6.2.el6.x86_64 #1 SMP Thu May 16 20:59:36 UTC 2013 x86_64 x86_64 x86_64 GNU/Linux)
      Jenkins 1.517 (jenkins-1.517-1.1.noarch)
      ViewVC 1.6

    • Similar Issues:

      Description

      Hello,
      At Changes tab, for job, ViewVC links are correct, but for specified revision diff URLs lost part of the link.

      Project configuration (Source Code Management):
      URL - http://example.org/viewvc/branches/name/
      Repository - repo

      Example URL's:
      ViewVC URL - http://example.org/viewvc/branches/name/?view=rev&root=repo&revision=10
      Diff URL - http://example.org/branches/name/java/src/main/File.java?root=repo&r1=9&r2=10&diff_format=h

      Diff URL lost /viewvc/ part.

        Attachments

          Activity

          Hide
          mirumpf Michael Rumpf added a comment -

          Fixes have been merged

          Show
          mirumpf Michael Rumpf added a comment - Fixes have been merged
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: ducquoc
          Path:
          src/main/webapp/help-url.html
          http://jenkins-ci.org/commit/viewVC-plugin/659a0cf21103845a72094259dbc1a5fb121a5bd6
          Log:
          JENKINS-18283 updated sample URL in help-url to reflect non-root
          installation of viewVC

          Compare: https://github.com/jenkinsci/viewVC-plugin/compare/6f5be7804741...659a0cf21103

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: ducquoc Path: src/main/webapp/help-url.html http://jenkins-ci.org/commit/viewVC-plugin/659a0cf21103845a72094259dbc1a5fb121a5bd6 Log: JENKINS-18283 updated sample URL in help-url to reflect non-root installation of viewVC Compare: https://github.com/jenkinsci/viewVC-plugin/compare/6f5be7804741...659a0cf21103
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: ducquoc
          Path:
          src/main/java/hudson/plugins/viewVC/ViewVCRepositoryBrowser.java
          http://jenkins-ci.org/commit/viewVC-plugin/93e996630c54211e8fe0ddfa769bc0e929e76060
          Log:
          fixed JENKINS-18283 : Wrong URL in diff

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: ducquoc Path: src/main/java/hudson/plugins/viewVC/ViewVCRepositoryBrowser.java http://jenkins-ci.org/commit/viewVC-plugin/93e996630c54211e8fe0ddfa769bc0e929e76060 Log: fixed JENKINS-18283 : Wrong URL in diff
          Hide
          iplaman Idan Bidani added a comment - - edited

          We have the same issue
          I've had to compile it and manually upload the plugin.
          any chance to approve this pull request
          https://github.com/jenkinsci/viewVC-plugin/pull/1

          Show
          iplaman Idan Bidani added a comment - - edited We have the same issue I've had to compile it and manually upload the plugin. any chance to approve this pull request https://github.com/jenkinsci/viewVC-plugin/pull/1
          Hide
          arost Alexander Ost added a comment -

          The problem also exists on the LTS branch (1.509.4).

          Since the pull request is already available, is there any chance to get this released soon?

          Show
          arost Alexander Ost added a comment - The problem also exists on the LTS branch (1.509.4). Since the pull request is already available, is there any chance to get this released soon?
          Hide
          agabrys Adam Gabryś added a comment -

          Can you prepare a new release and close this bug?

          Show
          agabrys Adam Gabryś added a comment - Can you prepare a new release and close this bug?
          Hide
          ducquoc_vn Duc Quoc added a comment -

          I've opened a pull request for this issue
          https://github.com/jenkinsci/viewVC-plugin/pull/4

          Show
          ducquoc_vn Duc Quoc added a comment - I've opened a pull request for this issue https://github.com/jenkinsci/viewVC-plugin/pull/4

            People

            • Assignee:
              mirumpf Michael Rumpf
              Reporter:
              agabrys Adam Gabryś
            • Votes:
              4 Vote for this issue
              Watchers:
              7 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: