Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-18368

Decorated Launcher Does Not Maintain "isUnix" for RemoteLauncher

    Details

    • Similar Issues:

      Description

      RemoteLauncher's isUnix attribute is supplied on construction for slaves. However, when the RemoteLauncher is passed through decorateByEnv, because the anonymous class created in this method does not override isUnix, it delegates back to the base Launcher's File.pathSeparatorChar==':' check. The value for the slave passed into RemoteLauncher on construction is lost. A similar problem occurs with decorateByPrefix.

      This will cause a problem if any downstream logic depends on the Launcher's isUnix value for a process launched on a slave with a different isUnix value than the master. For example, with a Windows master and a Linux slave, the wrong file path separator is selected in a regex on the history output, and so the SCM polling does not accurately pick up changes.

        Attachments

          Issue Links

            Activity

            tslantz Timothy Lantz created issue -
            tslantz Timothy Lantz made changes -
            Field Original Value New Value
            Link This issue is related to JENKINS-3496 [ JENKINS-3496 ]
            tslantz Timothy Lantz made changes -
            Link This issue is related to JENKINS-13285 [ JENKINS-13285 ]
            tslantz Timothy Lantz made changes -
            Link This issue is related to JENKINS-12911 [ JENKINS-12911 ]
            tslantz Timothy Lantz made changes -
            Assignee Timothy Lantz [ tslantz ]
            jglick Jesse Glick made changes -
            Status Open [ 1 ] Resolved [ 5 ]
            Resolution Fixed [ 1 ]
            bullhornrelease Bullhorn RelEng made changes -
            Link This issue is related to JENKINS-15585 [ JENKINS-15585 ]
            jglick Jesse Glick made changes -
            Labels lts-candidate
            jglick Jesse Glick made changes -
            Labels lts-candidate lts-candidate regression
            olivergondza Oliver Gondža made changes -
            Labels lts-candidate regression lts-1.509.3-fixed regression
            olivergondza Oliver Gondža made changes -
            Labels lts-1.509.3-fixed regression 1.509.3-fixed regression
            rtyler R. Tyler Croy made changes -
            Workflow JNJira [ 149675 ] JNJira + In-Review [ 193238 ]

              People

              • Assignee:
                tslantz Timothy Lantz
                Reporter:
                tslantz Timothy Lantz
              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: