Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-18543

Update to newest MSBuild plugin breaks passing of release configurations with spaces in them

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Resolved (View Workflow)
    • Priority: Blocker
    • Resolution: Fixed
    • Component/s: msbuild-plugin
    • Labels:
      None
    • Environment:
      Jenkins 1.520, Win7 64 bit, Java 7
    • Similar Issues:

      Description

      The fix from #17876 breaks my builds which are using parameters with spaces, f.i.

      Path To MSBuild.exe: c:\Windows\Microsoft.NET\Framework\v4.0.30319\MSBuild.exe
      15:28:23 Executing the command cmd.exe /C c:\Windows\Microsoft.NET\Framework\v4.0.30319\MSBuild.exe "/p:Configuration="Release Wcdma"" /p:Platform=x86 /p:CheckIn=true /p:CheckOut=true /p:Crypt=true /t:rebuild C:\Snapshots\RS-CONTEST-RF-WCDMA_2.4x\contest_sw\Conformance.sln && exit %%ERRORLEVEL%% from C:\Snapshots\RS-CONTEST-RF-WCDMA_2.4x
      15:28:23 [RS-CONTEST-RF-WCDMA_2.4x] $ cmd.exe /C c:\Windows\Microsoft.NET\Framework\v4.0.30319\MSBuild.exe '/p:Configuration="Release Wcdma"' /p:Platform=x86 /p:CheckIn=true /p:CheckOut=true /p:Crypt=true /t:rebuild C:\Snapshots\RS-CONTEST-RF-WCDMA_2.4x\contest_sw\Conformance.sln && exit %%ERRORLEVEL%%
      15:28:23 Microsoft (R) Build Engine Version 4.0.30319.1
      15:28:23 [Microsoft .NET Framework, Version 4.0.30319.296]
      15:28:23 Copyright (C) Microsoft Corporation 2007. All rights reserved.
      15:28:23
      15:28:23 MSBUILD : error MSB1008: Only one project can be specified.
      15:28:23 Switch: C:\Snapshots\RS-CONTEST-RF-WCDMA_2.4x\contest_sw\Conformance.sln

      Note the parameter "/p:Configuration="Release Wcdma"" which was '/p:Configuration="Release Wcdma"' in the GUI. Without the single quotes (/p:Configuration="Release Wcdma") the result is the same...

      Downgrading to the previous version of the msbuild plugin fixes the problem.

        Attachments

          Issue Links

            Activity

            Hide
            tfields Thomas Fields added a comment -

            I found this issue too (https://issues.jenkins-ci.org/browse/JENKINS-18560) - any chance of a fix?

            Thanks,
            Tom

            Show
            tfields Thomas Fields added a comment - I found this issue too ( https://issues.jenkins-ci.org/browse/JENKINS-18560 ) - any chance of a fix? Thanks, Tom
            Hide
            tyrius Jonathan Zimmerman added a comment -

            Can you paste the msbuild command line that you get with 1.17?

            Show
            tyrius Jonathan Zimmerman added a comment - Can you paste the msbuild command line that you get with 1.17?
            Hide
            tyrius Jonathan Zimmerman added a comment - - edited

            When I authored the fix for JENKINS-17876 I included unit tests that were supposed to verify proper functionality. Unfortunately things get mangled further along when the external process is actually launched which were not caught by the tests. I think in my case escaping the quotes around the parameter value may solve the original problem, so I'll revert the break from my previous commit and look for another way around my issue.

            Show
            tyrius Jonathan Zimmerman added a comment - - edited When I authored the fix for JENKINS-17876 I included unit tests that were supposed to verify proper functionality. Unfortunately things get mangled further along when the external process is actually launched which were not caught by the tests. I think in my case escaping the quotes around the parameter value may solve the original problem, so I'll revert the break from my previous commit and look for another way around my issue.
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: jzimmerman
            Path:
            src/main/java/hudson/plugins/msbuild/MsBuildBuilder.java
            src/test/java/hudson/plugins/msbuild/MsBuildBuilderTest.java
            http://jenkins-ci.org/commit/msbuild-plugin/ed6d6d97884a395b7c149d0a773eab6bc76af753
            Log:
            [FIXED JENKINS-18543] Revert break from commit 11525049ed173f941d6ec6e87694269ef40d9920

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: jzimmerman Path: src/main/java/hudson/plugins/msbuild/MsBuildBuilder.java src/test/java/hudson/plugins/msbuild/MsBuildBuilderTest.java http://jenkins-ci.org/commit/msbuild-plugin/ed6d6d97884a395b7c149d0a773eab6bc76af753 Log: [FIXED JENKINS-18543] Revert break from commit 11525049ed173f941d6ec6e87694269ef40d9920
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Gregory Boissinot
            Path:
            src/main/java/hudson/plugins/msbuild/MsBuildBuilder.java
            src/test/java/hudson/plugins/msbuild/MsBuildBuilderTest.java
            http://jenkins-ci.org/commit/msbuild-plugin/07f777ed18603bc8e66c3eb0e3c9523c1a9ed784
            Log:
            Merge pull request #8 from tyrius02/master

            [FIXED JENKINS-18543] Revert break from commit 11525049ed173f941d6ec6e87...

            Compare: https://github.com/jenkinsci/msbuild-plugin/compare/6bd00887edd5...07f777ed1860

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Gregory Boissinot Path: src/main/java/hudson/plugins/msbuild/MsBuildBuilder.java src/test/java/hudson/plugins/msbuild/MsBuildBuilderTest.java http://jenkins-ci.org/commit/msbuild-plugin/07f777ed18603bc8e66c3eb0e3c9523c1a9ed784 Log: Merge pull request #8 from tyrius02/master [FIXED JENKINS-18543] Revert break from commit 11525049ed173f941d6ec6e87... Compare: https://github.com/jenkinsci/msbuild-plugin/compare/6bd00887edd5...07f777ed1860

              People

              • Assignee:
                kdsweeney kdsweeney
                Reporter:
                bruce Dirk Kuypers
              • Votes:
                2 Vote for this issue
                Watchers:
                7 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: