Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-1884

CI game awards points for violations 'fixes' in broken buld

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed (View Workflow)
    • Priority: Trivial
    • Resolution: Fixed
    • Component/s: ci-game-plugin
    • Labels:
      None
    • Environment:
      Platform: PC, OS: Windows XP
    • Similar Issues:

      Description

      We lost CVS access, so Hudson builds started failing. A failed build that uses
      both 'violations' and 'ci game' plugins had the line 'This build was worth
      12730.0 points' on the failed build. When I looked at the details they were:

      10104 Checkstyle violations were fixed: 10104 pts
      2008 PMD violations were fixed: 2008 pts
      523 FindBugs violations were fixed: 523 pts
      21 CPD violations were fixed: 21 pts
      The build faield: -10 pts

      As it was a CVS failure I'm not sure it would ever award this number of points
      to whoever broke the build as it can't determine what has changed, butu it does
      indicate a minor logic failure somewhere

        Attachments

          Activity

          Hide
          redsolo redsolo added a comment -

          Confirmed and found the error

          Show
          redsolo redsolo added a comment - Confirmed and found the error
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in hudson
          User: : redsolo
          Path:
          trunk/hudson/plugins/ci-game/pom.xml
          trunk/hudson/plugins/ci-game/src/main/java/hudson/plugins/cigame/rules/plugins/checkstyle/DefaultCheckstyleRule.java
          trunk/hudson/plugins/ci-game/src/main/java/hudson/plugins/cigame/rules/plugins/findbugs/FixedFindBugsWarningsRule.java
          trunk/hudson/plugins/ci-game/src/main/java/hudson/plugins/cigame/rules/plugins/findbugs/NewFindBugsWarningsRule.java
          trunk/hudson/plugins/ci-game/src/main/java/hudson/plugins/cigame/rules/plugins/opentasks/DefaultOpenTasksRule.java
          trunk/hudson/plugins/ci-game/src/main/java/hudson/plugins/cigame/rules/plugins/pmd/DefaultPmdRule.java
          trunk/hudson/plugins/ci-game/src/main/java/hudson/plugins/cigame/rules/plugins/violation/DefaultViolationRule.java
          trunk/hudson/plugins/ci-game/src/main/java/hudson/plugins/cigame/rules/plugins/warnings/DefaultWarningsRule.java
          trunk/hudson/plugins/ci-game/src/test/java/hudson/plugins/cigame/rules/plugins/findbugs/FixedFindBugsWarningsRuleTest.java
          trunk/hudson/plugins/ci-game/src/test/java/hudson/plugins/cigame/rules/plugins/findbugs/NewFindBugsWarningsRuleTest.java
          trunk/hudson/plugins/ci-game/src/test/java/hudson/plugins/cigame/rules/plugins/opentasks/DefaultOpenTasksRuleTest.java
          trunk/hudson/plugins/ci-game/src/test/java/hudson/plugins/cigame/rules/plugins/pmd/DefaultPmdRuleTest.java
          trunk/hudson/plugins/ci-game/src/test/java/hudson/plugins/cigame/rules/plugins/violation/DefaultViolationRuleTest.java
          trunk/hudson/plugins/ci-game/src/test/java/hudson/plugins/cigame/rules/plugins/warnings/DefaultWarningsRuleTest.java
          http://fisheye4.cenqua.com/changelog/hudson/?cs=10199
          Log:
          [FIXED JENKINS-1884] CI game no longer awards points for violations 'fixes' in broken buld

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in hudson User: : redsolo Path: trunk/hudson/plugins/ci-game/pom.xml trunk/hudson/plugins/ci-game/src/main/java/hudson/plugins/cigame/rules/plugins/checkstyle/DefaultCheckstyleRule.java trunk/hudson/plugins/ci-game/src/main/java/hudson/plugins/cigame/rules/plugins/findbugs/FixedFindBugsWarningsRule.java trunk/hudson/plugins/ci-game/src/main/java/hudson/plugins/cigame/rules/plugins/findbugs/NewFindBugsWarningsRule.java trunk/hudson/plugins/ci-game/src/main/java/hudson/plugins/cigame/rules/plugins/opentasks/DefaultOpenTasksRule.java trunk/hudson/plugins/ci-game/src/main/java/hudson/plugins/cigame/rules/plugins/pmd/DefaultPmdRule.java trunk/hudson/plugins/ci-game/src/main/java/hudson/plugins/cigame/rules/plugins/violation/DefaultViolationRule.java trunk/hudson/plugins/ci-game/src/main/java/hudson/plugins/cigame/rules/plugins/warnings/DefaultWarningsRule.java trunk/hudson/plugins/ci-game/src/test/java/hudson/plugins/cigame/rules/plugins/findbugs/FixedFindBugsWarningsRuleTest.java trunk/hudson/plugins/ci-game/src/test/java/hudson/plugins/cigame/rules/plugins/findbugs/NewFindBugsWarningsRuleTest.java trunk/hudson/plugins/ci-game/src/test/java/hudson/plugins/cigame/rules/plugins/opentasks/DefaultOpenTasksRuleTest.java trunk/hudson/plugins/ci-game/src/test/java/hudson/plugins/cigame/rules/plugins/pmd/DefaultPmdRuleTest.java trunk/hudson/plugins/ci-game/src/test/java/hudson/plugins/cigame/rules/plugins/violation/DefaultViolationRuleTest.java trunk/hudson/plugins/ci-game/src/test/java/hudson/plugins/cigame/rules/plugins/warnings/DefaultWarningsRuleTest.java http://fisheye4.cenqua.com/changelog/hudson/?cs=10199 Log: [FIXED JENKINS-1884] CI game no longer awards points for violations 'fixes' in broken buld

            People

            • Assignee:
              redsolo redsolo
              Reporter:
              jimaltio jimaltio
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: