Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-18918

Test harness packs copies of Maven into plugin archive

    XMLWordPrintable

    Details

    • Similar Issues:

      Description

      https://groups.google.com/d/msg/jenkinsci-dev/8n6vqak8khE/MTM1Vs-1g3sJ

      The test harness was accidentally including copies of Maven in plugin archives if you ran tests that ran Maven builds, as would be common during mvn release:prepare release:perform.

        Attachments

          Activity

          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Jesse Glick
          Path:
          changelog.html
          test/src/main/java/org/jvnet/hudson/test/HudsonTestCase.java
          test/src/main/java/org/jvnet/hudson/test/JenkinsRule.java
          http://jenkins-ci.org/commit/jenkins/2152cf478e26e01b90be8c818cfe3bb628b32263
          Log:
          [FIXED JENKINS-18918] From plugins we must use target/ not target/classes/ to unpack Maven.
          Also cleaning up variable names to be less misleading.

          Note that new File("target") is really a bad idea since we cannot predict the CWD in effect when Maven is run.
          (From the standard bin/mvn launcher, it seems that it will always be some Maven project at least.
          This may not be true for Maven run embedded from various tools.)
          But leaving that as is for now, since it is not clear how else we would find the project location.
          (new File(env.description().getTestClass().getProtectionDomain().getCodeSource().getLocation().toURI()).getParentFile() might work but it is pretty hacky.)

          Compare: https://github.com/jenkinsci/jenkins/compare/11953750ab42...2152cf478e26

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: changelog.html test/src/main/java/org/jvnet/hudson/test/HudsonTestCase.java test/src/main/java/org/jvnet/hudson/test/JenkinsRule.java http://jenkins-ci.org/commit/jenkins/2152cf478e26e01b90be8c818cfe3bb628b32263 Log: [FIXED JENKINS-18918] From plugins we must use target/ not target/classes/ to unpack Maven. Also cleaning up variable names to be less misleading. Note that new File("target") is really a bad idea since we cannot predict the CWD in effect when Maven is run. (From the standard bin/mvn launcher, it seems that it will always be some Maven project at least. This may not be true for Maven run embedded from various tools.) But leaving that as is for now, since it is not clear how else we would find the project location. (new File(env.description().getTestClass().getProtectionDomain().getCodeSource().getLocation().toURI()).getParentFile() might work but it is pretty hacky.) Compare: https://github.com/jenkinsci/jenkins/compare/11953750ab42...2152cf478e26
          Hide
          dogfood dogfood added a comment -

          Integrated in jenkins_main_trunk #2749
          [FIXED JENKINS-18918] From plugins we must use target/ not target/classes/ to unpack Maven. (Revision 2152cf478e26e01b90be8c818cfe3bb628b32263)

          Result = SUCCESS
          Jesse Glick : 2152cf478e26e01b90be8c818cfe3bb628b32263
          Files :

          • changelog.html
          • test/src/main/java/org/jvnet/hudson/test/JenkinsRule.java
          • test/src/main/java/org/jvnet/hudson/test/HudsonTestCase.java
          Show
          dogfood dogfood added a comment - Integrated in jenkins_main_trunk #2749 [FIXED JENKINS-18918] From plugins we must use target/ not target/classes/ to unpack Maven. (Revision 2152cf478e26e01b90be8c818cfe3bb628b32263) Result = SUCCESS Jesse Glick : 2152cf478e26e01b90be8c818cfe3bb628b32263 Files : changelog.html test/src/main/java/org/jvnet/hudson/test/JenkinsRule.java test/src/main/java/org/jvnet/hudson/test/HudsonTestCase.java
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Jesse Glick
          Path:
          changelog.html
          test/src/main/java/org/jvnet/hudson/test/HudsonTestCase.java
          test/src/main/java/org/jvnet/hudson/test/JenkinsRule.java
          http://jenkins-ci.org/commit/jenkins/31c302cc7e4a63727f7684eef3cf6ce5bc7aa12d
          Log:
          [FIXED JENKINS-18918] From plugins we must use target/ not target/classes/ to unpack Maven.
          Also cleaning up variable names to be less misleading.

          Note that new File("target") is really a bad idea since we cannot predict the CWD in effect when Maven is run.
          (From the standard bin/mvn launcher, it seems that it will always be some Maven project at least.
          This may not be true for Maven run embedded from various tools.)
          But leaving that as is for now, since it is not clear how else we would find the project location.
          (new File(env.description().getTestClass().getProtectionDomain().getCodeSource().getLocation().toURI()).getParentFile() might work but it is pretty hacky.)
          (cherry picked from commit 2152cf478e26e01b90be8c818cfe3bb628b32263)

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: changelog.html test/src/main/java/org/jvnet/hudson/test/HudsonTestCase.java test/src/main/java/org/jvnet/hudson/test/JenkinsRule.java http://jenkins-ci.org/commit/jenkins/31c302cc7e4a63727f7684eef3cf6ce5bc7aa12d Log: [FIXED JENKINS-18918] From plugins we must use target/ not target/classes/ to unpack Maven. Also cleaning up variable names to be less misleading. Note that new File("target") is really a bad idea since we cannot predict the CWD in effect when Maven is run. (From the standard bin/mvn launcher, it seems that it will always be some Maven project at least. This may not be true for Maven run embedded from various tools.) But leaving that as is for now, since it is not clear how else we would find the project location. (new File(env.description().getTestClass().getProtectionDomain().getCodeSource().getLocation().toURI()).getParentFile() might work but it is pretty hacky.) (cherry picked from commit 2152cf478e26e01b90be8c818cfe3bb628b32263)
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Jesse Glick
          Path:
          test/src/main/java/org/jvnet/hudson/test/HudsonTestCase.java
          test/src/main/java/org/jvnet/hudson/test/JenkinsRule.java
          http://jenkins-ci.org/commit/jenkins-test-harness/41570338fb55aa1a40bd29b133af1380d9313803
          Log:
          [FIXED JENKINS-18918] From plugins we must use target/ not target/classes/ to unpack Maven.
          Also cleaning up variable names to be less misleading.

          Note that new File("target") is really a bad idea since we cannot predict the CWD in effect when Maven is run.
          (From the standard bin/mvn launcher, it seems that it will always be some Maven project at least.
          This may not be true for Maven run embedded from various tools.)
          But leaving that as is for now, since it is not clear how else we would find the project location.
          (new File(env.description().getTestClass().getProtectionDomain().getCodeSource().getLocation().toURI()).getParentFile() might work but it is pretty hacky.)
          Originally-Committed-As: 2152cf478e26e01b90be8c818cfe3bb628b32263

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: test/src/main/java/org/jvnet/hudson/test/HudsonTestCase.java test/src/main/java/org/jvnet/hudson/test/JenkinsRule.java http://jenkins-ci.org/commit/jenkins-test-harness/41570338fb55aa1a40bd29b133af1380d9313803 Log: [FIXED JENKINS-18918] From plugins we must use target/ not target/classes/ to unpack Maven. Also cleaning up variable names to be less misleading. Note that new File("target") is really a bad idea since we cannot predict the CWD in effect when Maven is run. (From the standard bin/mvn launcher, it seems that it will always be some Maven project at least. This may not be true for Maven run embedded from various tools.) But leaving that as is for now, since it is not clear how else we would find the project location. (new File(env.description().getTestClass().getProtectionDomain().getCodeSource().getLocation().toURI()).getParentFile() might work but it is pretty hacky.) Originally-Committed-As: 2152cf478e26e01b90be8c818cfe3bb628b32263

            People

            • Assignee:
              Unassigned
              Reporter:
              jglick Jesse Glick
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: