Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-19034

Permalinks can be created which point to a nonexistent build symlink

    Details

    • Similar Issues:

      Description

      A user reported a situation with a project which had a number of builds, none of which had associated numeric symlinks because the master was running on Windows at the time. Then the master was switched to Unix. Jenkins created a lastSuccessfulBuild symlink, but it was pointing to a nonexistent numeric symlink. It should either avoid creating the permalink in this case, or first create the numeric symlink.

        Attachments

          Issue Links

            Activity

            jglick Jesse Glick created issue -
            jglick Jesse Glick made changes -
            Field Original Value New Value
            URL https://github.com/jenkinsci/jenkins/pull/891
            jglick Jesse Glick made changes -
            Link This issue is related to JENKINS-18846 [ JENKINS-18846 ]
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Nicolas De Loof
            Path:
            changelog.html
            core/src/main/java/jenkins/model/PeepholePermalink.java
            test/src/test/groovy/jenkins/model/PeepholePermalinkTest.groovy
            http://jenkins-ci.org/commit/jenkins/2f7520c3d455ec8f24632f7307363fc6b383dc87
            Log:
            [FIXED JENKINS-19034] restore missing buildnumber-ID symlink when updating permalink

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Nicolas De Loof Path: changelog.html core/src/main/java/jenkins/model/PeepholePermalink.java test/src/test/groovy/jenkins/model/PeepholePermalinkTest.groovy http://jenkins-ci.org/commit/jenkins/2f7520c3d455ec8f24632f7307363fc6b383dc87 Log: [FIXED JENKINS-19034] restore missing buildnumber-ID symlink when updating permalink
            scm_issue_link SCM/JIRA link daemon made changes -
            Status Open [ 1 ] Resolved [ 5 ]
            Resolution Fixed [ 1 ]
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Jesse Glick
            Path:
            changelog.html
            core/src/main/java/jenkins/model/PeepholePermalink.java
            test/src/test/groovy/jenkins/model/PeepholePermalinkTest.groovy
            http://jenkins-ci.org/commit/jenkins/62ed20ee3f1558dfecb69a82674166ebbb2e7414
            Log:
            Merge pull request #891 from ndeloof/JENKINS-19034

            [FIXED JENKINS-19034] restore missing buildnumber-ID symlink

            Compare: https://github.com/jenkinsci/jenkins/compare/06ccff707c24...62ed20ee3f15

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: changelog.html core/src/main/java/jenkins/model/PeepholePermalink.java test/src/test/groovy/jenkins/model/PeepholePermalinkTest.groovy http://jenkins-ci.org/commit/jenkins/62ed20ee3f1558dfecb69a82674166ebbb2e7414 Log: Merge pull request #891 from ndeloof/ JENKINS-19034 [FIXED JENKINS-19034] restore missing buildnumber-ID symlink Compare: https://github.com/jenkinsci/jenkins/compare/06ccff707c24...62ed20ee3f15
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Jesse Glick
            Path:
            changelog.html
            test/src/test/groovy/jenkins/model/PeepholePermalinkTest.groovy
            http://jenkins-ci.org/commit/jenkins/259f16bdad2df71e4e83d62183638d889d8bb9cf
            Log:
            JENKINS-19034 Noting.

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: changelog.html test/src/test/groovy/jenkins/model/PeepholePermalinkTest.groovy http://jenkins-ci.org/commit/jenkins/259f16bdad2df71e4e83d62183638d889d8bb9cf Log: JENKINS-19034 Noting.
            Hide
            dogfood dogfood added a comment -

            Integrated in jenkins_main_trunk #2871
            [FIXED JENKINS-19034] restore missing buildnumber-ID symlink when updating permalink (Revision 2f7520c3d455ec8f24632f7307363fc6b383dc87)
            JENKINS-19034 Noting. (Revision 259f16bdad2df71e4e83d62183638d889d8bb9cf)

            Result = SUCCESS
            Nicolas De Loof : 2f7520c3d455ec8f24632f7307363fc6b383dc87
            Files :

            • test/src/test/groovy/jenkins/model/PeepholePermalinkTest.groovy
            • core/src/main/java/jenkins/model/PeepholePermalink.java
            • changelog.html

            Jesse Glick : 259f16bdad2df71e4e83d62183638d889d8bb9cf
            Files :

            • changelog.html
            • test/src/test/groovy/jenkins/model/PeepholePermalinkTest.groovy
            Show
            dogfood dogfood added a comment - Integrated in jenkins_main_trunk #2871 [FIXED JENKINS-19034] restore missing buildnumber-ID symlink when updating permalink (Revision 2f7520c3d455ec8f24632f7307363fc6b383dc87) JENKINS-19034 Noting. (Revision 259f16bdad2df71e4e83d62183638d889d8bb9cf) Result = SUCCESS Nicolas De Loof : 2f7520c3d455ec8f24632f7307363fc6b383dc87 Files : test/src/test/groovy/jenkins/model/PeepholePermalinkTest.groovy core/src/main/java/jenkins/model/PeepholePermalink.java changelog.html Jesse Glick : 259f16bdad2df71e4e83d62183638d889d8bb9cf Files : changelog.html test/src/test/groovy/jenkins/model/PeepholePermalinkTest.groovy
            danielbeck Daniel Beck made changes -
            Labels lazy-loading symlink lazy-loading lts-candidate symlink
            olivergondza Oliver Gond┼ża made changes -
            Labels lazy-loading lts-candidate symlink 1.509.4-rejected lazy-loading symlink
            rtyler R. Tyler Croy made changes -
            Workflow JNJira [ 150481 ] JNJira + In-Review [ 193541 ]

              People

              • Assignee:
                Unassigned
                Reporter:
                jglick Jesse Glick
              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: