Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-19217

Change class names to not contain package names on result pages (increases readability)

    Details

    • Similar Issues:

      Description

      no need to include package name in the class name.

      Simple name when displaying Class Results should be sufficient.

        Attachments

          Activity

          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Nalin Makar
          Path:
          README
          src/main/java/hudson/plugins/testng/parser/ResultsParser.java
          src/main/java/hudson/plugins/testng/results/ClassResult.java
          src/main/java/hudson/plugins/testng/results/PackageResult.java
          src/main/java/hudson/plugins/testng/results/TestNGResult.java
          src/test/java/hudson/plugins/testng/results/ClassResultTest.java
          src/test/java/hudson/plugins/testng/results/MethodResultTest.java
          http://jenkins-ci.org/commit/testng-plugin-plugin/5f25af9290d6e3e31a819e2b8381a98cf5741a61
          Log:
          Fixed: JENKINS-19217 - Change class names to not contain package names on result pages

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Nalin Makar Path: README src/main/java/hudson/plugins/testng/parser/ResultsParser.java src/main/java/hudson/plugins/testng/results/ClassResult.java src/main/java/hudson/plugins/testng/results/PackageResult.java src/main/java/hudson/plugins/testng/results/TestNGResult.java src/test/java/hudson/plugins/testng/results/ClassResultTest.java src/test/java/hudson/plugins/testng/results/MethodResultTest.java http://jenkins-ci.org/commit/testng-plugin-plugin/5f25af9290d6e3e31a819e2b8381a98cf5741a61 Log: Fixed: JENKINS-19217 - Change class names to not contain package names on result pages
          Hide
          nullin Nalin Makar added a comment -

          Fixed in v1.7

          Show
          nullin Nalin Makar added a comment - Fixed in v1.7
          Hide
          actine Paul Danyliuk added a comment - - edited

          Ugh... You should have made this configurable. Since, you know, http://xkcd.com/1172/
          I used to sort the table with results to spot similar issues in tests from adjacent packages — like, we have a package with REST API test classes, Selenium test classes etc. Now it's like sorting the dates where day comes before month.

          Show
          actine Paul Danyliuk added a comment - - edited Ugh... You should have made this configurable. Since, you know, http://xkcd.com/1172/ I used to sort the table with results to spot similar issues in tests from adjacent packages — like, we have a package with REST API test classes, Selenium test classes etc. Now it's like sorting the dates where day comes before month.
          Hide
          nullin Nalin Makar added a comment -

          Paul, which result page are you talking about? I don't want to make it configurable, but I can always add back package to the name if it makes sense.

          Show
          nullin Nalin Makar added a comment - Paul, which result page are you talking about? I don't want to make it configurable, but I can always add back package to the name if it makes sense.
          Hide
          actine Paul Danyliuk added a comment -

          Nalin,
          Well, I used to sort the table on the TestNG Results page for specific builds (/job/my-job-name/123/testngreports/).

          The two other places where it might make sense to keep package names (up to your consideration) are:

          • TestNG Results page for a job, where list of failed tests is rendered (/job/my-job-name/testngreports/);
          • A specific build overview page, where such list is also present (/job/my-job-name/123)

          In per-package report pages (job/my-job-name/123/testngreports/org.myorganization.test.feature/), the package name before class name is indeed not needed.

          Sorry that I cannot provide screenshots, hope that URL's of pages would be enough to understand what I mean.

          Show
          actine Paul Danyliuk added a comment - Nalin, Well, I used to sort the table on the TestNG Results page for specific builds (/job/my-job-name/123/testngreports/). The two other places where it might make sense to keep package names (up to your consideration) are: TestNG Results page for a job, where list of failed tests is rendered (/job/my-job-name/testngreports/); A specific build overview page, where such list is also present (/job/my-job-name/123) In per-package report pages (job/my-job-name/123/testngreports/org.myorganization.test.feature/), the package name before class name is indeed not needed. Sorry that I cannot provide screenshots, hope that URL's of pages would be enough to understand what I mean.
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Nalin Makar
          Path:
          README
          src/main/java/hudson/plugins/testng/util/TestResultHistoryUtil.java
          src/main/resources/hudson/plugins/testng/TestNGTestResultBuildAction/reportDetail.groovy
          src/main/resources/hudson/plugins/testng/results/MethodResult/reportDetail.groovy
          src/test/java/hudson/plugins/testng/TestNGProjectActionTest.java
          src/test/java/hudson/plugins/testng/TestNGTestResultBuildActionTest.java
          src/test/java/hudson/plugins/testng/results/MethodResultTest.java
          http://jenkins-ci.org/commit/testng-plugin-plugin/a10f639d9cfd0235f0bc11c700632a2b6639b1c4
          Log:
          Fixed: Added back package names in certain places where they were helpful (see JENKINS-19217)

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Nalin Makar Path: README src/main/java/hudson/plugins/testng/util/TestResultHistoryUtil.java src/main/resources/hudson/plugins/testng/TestNGTestResultBuildAction/reportDetail.groovy src/main/resources/hudson/plugins/testng/results/MethodResult/reportDetail.groovy src/test/java/hudson/plugins/testng/TestNGProjectActionTest.java src/test/java/hudson/plugins/testng/TestNGTestResultBuildActionTest.java src/test/java/hudson/plugins/testng/results/MethodResultTest.java http://jenkins-ci.org/commit/testng-plugin-plugin/a10f639d9cfd0235f0bc11c700632a2b6639b1c4 Log: Fixed: Added back package names in certain places where they were helpful (see JENKINS-19217 )
          Hide
          nullin Nalin Makar added a comment -

          Paul, fixed and released this in v1.8.

          Show
          nullin Nalin Makar added a comment - Paul, fixed and released this in v1.8.
          Hide
          actine Paul Danyliuk added a comment -

          @Nalin, thank you!

          Show
          actine Paul Danyliuk added a comment - @Nalin, thank you!

            People

            • Assignee:
              nullin Nalin Makar
              Reporter:
              nullin Nalin Makar
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: